From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7E786C2D0D1 for ; Thu, 19 Dec 2019 23:29:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4EB9624680 for ; Thu, 19 Dec 2019 23:29:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="LIYGkG4+" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727125AbfLSX3L (ORCPT ); Thu, 19 Dec 2019 18:29:11 -0500 Received: from mail-pf1-f194.google.com ([209.85.210.194]:37378 "EHLO mail-pf1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726880AbfLSX3L (ORCPT ); Thu, 19 Dec 2019 18:29:11 -0500 Received: by mail-pf1-f194.google.com with SMTP id p14so4154421pfn.4 for ; Thu, 19 Dec 2019 15:29:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=Jsi+F0iX2PzBdBAMLJPSaUkUuxSr3VLCQXp5gSjIoW8=; b=LIYGkG4+kJk0lp1PkIDafWCnaoooIAJXV1BFG4P86uc8iWle3bJipXQbjnuAyBFvdj /eGVwgZEG6jXAmnujn9RyenMxtf9baMOH+xarAEBG5Uvts3b1XnuDrgSxBqXP81bXwA1 relGzchU1zH/YqQ66+QXAhhALXdnw2Jo6Svek= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=Jsi+F0iX2PzBdBAMLJPSaUkUuxSr3VLCQXp5gSjIoW8=; b=A1UZAhsy+ol7+CanqhQ1tvWaqCLcD20Q3W5K2QN2SzdRpbHQOwovA9QQMLNnxzBHjk gs5wQEGyfndDLfhZDQUPXLoTWv1VhwdDKmziIQ+066idVcOZNH4oH34uB7fn2GBVcm8x aPEXnFwlVeYpYCgQS8sMnM0ilxMX0Z2kNpcr3klxOTLySTzR7VKkKIXOwKbpRzcg+cde kVKIF258LLbQltosDuRUmKydOQsyU7TGapobU/8MD9uUc7wveB5rzC9M1nCxguO8f2mU AcIElQtwWc48i99Po0VawhGV1bgow/ArkQTHP8EtS+GYH0eeioe4Ko1XM6BUo4ZihMxz gVoA== X-Gm-Message-State: APjAAAUTINjfuOuoNxGT6vI8Tl0TKMGr5UwJAIwUGpVuaW/4x7CoFSSU loHoJosytvBvpRrYq466WMee9A== X-Google-Smtp-Source: APXvYqxnxUNXSFAedpvMV3Vof65Su8H7bj4aXmgynUniBeReHLqhhSUJJOJXjjHnv73UGqdw4rJhtQ== X-Received: by 2002:a63:504f:: with SMTP id q15mr11563591pgl.8.1576798150841; Thu, 19 Dec 2019 15:29:10 -0800 (PST) Received: from localhost ([2620:15c:202:1:4fff:7a6b:a335:8fde]) by smtp.gmail.com with ESMTPSA id e12sm8087062pjs.3.2019.12.19.15.29.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 19 Dec 2019 15:29:10 -0800 (PST) Date: Thu, 19 Dec 2019 15:29:08 -0800 From: Matthias Kaehlcke To: Veerabhadrarao Badiganti Cc: adrian.hunter@intel.com, ulf.hansson@linaro.org, robh+dt@kernel.org, asutoshd@codeaurora.org, stummala@codeaurora.org, sayalil@codeaurora.org, cang@codeaurora.org, rampraka@codeaurora.org, linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, Andy Gross , Bjorn Andersson , Mark Rutland Subject: Re: [PATCH V2] arm64: dts: qcom: sc7180: Add nodes for eMMC and SD card Message-ID: <20191219232908.GA228856@google.com> References: <1576288475-7606-1-git-send-email-vbadigan@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1576288475-7606-1-git-send-email-vbadigan@codeaurora.org> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Sat, Dec 14, 2019 at 07:24:34AM +0530, Veerabhadrarao Badiganti wrote: > Add sdhc instances for supporting eMMC and SD-card on sc7180. > The regulators should be in HPM state for proper functionality of > eMMC and SD-card. Updating corresponding regulators accordingly. > > Signed-off-by: Veerabhadrarao Badiganti > --- > > This depends on the patch series (dt support for sc7180): > https://lkml.org/lkml/2019/11/8/149 > Also depends on documentation commit 2078158 (Present on mmc-next) > > Changes since V1: > - Updated the regulator min, max voltages as per > eMMC/SD-card voltage requirements > - Enabled IOMMU for eMMC and SD-card. > - Added pull and drive strength to SD-card cd-gpio. > - Incorporated review comments by Matthias Kaehlcke. > --- > arch/arm64/boot/dts/qcom/sc7180-idp.dts | 47 +++++++--- > arch/arm64/boot/dts/qcom/sc7180.dtsi | 148 ++++++++++++++++++++++++++++++++ > 2 files changed, 183 insertions(+), 12 deletions(-) > > diff --git a/arch/arm64/boot/dts/qcom/sc7180-idp.dts b/arch/arm64/boot/dts/qcom/sc7180-idp.dts > index 189254f..b6d4dc1 100644 > --- a/arch/arm64/boot/dts/qcom/sc7180-idp.dts > +++ b/arch/arm64/boot/dts/qcom/sc7180-idp.dts > @@ -7,6 +7,7 @@ > > /dts-v1/; > > +#include > #include > #include "sc7180.dtsi" > #include "pm6150.dtsi" > @@ -101,9 +102,9 @@ > }; > > vreg_l12a_1p8: ldo12 { > - regulator-min-microvolt = <1696000>; > - regulator-max-microvolt = <1952000>; > - regulator-initial-mode = ; > + regulator-min-microvolt = <1800000>; > + regulator-max-microvolt = <1800000>; > + regulator-initial-mode = ; > }; > > vreg_l13a_1p8: ldo13 { > @@ -143,9 +144,9 @@ > }; > > vreg_l19a_2p9: ldo19 { > - regulator-min-microvolt = <2696000>; > - regulator-max-microvolt = <3304000>; > - regulator-initial-mode = ; > + regulator-min-microvolt = <2960000>; > + regulator-max-microvolt = <2960000>; > + regulator-initial-mode = ; > }; > }; > > @@ -189,9 +190,9 @@ > }; > > vreg_l6c_2p9: ldo6 { > - regulator-min-microvolt = <2696000>; > - regulator-max-microvolt = <3304000>; > - regulator-initial-mode = ; > + regulator-min-microvolt = <1800000>; > + regulator-max-microvolt = <2950000>; > + regulator-initial-mode = ; > }; > > vreg_l7c_3p0: ldo7 { > @@ -207,9 +208,9 @@ > }; > > vreg_l9c_2p9: ldo9 { > - regulator-min-microvolt = <2952000>; > - regulator-max-microvolt = <3304000>; > - regulator-initial-mode = ; > + regulator-min-microvolt = <2960000>; > + regulator-max-microvolt = <2960000>; > + regulator-initial-mode = ; > }; > > vreg_l10c_3p3: ldo10 { > @@ -400,3 +401,25 @@ > bias-pull-up; > }; > }; > + > +&sdhc_1 { > + status = "ok"; another nit: the DT code is fine with both "okay" and "ok", however the rest of this file uses "okay", so let's be consistent and use the same string in all nodes. > + > + pinctrl-names = "default", "sleep"; > + pinctrl-0 = <&sdc1_on>; > + pinctrl-1 = <&sdc1_off>; > + vmmc-supply = <&vreg_l19a_2p9>; > + vqmmc-supply = <&vreg_l12a_1p8>; > +}; > + > +&sdhc_2 { > + status = "ok"; ditto