From: Dan Robertson <dan@dlrobertson.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Andy Shevchenko <andy.shevchenko@gmail.com>,
Jonathan Cameron <jic23@kernel.org>,
linux-iio <linux-iio@vger.kernel.org>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
devicetree <devicetree@vger.kernel.org>,
Hartmut Knaack <knaack.h@gmx.de>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Randy Dunlap <rdunlap@infradead.org>,
Joe Perches <joe@perches.com>
Subject: Re: [PATCH v7 3/3] iio: (bma400) basic regulator support
Date: Fri, 20 Dec 2019 15:23:10 +0000 [thread overview]
Message-ID: <20191220152310.GC16415@nessie> (raw)
In-Reply-To: <CACRpkdbTissSRyJ5uh8X6RFTM+VSSML-JmtOC_i8_UY0VTVRAA@mail.gmail.com>
On Thu, Dec 19, 2019 at 10:41:19PM +0100, Linus Walleij wrote:
> On Thu, Dec 19, 2019 at 12:06 PM Andy Shevchenko
> <andy.shevchenko@gmail.com> wrote:
> > On Thu, Dec 19, 2019 at 6:28 AM Dan Robertson <dan@dlrobertson.com> wrote:
> > >
> > > Add support for the VDD and VDDIO regulators using the regulator
> > > framework.
> > ...
> >
> > > + data->vdd_supply = devm_regulator_get(data->dev, "vdd");
> >
> > > + data->vddio_supply = devm_regulator_get(data->dev, "vddio");
> >
> > devm_regulator_bulk_get() ?
>
> I always thought to use regulator_bulk* maybe 3 regulators and
> definitely for more that 4 as it also clouds the view bit and is not
> as straightforward to read as the single functions, but I suppose
> it is a bit subjective :)
I tend to agree, but I think in this case it will at least simplify the
goto's.
Cheers,
- Dan
prev parent reply other threads:[~2019-12-20 15:39 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-19 4:10 [PATCH v7 0/3] iio: add driver for Bosch BMA400 accelerometer Dan Robertson
2019-12-19 4:10 ` [PATCH v7 1/3] dt-bindings: iio: accel: bma400: add bindings Dan Robertson
2019-12-19 8:32 ` Linus Walleij
2019-12-19 4:10 ` [PATCH v7 2/3] iio: (bma400) add driver for the BMA400 Dan Robertson
2019-12-19 4:15 ` Dan Robertson
2019-12-19 8:33 ` Linus Walleij
2019-12-19 11:02 ` Andy Shevchenko
2019-12-20 4:32 ` Dan Robertson
2019-12-20 9:27 ` Andy Shevchenko
2019-12-20 9:32 ` Andy Shevchenko
2019-12-20 15:28 ` Dan Robertson
2019-12-19 4:10 ` [PATCH v7 3/3] iio: (bma400) basic regulator support Dan Robertson
2019-12-19 8:35 ` Linus Walleij
2019-12-19 11:05 ` Andy Shevchenko
2019-12-19 21:41 ` Linus Walleij
2019-12-20 15:23 ` Dan Robertson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191220152310.GC16415@nessie \
--to=dan@dlrobertson.com \
--cc=andy.shevchenko@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=joe@perches.com \
--cc=knaack.h@gmx.de \
--cc=linus.walleij@linaro.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pmeerw@pmeerw.net \
--cc=rdunlap@infradead.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).