From: Shawn Guo <shawnguo@kernel.org>
To: Fabio Estevam <festevam@gmail.com>
Cc: robh+dt@kernel.org, kernel@pengutronix.de, linux-imx@nxp.com,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org
Subject: Re: [PATCH] ARM: dts: imx7: Unify temp-grade and speed-grade nodes
Date: Mon, 23 Dec 2019 14:27:45 +0800 [thread overview]
Message-ID: <20191223062744.GL11523@dragon> (raw)
In-Reply-To: <20191212133800.17929-1-festevam@gmail.com>
On Thu, Dec 12, 2019 at 10:38:00AM -0300, Fabio Estevam wrote:
> The following warning is seen when building with W=1:
>
> arch/arm/boot/dts/imx7s.dtsi:551.39-553.7: Warning (unique_unit_address): /soc/aips-bus@30000000/ocotp-ctrl@30350000/temp-grade@10: duplicate unit-address (also used in node /soc/aips-bus@30000000/ocotp-ctrl@30350000/speed-grade@10)
>
> Since temp-grade and speed-grade point to the same node, replace them by
> a single one to avoid the duplicate unit-address warning.
>
> Signed-off-by: Fabio Estevam <festevam@gmail.com>
> ---
> arch/arm/boot/dts/imx7d.dtsi | 2 +-
> arch/arm/boot/dts/imx7s.dtsi | 9 ++-------
> 2 files changed, 3 insertions(+), 8 deletions(-)
>
> diff --git a/arch/arm/boot/dts/imx7d.dtsi b/arch/arm/boot/dts/imx7d.dtsi
> index d8acd7cc7918..92f6d0c2a74f 100644
> --- a/arch/arm/boot/dts/imx7d.dtsi
> +++ b/arch/arm/boot/dts/imx7d.dtsi
> @@ -12,7 +12,7 @@
> clock-frequency = <996000000>;
> operating-points-v2 = <&cpu0_opp_table>;
> #cooling-cells = <2>;
> - nvmem-cells = <&cpu_speed_grade>;
> + nvmem-cells = <&fuse_grade>;
> nvmem-cell-names = "speed_grade";
> };
>
> diff --git a/arch/arm/boot/dts/imx7s.dtsi b/arch/arm/boot/dts/imx7s.dtsi
> index 1b812f4e7453..05d099da5a02 100644
> --- a/arch/arm/boot/dts/imx7s.dtsi
> +++ b/arch/arm/boot/dts/imx7s.dtsi
> @@ -152,8 +152,7 @@
> interrupt-parent = <&gpc>;
> interrupts = <GIC_SPI 49 IRQ_TYPE_LEVEL_HIGH>;
> fsl,tempmon = <&anatop>;
> - nvmem-cells = <&tempmon_calib>,
> - <&tempmon_temp_grade>;
> + nvmem-cells = <&tempmon_calib>, <&fuse_grade>;
> nvmem-cell-names = "calib", "temp_grade";
> clocks = <&clks IMX7D_PLL_SYS_MAIN_CLK>;
> };
> @@ -548,11 +547,7 @@
> reg = <0x3c 0x4>;
> };
>
> - tempmon_temp_grade: temp-grade@10 {
> - reg = <0x10 0x4>;
> - };
> -
> - cpu_speed_grade: speed-grade@10 {
> + fuse_grade: temp-grade@10 {
Rename the node to fuse-grade too?
Shawn
> reg = <0x10 0x4>;
> };
> };
> --
> 2.17.1
>
prev parent reply other threads:[~2019-12-23 6:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-12 13:38 [PATCH] ARM: dts: imx7: Unify temp-grade and speed-grade nodes Fabio Estevam
2019-12-23 6:27 ` Shawn Guo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191223062744.GL11523@dragon \
--to=shawnguo@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).