From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Rob Herring <robh@kernel.org>
Cc: David Dai <daidavid1@codeaurora.org>,
georgi.djakov@linaro.org, evgreen@google.com, sboyd@kernel.org,
ilina@codeaurora.org, seansw@qti.qualcomm.com, elder@linaro.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org
Subject: Re: [PATCH v1 3/4] interconnect: qcom: sdm845: Split qnodes into their respective NoCs
Date: Thu, 26 Dec 2019 11:00:58 -0800 [thread overview]
Message-ID: <20191226190058.GL549437@yoga> (raw)
In-Reply-To: <20191226184803.GA26712@bogus>
On Thu 26 Dec 10:48 PST 2019, Rob Herring wrote:
> On Sun, Dec 15, 2019 at 09:58:44PM -0800, David Dai wrote:
> > In order to better represent the hardware and its different Network-On-Chip
> > devices, split the sdm845 provider driver into NoC specific providers.
> > Remove duplicate functionality already provided by the icc rpmh and
> > bcm voter drivers to calculate and commit bandwidth requests to hardware.
>
> This breaks backwards compatibility. Is that okay for all 845 users?
>
Yes, based on our discussions surrounding adding support for the
pre-rpmh platforms, we concluded a while ago that we would like to
attempt to move to this structure instead of the originally agreed upon.
So we haven't merged any consumers using the current 845 binding in the
upstream Linux repository.
I'm not aware of any other public repositories that relies on the
existing binding.
Thanks,
Bjorn
> > Signed-off-by: David Dai <daidavid1@codeaurora.org>
> > ---
> > drivers/interconnect/qcom/sdm845.c | 1122 ++++++++++--------------
> > include/dt-bindings/interconnect/qcom,sdm845.h | 263 +++---
> > 2 files changed, 606 insertions(+), 779 deletions(-)
next prev parent reply other threads:[~2019-12-26 19:01 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-16 5:58 [PATCH v1 0/4] Split SDM845 interconnect nodes and consolidate RPMh support David Dai
2019-12-16 5:58 ` [PATCH v1 1/4] dt-bindings: interconnect: Update Qualcomm SDM845 DT bindings David Dai
2019-12-26 18:45 ` Rob Herring
2020-01-02 19:48 ` David Dai
2019-12-16 5:58 ` [PATCH v1 2/4] interconnect: qcom: Consolidate interconnect RPMh support David Dai
2019-12-19 12:53 ` Georgi Djakov
2019-12-20 0:00 ` daidavid1
2019-12-16 5:58 ` [PATCH v1 3/4] interconnect: qcom: sdm845: Split qnodes into their respective NoCs David Dai
2019-12-26 18:48 ` Rob Herring
2019-12-26 19:00 ` Bjorn Andersson [this message]
2019-12-16 5:58 ` [PATCH v1 4/4] arm64: dts: sdm845: Redefine interconnect provider DT nodes David Dai
2020-01-07 23:45 ` [PATCH v1 0/4] Split SDM845 interconnect nodes and consolidate RPMh support Evan Green
2020-01-14 23:36 ` David Dai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191226190058.GL549437@yoga \
--to=bjorn.andersson@linaro.org \
--cc=daidavid1@codeaurora.org \
--cc=devicetree@vger.kernel.org \
--cc=elder@linaro.org \
--cc=evgreen@google.com \
--cc=georgi.djakov@linaro.org \
--cc=ilina@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
--cc=seansw@qti.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).