From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 51D76C7EE2F for ; Fri, 2 Jun 2023 07:05:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234217AbjFBHFQ (ORCPT ); Fri, 2 Jun 2023 03:05:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55082 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234254AbjFBHEs (ORCPT ); Fri, 2 Jun 2023 03:04:48 -0400 Received: from mail-ej1-x62d.google.com (mail-ej1-x62d.google.com [IPv6:2a00:1450:4864:20::62d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 37A3010E7 for ; Fri, 2 Jun 2023 00:04:31 -0700 (PDT) Received: by mail-ej1-x62d.google.com with SMTP id a640c23a62f3a-9741caaf9d4so243256466b.0 for ; Fri, 02 Jun 2023 00:04:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1685689469; x=1688281469; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=UnQX0y9CucftjRft49d3HMPlBdEUnz94TDnE0qcYiJ8=; b=s6EvqgVxtO4TBZu0WwHgiMFZml20ChuVeE8PMA7UyEmuVlbEbmdnB/ols1Qg0V/bsm U7qvcR76k7KNGdEnpat3QPD9gQbN4ntl1E8F+4/F7otHawL/Qrw8dLep0BlYRpUowZv1 JwBEalTrdoq4fSOXIderQuHNI0NUOfNXT/SU6qhOIWKZ/wMif3iqYPVgIOh3FM5mf3UQ P6KXMb304exvpzMwUd9bXbpQC1dpYVxSW6ppRwmLX1JXk4Wl7NT3r6oY8VLftXaDOdrm /4TxZdlJ5IEUbLr8xquB1aOjKn9gACXDhvPl4/vmTomZMDEMf0EKYB8XZFxJjL69vwjI hQ6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685689469; x=1688281469; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=UnQX0y9CucftjRft49d3HMPlBdEUnz94TDnE0qcYiJ8=; b=cU378NfzDL5K8G+dbLv2zn/nIMp6DQAYkwbNSk0b8SIRblPKNmKJCxhVdWZXjP0H4B DanJfv5STjKN6LKgK7a0qwwiAX9qHeeJIbrxshnpaozez3cQHLH9pqYT///XjLzvbzzI xnqGIFN5TeNBJqgRzZl/xc1J/PKi/DRwbujJ+wD/3iOTIajaWG1pCYXZ96mPI2RLQBH0 IXaIm9YQxd8z9G9ORuq6rbcnQa9LP0axJOkBfD+ix74BkSz+wCQ69Y+4y26Nth7FnUp+ bkOyHwqFi9NsYbM3DfQTp4HCwlhU9bsYKjiwuqziljW/pvZOMwhpbMWZQML2eCEsESCJ BnKA== X-Gm-Message-State: AC+VfDxEawP0XH74T6J3E6B0DEBl6um8JeRfOK+3nARE3rlsVBQv0/Ls O93LHzYzBaiMcs27rVNi/vh9sg== X-Google-Smtp-Source: ACHHUZ5uGlEwXV94UmdP/Z9fWCmXFFhewyP4sS3Cx877kjsyOBbrr1YU/wJs7N49Oe5p5ZtfMuPs3g== X-Received: by 2002:a17:907:3e9d:b0:96f:f451:1874 with SMTP id hs29-20020a1709073e9d00b0096ff4511874mr11116346ejc.59.1685689469543; Fri, 02 Jun 2023 00:04:29 -0700 (PDT) Received: from [192.168.1.20] ([178.197.199.204]) by smtp.gmail.com with ESMTPSA id z13-20020a170906240d00b0094e597f0e4dsm386722eja.121.2023.06.02.00.04.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 02 Jun 2023 00:04:29 -0700 (PDT) Message-ID: <201cb02b-b7b0-eecc-a9d5-3a7535c91d8d@linaro.org> Date: Fri, 2 Jun 2023 09:04:27 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.2 Subject: Re: [PATCH RESEND 4/4] arm64: dts: qcom: ipq5332: add support for the RDP474 variant Content-Language: en-US To: Kathiravan T , Andy Gross , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20230601042054.29075-1-quic_kathirav@quicinc.com> <20230601042054.29075-5-quic_kathirav@quicinc.com> <91c63634-eb39-fdca-2c76-6f8182c2d47c@linaro.org> <2dd8e5be-c5b5-02e7-32d0-587a40cb70cc@quicinc.com> From: Krzysztof Kozlowski In-Reply-To: <2dd8e5be-c5b5-02e7-32d0-587a40cb70cc@quicinc.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 02/06/2023 06:05, Kathiravan T wrote: > > On 6/1/2023 10:59 PM, Krzysztof Kozlowski wrote: >> On 01/06/2023 06:20, Kathiravan T wrote: >>> Add the initial device tree support for the Reference Design >>> Platform(RDP) 474 based on IPQ5332 family of SoC. This patch carries >>> the support for Console UART, eMMC, I2C and GPIO based buttons. >>> >>> Signed-off-by: Kathiravan T >>> --- >>> arch/arm64/boot/dts/qcom/Makefile | 1 + >>> arch/arm64/boot/dts/qcom/ipq5332-rdp474.dts | 112 ++++++++++++++++++++ >>> 2 files changed, 113 insertions(+) >>> create mode 100644 arch/arm64/boot/dts/qcom/ipq5332-rdp474.dts >>> >>> diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile >>> index 4f9e81253e18..0f8c763a9bd9 100644 >>> --- a/arch/arm64/boot/dts/qcom/Makefile >>> +++ b/arch/arm64/boot/dts/qcom/Makefile >>> @@ -7,6 +7,7 @@ dtb-$(CONFIG_ARCH_QCOM) += apq8096-ifc6640.dtb >>> dtb-$(CONFIG_ARCH_QCOM) += ipq5332-mi01.2.dtb >>> dtb-$(CONFIG_ARCH_QCOM) += ipq5332-rdp442.dtb >>> dtb-$(CONFIG_ARCH_QCOM) += ipq5332-rdp468.dtb >>> +dtb-$(CONFIG_ARCH_QCOM) += ipq5332-rdp474.dtb >>> dtb-$(CONFIG_ARCH_QCOM) += ipq6018-cp01-c1.dtb >>> dtb-$(CONFIG_ARCH_QCOM) += ipq8074-hk01.dtb >>> dtb-$(CONFIG_ARCH_QCOM) += ipq8074-hk10-c1.dtb >>> diff --git a/arch/arm64/boot/dts/qcom/ipq5332-rdp474.dts b/arch/arm64/boot/dts/qcom/ipq5332-rdp474.dts >>> new file mode 100644 >>> index 000000000000..085729a0fdf1 >>> --- /dev/null >>> +++ b/arch/arm64/boot/dts/qcom/ipq5332-rdp474.dts >>> @@ -0,0 +1,112 @@ >>> +// SPDX-License-Identifier: BSD-3-Clause >>> +/* >>> + * IPQ5332 RDP474 board device tree source >>> + * >>> + * Copyright (c) 2022-2023 Qualcomm Innovation Center, Inc. All rights reserved. >>> + */ >>> + >>> +/dts-v1/; >>> + >>> +#include >>> +#include >>> +#include "ipq5332.dtsi" >>> + >>> +/ { >>> + model = "Qualcomm Technologies, Inc. IPQ5332 MI01.9"; >>> + compatible = "qcom,ipq5332-ap-mi01.9", "qcom,ipq5332"; >>> + >>> + aliases { >>> + serial0 = &blsp1_uart0; >>> + }; >>> + >>> + chosen { >>> + stdout-path = "serial0"; >>> + }; >>> + >>> + gpio_keys { >> No, srsly, so not only ignored the tags but also feedback? > > > Please correct me if I am wrong here.. > > This is RESEND of V1 patches (only minor correction in the subject line I sent you three emails and I assumed you got my feedback, thus it should not have been resend... > in cover letter). Also I don't see review comments as such in original > V1 as well > https://lore.kernel.org/linux-arm-msm/20230531135048.19164-1-quic_kathirav@quicinc.com/ > > Can you help to point out your review comments, I couldn't able to find out. ... but I don't see them on lore. So apparently you also did not get them. I apologize in such case. Mails are nicely sent in my outbox but apparently went to /dev/null. Original feedback: Same problems as with most of recent patches. No underscores in node names. Best regards, Krzysztof