From: Krzysztof Kozlowski <krzk@kernel.org>
To: Benjamin GAIGNARD <benjamin.gaignard@st.com>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"mark.rutland@arm.com" <mark.rutland@arm.com>
Cc: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"kgene@kernel.org" <kgene@kernel.org>,
"hminas@synopsys.com" <hminas@synopsys.com>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-samsung-soc@vger.kernel.org"
<linux-samsung-soc@vger.kernel.org>,
"m.szyprowski@samsung.com" <m.szyprowski@samsung.com>,
Amelie DELAUNAY <amelie.delaunay@st.com>
Subject: Re: [PATCH v2 2/2] ARM: dts: exynos: Remove unneeded "snps,dwc2" from hsotg node
Date: Fri, 3 Jan 2020 12:16:55 +0100 [thread overview]
Message-ID: <20200103111655.GA1605@pi3> (raw)
In-Reply-To: <bbc7e34c-75c2-dfe0-70f3-0685e8e54fed@st.com>
On Thu, Jan 02, 2020 at 08:50:39AM +0000, Benjamin GAIGNARD wrote:
>
> On 12/30/19 4:37 PM, Krzysztof Kozlowski wrote:
> > On Thu, Dec 19, 2019 at 11:35:36AM +0100, Benjamin Gaignard wrote:
> >> Remove "snps,dwc2" from hsotg@12480000 node compatible list because
> >> "samsung,s3c6400-hsotg" should be enough.
> > The more detailed compatible is almost always "enough". Some other nodes
> > also have detailed+generic compatible. In this case there is a driver
> > matching "snps,dwc2" so why removing it?
>
> First because, unlike the others dwc2 devices, this compatible wasn't
> describe in the bindings file
>
> so I had to investigated how it should work and, on samsung DT files,
> only "samsung,s3c6400-hsotg".
>
> From driver code point of view that seems coherent (we do the same for
> stm32).
>
> With that in mind I have decided to remove "snps,dwc2" from exynos DT
> file rather than add it everywhere else.
>
Actually fine with me, although I would be happy if Rob or Mark could
confirm that it is a preferred approach.
Rob, Mark, could you share your thoughts?
Best regards,
Krzysztof
next prev parent reply other threads:[~2020-01-03 11:17 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-19 10:35 [PATCH v2 0/2] Add yaml DWC2 bindings Benjamin Gaignard
2019-12-19 10:35 ` [PATCH v2 1/2] dt-bindings: usb: Convert DWC2 bindings to json-schema Benjamin Gaignard
2019-12-30 15:35 ` Krzysztof Kozlowski
2020-01-02 8:43 ` Benjamin GAIGNARD
2019-12-19 10:35 ` [PATCH v2 2/2] ARM: dts: exynos: Remove unneeded "snps,dwc2" from hsotg node Benjamin Gaignard
2019-12-30 15:37 ` Krzysztof Kozlowski
2020-01-02 8:50 ` Benjamin GAIGNARD
2020-01-03 11:16 ` Krzysztof Kozlowski [this message]
2019-12-19 12:54 ` [PATCH v2 0/2] Add yaml DWC2 bindings Minas Harutyunyan
2019-12-20 22:53 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200103111655.GA1605@pi3 \
--to=krzk@kernel.org \
--cc=amelie.delaunay@st.com \
--cc=benjamin.gaignard@st.com \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=hminas@synopsys.com \
--cc=kgene@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).