From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 52AC3C2D0C2 for ; Sat, 4 Jan 2020 17:27:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3280A2464E for ; Sat, 4 Jan 2020 17:27:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726118AbgADR1X (ORCPT ); Sat, 4 Jan 2020 12:27:23 -0500 Received: from asavdk3.altibox.net ([109.247.116.14]:50512 "EHLO asavdk3.altibox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726004AbgADR1X (ORCPT ); Sat, 4 Jan 2020 12:27:23 -0500 Received: from ravnborg.org (unknown [158.248.194.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by asavdk3.altibox.net (Postfix) with ESMTPS id 3BDD120030; Sat, 4 Jan 2020 18:27:19 +0100 (CET) Date: Sat, 4 Jan 2020 18:27:17 +0100 From: Sam Ravnborg To: Linus Walleij Cc: dri-devel@lists.freedesktop.org, Maarten Lankhorst , Maxime Ripard , Sean Paul , devicetree@vger.kernel.org, Stephan Gerhold , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 1/2] drm/panel: Add DT bindings for Novatek NT35510-based panels Message-ID: <20200104172717.GB8724@ravnborg.org> References: <20191225115610.14518-1-linus.walleij@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191225115610.14518-1-linus.walleij@linaro.org> User-Agent: Mutt/1.10.1 (2018-07-13) X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=eMA9ckh1 c=1 sm=1 tr=0 a=UWs3HLbX/2nnQ3s7vZ42gw==:117 a=UWs3HLbX/2nnQ3s7vZ42gw==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=kj9zAlcOel0A:10 a=j8Cu_9a8AAAA:8 a=VwQbUJbxAAAA:8 a=KKAkSRfTAAAA:8 a=gEfo2CItAAAA:8 a=e5mUnYsNAAAA:8 a=_oycOFcioCRde9wpaXwA:9 a=CjuIK1q_8ugA:10 a=A2jcf3dkIZPIRbEE90CI:22 a=AjGcO6oz07-iQ99wixmX:22 a=cvBusfyB2V15izCimMoJ:22 a=sptkURWiP4Gy88Gu7hUp:22 a=Vxmtnl_E_bksehYqCbjh:22 Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Linus. On Wed, Dec 25, 2019 at 12:56:09PM +0100, Linus Walleij wrote: > This adds device tree bindings for the Novatek NT35510-based > family of panels. Since several such panels are in existence > we define bindings common for all, and define the compatible > string for one certain panel (Hydis HVA40WV1). > > As other panels are discovered and investigated, we can add > more compatibles to the binding. > > Cc: Stephan Gerhold > Cc: devicetree@vger.kernel.org > Signed-off-by: Linus Walleij > --- > .../display/panel/novatek-nt35510.yaml | 53 +++++++++++++++++++ > 1 file changed, 53 insertions(+) > create mode 100644 Documentation/devicetree/bindings/display/panel/novatek-nt35510.yaml > > diff --git a/Documentation/devicetree/bindings/display/panel/novatek-nt35510.yaml b/Documentation/devicetree/bindings/display/panel/novatek-nt35510.yaml > new file mode 100644 > index 000000000000..a4a6b5adf15b > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/panel/novatek-nt35510.yaml > @@ -0,0 +1,53 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/display/panel/novatek-nt35510.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Novatek NT35510-based display panels > + > +maintainers: > + - Linus Walleij > + > +allOf: > + - $ref: panel-common.yaml# > + > +properties: > + compatible: > + const: hydis,hva40wv1 compatible fail to match filename - which is common practice. And hydis is not a known vendor-prefix. > + description: This indicates the panel manufacturer of the panel > + that is in turn using the NT35510 panel driver. The compatible > + string determines how the NT35510 panel driver shall be configured > + to work with the indicated panel. The description is just a general description of what compatible is used for. Please drop it as it does not provide anything specific for the panel. Sam > + reg: true > + reset-gpios: true > + vdd-supply: > + description: regulator that supplies the vdd voltage > + vddi-supply: > + description: regulator that supplies the vddi voltage > + backlight: true > + > +required: > + - compatible > + - reg > + > +additionalProperties: false > + > +examples: > + - | > + #include > + > + dsi@a0351000 { > + #address-cells = <1>; > + #size-cells = <0>; > + panel { > + compatible = "hydis,hva40wv1"; > + reg = <0>; > + vdd-supply = <&ab8500_ldo_aux4_reg>; > + vddi-supply = <&ab8500_ldo_aux6_reg>; > + reset-gpios = <&gpio4 11 GPIO_ACTIVE_LOW>; > + backlight = <&gpio_bl>; > + }; > + }; > + > +... > -- > 2.21.0 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel