From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Rob Herring <robh@kernel.org>
Cc: Mark Rutland <mark.rutland@arm.com>,
Ohad Ben-Cohen <ohad@wizery.com>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-remoteproc@vger.kernel.org,
Sibi Sankar <sibis@codeaurora.org>,
Rishabh Bhatnagar <rishabhb@codeaurora.org>
Subject: Re: [PATCH v2 1/8] dt-bindings: remoteproc: Add Qualcomm PIL info binding
Date: Sat, 4 Jan 2020 14:17:52 -0800 [thread overview]
Message-ID: <20200104221752.GW549437@yoga> (raw)
In-Reply-To: <20200104213804.GA30385@bogus>
On Sat 04 Jan 13:38 PST 2020, Rob Herring wrote:
> On Thu, Dec 26, 2019 at 09:32:08PM -0800, Bjorn Andersson wrote:
> > Add a devicetree binding for the Qualcomm periperal image loader
> > relocation info region found in the IMEM.
> >
> > Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> > ---
> >
> > Changes since v1:
> > - New patch
> >
> > .../bindings/remoteproc/qcom,pil-info.yaml | 35 +++++++++++++++++++
> > 1 file changed, 35 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/remoteproc/qcom,pil-info.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,pil-info.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,pil-info.yaml
> > new file mode 100644
> > index 000000000000..715945c683ed
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/remoteproc/qcom,pil-info.yaml
> > @@ -0,0 +1,35 @@
> > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: "http://devicetree.org/schemas/remoteproc/qcom,pil-info.yaml#"
> > +$schema: "http://devicetree.org/meta-schemas/core.yaml#"
> > +
> > +title: Qualcomm peripheral image loader relocation info binding
> > +
> > +description:
> > + This document defines the binding for describing the Qualcomm peripheral
> > + image loader relocation memory region, in IMEM, which is used for post mortem
> > + debugging of remoteprocs.
> > +
> > +maintainers:
> > + - Bjorn Andersson <bjorn.andersson@linaro.org>
> > +
> > +properties:
> > + compatible:
> > + const: qcom,pil-reloc-info
> > +
> > + offset:
> > + $ref: /schemas/types.yaml#/definitions/uint32
> > + description: Offset in the register map for the memory region
>
> Why not use 'reg' instead?
>
Because we have one prior example of subdevice of "imem", which is
compatible "syscon-reboot-mode" and that binding uses "offset".
That said, if you insist, reg (and ranges) would allow us to express the
size of the region...
Regards,
Bjorn
> > +
> > +examples:
> > + - |
> > + imem@146bf000 {
> > + compatible = "syscon", "simple-mfd";
> > + reg = <0 0x146bf000 0 0x1000>;
> > +
> > + pil-reloc {
> > + compatible ="qcom,pil-reloc-info";
> > + offset = <0x94c>;
> > + };
> > + };
> > --
> > 2.24.0
> >
next prev parent reply other threads:[~2020-01-04 22:17 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-27 5:32 [PATCH v2 0/8] remoteproc: qcom: post mortem debug support Bjorn Andersson
2019-12-27 5:32 ` [PATCH v2 1/8] dt-bindings: remoteproc: Add Qualcomm PIL info binding Bjorn Andersson
2020-01-04 21:38 ` Rob Herring
2020-01-04 22:17 ` Bjorn Andersson [this message]
2020-01-23 22:07 ` Rob Herring
2019-12-27 5:32 ` [PATCH v2 2/8] remoteproc: qcom: Introduce driver to store pil info in IMEM Bjorn Andersson
2020-01-10 21:18 ` Mathieu Poirier
2020-01-22 2:02 ` Bjorn Andersson
2020-01-22 19:04 ` Mathieu Poirier
2020-01-22 19:19 ` Bjorn Andersson
2020-01-22 22:56 ` rishabhb
2020-01-22 23:08 ` Bjorn Andersson
2020-01-22 23:58 ` rishabhb
2020-01-23 5:38 ` Bjorn Andersson
2019-12-27 5:32 ` [PATCH v2 3/8] remoteproc: qcom: Update IMEM PIL info on load Bjorn Andersson
2020-01-10 21:19 ` Mathieu Poirier
2019-12-27 5:32 ` [PATCH v2 4/8] arm64: dts: qcom: qcs404: Add IMEM and PIL info region Bjorn Andersson
2019-12-27 5:32 ` [PATCH v2 5/8] arm64: dts: qcom: sdm845: " Bjorn Andersson
2019-12-27 5:32 ` [PATCH v2 6/8] remoteproc: Introduce "panic" callback in ops Bjorn Andersson
2020-01-10 21:23 ` Mathieu Poirier
2020-01-30 10:07 ` Arnaud POULIQUEN
2019-12-27 5:32 ` [PATCH v2 7/8] remoteproc: qcom: q6v5: Add common panic handler Bjorn Andersson
2020-01-10 21:28 ` Mathieu Poirier
2020-01-22 19:39 ` Bjorn Andersson
2020-01-23 17:01 ` Mathieu Poirier
2020-01-23 17:15 ` Bjorn Andersson
2020-01-23 17:49 ` Arnaud POULIQUEN
2020-01-24 18:44 ` Mathieu Poirier
2020-01-27 9:46 ` Arnaud POULIQUEN
2020-01-29 20:15 ` Mathieu Poirier
2020-01-30 10:00 ` Arnaud POULIQUEN
2019-12-27 5:32 ` [PATCH v2 8/8] remoteproc: qcom: Introduce panic handler for PAS and ADSP Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200104221752.GW549437@yoga \
--to=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=ohad@wizery.com \
--cc=rishabhb@codeaurora.org \
--cc=robh@kernel.org \
--cc=sibis@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox