* [PATCH 1/3] arm64: dts: qcom: sm8150-mtp: Add UFS gpio reset
2020-01-06 7:08 [PATCH 0/3] arm64: dts: qcom: UFS updates Vinod Koul
@ 2020-01-06 7:08 ` Vinod Koul
2020-01-06 7:08 ` [PATCH 2/3] arm64: dts: qcom: sm8150: Fix UFS phy register size Vinod Koul
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Vinod Koul @ 2020-01-06 7:08 UTC (permalink / raw)
To: Bjorn Andersson
Cc: linux-arm-msm, Vinod Koul, Andy Gross, Rob Herring, Mark Rutland,
devicetree, linux-kernel, Can Guo
Add the reset-gpio for UFS for sm8150-mtp.
Signed-off-by: Vinod Koul <vkoul@kernel.org>
---
arch/arm64/boot/dts/qcom/sm8150-mtp.dts | 3 +++
1 file changed, 3 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/sm8150-mtp.dts b/arch/arm64/boot/dts/qcom/sm8150-mtp.dts
index 1eb93a768a85..9cab51759d2f 100644
--- a/arch/arm64/boot/dts/qcom/sm8150-mtp.dts
+++ b/arch/arm64/boot/dts/qcom/sm8150-mtp.dts
@@ -7,6 +7,7 @@
/dts-v1/;
#include <dt-bindings/regulator/qcom,rpmh-regulator.h>
+#include <dt-bindings/gpio/gpio.h>
#include "sm8150.dtsi"
#include "pm8150.dtsi"
#include "pm8150b.dtsi"
@@ -389,6 +390,8 @@ &uart2 {
&ufs_mem_hc {
status = "okay";
+ reset-gpios = <&tlmm 175 GPIO_ACTIVE_LOW>;
+
vcc-supply = <&vreg_l10a_2p5>;
vcc-max-microamp = <750000>;
vccq-supply = <&vreg_l9a_1p2>;
--
2.24.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* [PATCH 2/3] arm64: dts: qcom: sm8150: Fix UFS phy register size
2020-01-06 7:08 [PATCH 0/3] arm64: dts: qcom: UFS updates Vinod Koul
2020-01-06 7:08 ` [PATCH 1/3] arm64: dts: qcom: sm8150-mtp: Add UFS gpio reset Vinod Koul
@ 2020-01-06 7:08 ` Vinod Koul
2020-01-06 7:08 ` [PATCH 3/3] arm64: dts: qcom: sdm845: add the ufs reset Vinod Koul
2020-01-06 7:35 ` [PATCH 0/3] arm64: dts: qcom: UFS updates Bjorn Andersson
3 siblings, 0 replies; 5+ messages in thread
From: Vinod Koul @ 2020-01-06 7:08 UTC (permalink / raw)
To: Bjorn Andersson
Cc: linux-arm-msm, Vinod Koul, Andy Gross, Rob Herring, Mark Rutland,
devicetree, linux-kernel, Can Guo
UFS phy register space size is 0x1c0. so update it
Reported-by: Can Guo <cang@codeaurora.org>
Signed-off-by: Vinod Koul <vkoul@kernel.org>
---
arch/arm64/boot/dts/qcom/sm8150.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/qcom/sm8150.dtsi b/arch/arm64/boot/dts/qcom/sm8150.dtsi
index f36d621a53e2..f92b92866ae0 100644
--- a/arch/arm64/boot/dts/qcom/sm8150.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm8150.dtsi
@@ -553,7 +553,7 @@ ufs_mem_hc: ufshc@1d84000 {
ufs_mem_phy: phy@1d87000 {
compatible = "qcom,sm8150-qmp-ufs-phy";
- reg = <0 0x01d87000 0 0x18c>;
+ reg = <0 0x01d87000 0 0x1c0>;
#address-cells = <2>;
#size-cells = <2>;
ranges;
--
2.24.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* [PATCH 3/3] arm64: dts: qcom: sdm845: add the ufs reset
2020-01-06 7:08 [PATCH 0/3] arm64: dts: qcom: UFS updates Vinod Koul
2020-01-06 7:08 ` [PATCH 1/3] arm64: dts: qcom: sm8150-mtp: Add UFS gpio reset Vinod Koul
2020-01-06 7:08 ` [PATCH 2/3] arm64: dts: qcom: sm8150: Fix UFS phy register size Vinod Koul
@ 2020-01-06 7:08 ` Vinod Koul
2020-01-06 7:35 ` [PATCH 0/3] arm64: dts: qcom: UFS updates Bjorn Andersson
3 siblings, 0 replies; 5+ messages in thread
From: Vinod Koul @ 2020-01-06 7:08 UTC (permalink / raw)
To: Bjorn Andersson
Cc: linux-arm-msm, Vinod Koul, Andy Gross, Rob Herring, Mark Rutland,
devicetree, linux-kernel, Can Guo
Add the core UFS reset for sdm845
Signed-off-by: Vinod Koul <vkoul@kernel.org>
---
arch/arm64/boot/dts/qcom/sdm845.dtsi | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi
index ddb1f23c936f..0c233afd7a5e 100644
--- a/arch/arm64/boot/dts/qcom/sdm845.dtsi
+++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi
@@ -1374,6 +1374,8 @@ ufs_mem_hc: ufshc@1d84000 {
lanes-per-direction = <2>;
power-domains = <&gcc UFS_PHY_GDSC>;
#reset-cells = <1>;
+ resets = <&gcc GCC_UFS_PHY_BCR>;
+ reset-names = "rst";
iommus = <&apps_smmu 0x100 0xf>;
--
2.24.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH 0/3] arm64: dts: qcom: UFS updates
2020-01-06 7:08 [PATCH 0/3] arm64: dts: qcom: UFS updates Vinod Koul
` (2 preceding siblings ...)
2020-01-06 7:08 ` [PATCH 3/3] arm64: dts: qcom: sdm845: add the ufs reset Vinod Koul
@ 2020-01-06 7:35 ` Bjorn Andersson
3 siblings, 0 replies; 5+ messages in thread
From: Bjorn Andersson @ 2020-01-06 7:35 UTC (permalink / raw)
To: Vinod Koul
Cc: linux-arm-msm, Andy Gross, Rob Herring, Mark Rutland, devicetree,
linux-kernel, Can Guo
On Sun 05 Jan 23:08 PST 2020, Vinod Koul wrote:
> We recently saw regression on UFS on SM8150 and few other boards and that
> was resolved by adding timeout and fixing the UFS phy reset sequence. That
> patches are in linux-next now.
>
> During this we found sm8150 lacks gpio reset for ufs, so add that and fix
> the ufs phy register size.
> Also add the sdm845 ufs reset.
>
Thanks Vinod, boot tested and merged.
> Vinod Koul (3):
> arm64: dts: qcom: sm8150-mtp: Add UFS gpio reset
> arm64: dts: qcom: sm8150: Fix UFS phy register size
> arm64: dts: qcom: sdm845: add the ufs reset
>
> arch/arm64/boot/dts/qcom/sdm845.dtsi | 2 ++
> arch/arm64/boot/dts/qcom/sm8150-mtp.dts | 3 +++
> arch/arm64/boot/dts/qcom/sm8150.dtsi | 2 +-
> 3 files changed, 6 insertions(+), 1 deletion(-)
>
> --
> 2.24.1
>
^ permalink raw reply [flat|nested] 5+ messages in thread