Re: [PATCH v6 0/4] drm: Add support for bus-format negotiation

[Boris Brezillon <boris.brezillon@collabora.com>]

On Mon,  6 Jan 2020 15:34:05 +0100
Neil Armstrong <narmstrong@baylibre.com> wrote:

> This patch series aims at adding support for runtime bus-format
> negotiation between all elements of the
> 'encoder -> bridges -> connector/display' section of the pipeline.
> 
> In order to support that, we need drm bridges to fully take part in the
> atomic state validation process, which requires adding a
> drm_bridge_state and a new drm_bridge_funcs.atomic_check() hook.
> Once those basic building blocks are in place, we can add new hooks to
> allow bus format negotiation (those are called just before
> ->atomic_check()). The bus format selection is done at runtime by  
> testing all possible combinations across the whole bridge chain until
> one is reported to work.
> 
> No Major changes in this v6, I addressed the slight changed requested
> by Boris from Laurent on the patch 1, and rebased on drm-misc-next. 
> Note that this version only contains core changes.
> Once those changes are merged I'll send the imx/panel/lvds-codec specific bits.
> 
> A more detailed changelog is provided in each patch.
> 
> This patch series is also available here [1].
> 
> Thanks,
> 
> ~Boris~ Neil
> 
> [1] https://github.com/superna9999/linux/commits/drm-bridge-busfmt-v6
> 
> Boris Brezillon (4):
>   drm/bridge: Add a drm_bridge_state object
>   drm/bridge: Patch atomic hooks to take a drm_bridge_state
>   drm/bridge: Add an ->atomic_check() hook
>   drm/bridge: Add the necessary bits to support bus format negotiation

This version looks good to me.

Acked-by: Boris Brezillon <boris.brezillon@collabora.com>

> 
>  .../drm/bridge/analogix/analogix_dp_core.c    |  41 +-
>  drivers/gpu/drm/drm_atomic.c                  |  39 ++
>  drivers/gpu/drm/drm_atomic_helper.c           |  32 +-
>  drivers/gpu/drm/drm_bridge.c                  | 527 +++++++++++++++++-
>  drivers/gpu/drm/rcar-du/rcar_lvds.c           |   5 +-
>  include/drm/drm_atomic.h                      |   3 +
>  include/drm/drm_bridge.h                      | 275 ++++++++-
>  7 files changed, 874 insertions(+), 48 deletions(-)
>