From: Thierry Reding <thierry.reding@gmail.com>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: Rob Herring <robh@kernel.org>, Maxime Ripard <mripard@kernel.org>,
Yannick Fertre <yannick.fertre@st.com>,
Mark Rutland <mark.rutland@arm.com>,
Daniel Vetter <daniel@ffwll.ch>,
dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v2 0/2] combine bindings for simple panels in a few files
Date: Tue, 7 Jan 2020 13:15:06 +0100 [thread overview]
Message-ID: <20200107121506.GC1964183@ulmo> (raw)
In-Reply-To: <20200102101712.5085-1-sam@ravnborg.org>
[-- Attachment #1: Type: text/plain, Size: 1529 bytes --]
On Thu, Jan 02, 2020 at 11:17:10AM +0100, Sam Ravnborg wrote:
> This patchset introduces two files:
>
> panel-simple.yaml
> panel-simple-dsi.yaml
>
> The two files will be used for bindings for simple
> panels that have only a single power-supply.
>
> For now only a few bindings are migrated - the
> reamining bindings will be migrated when we have agreed
> on the format.
>
> v2:
> - updated binding description in panel-simple.yaml
> - fixed exampe in panel-simple.yaml
> (I was missing libyaml-dev - now the examples are checked properly here)
> - added panel-simple-dsi.yaml
>
> Sam
>
> Sam Ravnborg (2):
> dt-bindings: one binding file for all simple panels
> dt-bindings: one file of all simple DSI panels
>
> .../display/panel/ampire,am-480272h3tmqw-t01h.yaml | 42 --------------
> .../display/panel/ampire,am800480r3tmqwa1h.txt | 7 ---
> .../display/panel/panasonic,vvx10f034n00.txt | 20 -------
> .../bindings/display/panel/panel-simple-dsi.yaml | 67 ++++++++++++++++++++++
> .../bindings/display/panel/panel-simple.yaml | 59 +++++++++++++++++++
> 5 files changed, 126 insertions(+), 69 deletions(-)
I like this. With the improved structure that the YAML bindings provide
this becomes rather neat. You may want to update the subject of the
patches to better reflect the style (most seem to use "dt-bindings:
display: " as prefix, for example). But overall, looks good:
Acked-by: Thierry Reding <treding@nvidia.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2020-01-07 12:15 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-02 10:17 [PATCH v2 0/2] combine bindings for simple panels in a few files Sam Ravnborg
2020-01-02 10:17 ` [PATCH v2 1/2] dt-bindings: one binding file for all simple panels Sam Ravnborg
2020-01-07 15:41 ` Benjamin Gaignard
2020-01-08 20:54 ` Sam Ravnborg
2020-01-07 19:52 ` Rob Herring
2020-01-08 21:12 ` Sam Ravnborg
2020-01-02 10:17 ` [PATCH v2 2/2] dt-bindings: one file of all simple DSI panels Sam Ravnborg
2020-01-07 15:44 ` Benjamin Gaignard
2020-01-07 17:04 ` Rob Herring
2020-01-08 9:41 ` Benjamin Gaignard
2020-01-28 8:50 ` Benjamin Gaignard
2020-01-29 19:47 ` Sam Ravnborg
2020-01-30 8:45 ` Benjamin Gaignard
2020-01-07 19:51 ` Rob Herring
2020-01-07 12:15 ` Thierry Reding [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200107121506.GC1964183@ulmo \
--to=thierry.reding@gmail.com \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=mark.rutland@arm.com \
--cc=mripard@kernel.org \
--cc=robh@kernel.org \
--cc=sam@ravnborg.org \
--cc=yannick.fertre@st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).