From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3CCE1C33C9E for ; Fri, 17 Jan 2020 18:57:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 15A8B2082F for ; Fri, 17 Jan 2020 18:57:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alien8.de header.i=@alien8.de header.b="lrxsDNeS" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729547AbgAQS5j (ORCPT ); Fri, 17 Jan 2020 13:57:39 -0500 Received: from mail.skyhub.de ([5.9.137.197]:46150 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726761AbgAQS5i (ORCPT ); Fri, 17 Jan 2020 13:57:38 -0500 Received: from zn.tnic (p200300EC2F08DC00F542D1B17E7E874A.dip0.t-ipconnect.de [IPv6:2003:ec:2f08:dc00:f542:d1b1:7e7e:874a]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 6C3C51EC03F6; Fri, 17 Jan 2020 19:57:36 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1579287456; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=POACTC6mnXGZzWfF2psU4bC7N5ybL/xYN8K9pQsvVts=; b=lrxsDNeSB5hwOaA/GXovvrEqZLuVO5W8q7BY0QoRbSkqI2RGheQfmBDQNi3UOIogUbpyeM T7keG914fxIfQL+BXDEuL67l42JbLj2ap3zDL6j9RsG11MjWArU7OV6BrUdzpGRA8LRsuD A0xX62R8W6mQ31PFYXaaLyXx+A+0V90= Date: Fri, 17 Jan 2020 19:57:28 +0100 From: Borislav Petkov To: Shiping Ji Cc: James Morse , robh+dt@kernel.org, mark.rutland@arm.com, devicetree@vger.kernel.org, LKML , linux-edac@vger.kernel.org, Mauro Carvalho Chehab , sashal@kernel.org, hangl@microsoft.com, Lei Wang , shji@microsoft.com, ruizhao@microsoft.com, Scott Branden , Yuqing Shen , ray.jui@broadcom.com, wangglei@gmail.com Subject: Re: [PATCH v9 2/2] EDAC: add EDAC driver for DMC520 Message-ID: <20200117185728.GC31472@zn.tnic> References: <6a462190-0af2-094a-daa8-f480d54a1fbf@gmail.com> <20200117001843.GJ27148@zn.tnic> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Fri, Jan 17, 2020 at 10:31:18AM -0800, Shiping Ji wrote: > This is to protect concurrent writes to the mci->error_desc as > suggested by James when reviewing the patch v3. Please comment that in the structure definition so that it is clear what it is for. > I'm trying to find a good scheme to make them shorter, at the moment > they are named according to the TRM. Yeah, keeping it the same as the documentation is also a good idea. I leave it up to you to decide as you'll be staring at that code when bugs happen. :) > I'm not sure how this can be done perfectly with tabs only :) Who says you should use only tabs? :-) > All other comments have been addressed in the next patch, many thanks! Thanks too. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette