From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C7B71C2D0CE for ; Tue, 21 Jan 2020 20:05:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 94BB9217F4 for ; Tue, 21 Jan 2020 20:05:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728596AbgAUUFO (ORCPT ); Tue, 21 Jan 2020 15:05:14 -0500 Received: from asavdk3.altibox.net ([109.247.116.14]:44486 "EHLO asavdk3.altibox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727523AbgAUUFO (ORCPT ); Tue, 21 Jan 2020 15:05:14 -0500 Received: from ravnborg.org (unknown [158.248.194.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by asavdk3.altibox.net (Postfix) with ESMTPS id B32EA20023; Tue, 21 Jan 2020 21:05:09 +0100 (CET) Date: Tue, 21 Jan 2020 21:05:08 +0100 From: Sam Ravnborg To: Oleksandr Suvorov Cc: Rob Herring , "dri-devel@lists.freedesktop.org" , "devicetree@vger.kernel.org" , Thierry Reding , Laurent Pinchart Subject: Re: [PATCH v1 1/3] dt-bindings: display: add panel-timing.yaml Message-ID: <20200121200508.GA12997@ravnborg.org> References: <20200120200641.15047-1-sam@ravnborg.org> <20200120200641.15047-2-sam@ravnborg.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=eMA9ckh1 c=1 sm=1 tr=0 a=UWs3HLbX/2nnQ3s7vZ42gw==:117 a=UWs3HLbX/2nnQ3s7vZ42gw==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=kj9zAlcOel0A:10 a=m8ToADvmAAAA:8 a=mQmKYES7xw7GLjSqz8EA:9 a=CjuIK1q_8ugA:10 a=kCrBFHLFDAq2jDEeoMj9:22 Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Oleksandr. > > There some typos: > > > diff --git a/Documentation/devicetree/bindings/display/panel/panel-timing.yaml b/Documentation/devicetree/bindings/display/panel/panel-timing.yaml > > new file mode 100644 > > index 000000000000..59891c7a58ee > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/display/panel/panel-timing.yaml > > @@ -0,0 +1,253 @@ > ... > > +description: | > > + There are different ways of describing the timing data data of a panel. The > -----------------------------------------------------------------------^^^^^^^^^ > s/data data/data/ > > ... > > + vactive: > > + $ref: /schemas/types.yaml#/definitions/uint32 > > + description: | > > + Verical panel resolution in pixels > ---------^^^^^^ > Vertical Fixed in v2 - thanks. > > Anyway, those are minor issues, so > > Reviewed-by: Oleksandr Suvorov Sam