[PATCH v1] dt-bindings: phy: Fix for intel,lgm-emmc-phy.yaml build error

[PATCH v1] dt-bindings: phy: Fix for intel,lgm-emmc-phy.yaml build error

[Ramuthevar,Vadivel MuruganX]

From: Ramuthevar Vadivel Murugan <vadivel.muruganx.ramuthevar@linux.intel.com>

This patch fixes the devicetree binding yaml build errors
in linux-next kernel Error: Documentation/devicetree/bindings/
phy/intel,lgm-emmc-phy.example.dts:21.19-20
syntax error FATAL ERROR: Unable to parse input tree

Signed-off-by: Ramuthevar Vadivel Murugan <vadivel.muruganx.ramuthevar@linux.intel.com>
Reported-by: Rob Herring <robh@kernel.org>
---
 .../devicetree/bindings/phy/intel,lgm-emmc-phy.yaml       | 15 ++++++++++-----
 1 file changed, 10 insertions(+), 5 deletions(-)

diff --git a/Documentation/devicetree/bindings/phy/intel,lgm-emmc-phy.yaml b/Documentation/devicetree/bindings/phy/intel,lgm-emmc-phy.yaml
index ff7959c21af0..d9bd2e47dfe7 100644
--- a/Documentation/devicetree/bindings/phy/intel,lgm-emmc-phy.yaml
+++ b/Documentation/devicetree/bindings/phy/intel,lgm-emmc-phy.yaml
@@ -16,10 +16,7 @@ description: |+
   The eMMC PHY node should be the child of a syscon node with the
   required property:
 
-  - compatible:         Should be one of the following:
-                        "intel,lgm-syscon", "syscon"
-  - reg:
-      maxItems: 1
+  should be compatible strings are - "intel,lgm-syscon", "syscon"
 
 properties:
   compatible:
@@ -34,6 +31,12 @@ properties:
   clocks:
     maxItems: 1
 
+  "#address-cells":
+    const: 1
+
+  "#size-cells":
+    const: 1
+
 required:
   - "#phy-cells"
   - compatible
@@ -45,8 +48,10 @@ examples:
     sysconf: chiptop@e0200000 {
       compatible = "intel,lgm-syscon", "syscon";
       reg = <0xe0200000 0x100>;
+      #address-cells = <1>;
+      #size-cells = <1>;
 
-      emmc-phy: emmc-phy@a8 {
+      emmc_phy: emmc_phy@a8 {
         compatible = "intel,lgm-emmc-phy";
         reg = <0x00a8 0x10>;
         clocks = <&emmc>;
-- 
2.11.0

Re: [PATCH v1] dt-bindings: phy: Fix for intel,lgm-emmc-phy.yaml build error

[Rob Herring]

On Tue, Jan 14, 2020 at 06:47:10PM +0800, Ramuthevar,Vadivel MuruganX wrote:
> From: Ramuthevar Vadivel Murugan <vadivel.muruganx.ramuthevar@linux.intel.com>
> 
> This patch fixes the devicetree binding yaml build errors
> in linux-next kernel Error: Documentation/devicetree/bindings/
> phy/intel,lgm-emmc-phy.example.dts:21.19-20
> syntax error FATAL ERROR: Unable to parse input tree
> 
> Signed-off-by: Ramuthevar Vadivel Murugan <vadivel.muruganx.ramuthevar@linux.intel.com>
> Reported-by: Rob Herring <robh@kernel.org>
> ---
>  .../devicetree/bindings/phy/intel,lgm-emmc-phy.yaml       | 15 ++++++++++-----
>  1 file changed, 10 insertions(+), 5 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/phy/intel,lgm-emmc-phy.yaml b/Documentation/devicetree/bindings/phy/intel,lgm-emmc-phy.yaml
> index ff7959c21af0..d9bd2e47dfe7 100644
> --- a/Documentation/devicetree/bindings/phy/intel,lgm-emmc-phy.yaml
> +++ b/Documentation/devicetree/bindings/phy/intel,lgm-emmc-phy.yaml
> @@ -16,10 +16,7 @@ description: |+
>    The eMMC PHY node should be the child of a syscon node with the
>    required property:
>  
> -  - compatible:         Should be one of the following:
> -                        "intel,lgm-syscon", "syscon"
> -  - reg:
> -      maxItems: 1
> +  should be compatible strings are - "intel,lgm-syscon", "syscon"

What's this change for?

>  
>  properties:
>    compatible:
> @@ -34,6 +31,12 @@ properties:
>    clocks:
>      maxItems: 1
>  
> +  "#address-cells":
> +    const: 1
> +
> +  "#size-cells":
> +    const: 1
> +

This schema is properties in the emmc-phy node, so these don't belong 
here. But the example change is correct.

>  required:
>    - "#phy-cells"
>    - compatible
> @@ -45,8 +48,10 @@ examples:
>      sysconf: chiptop@e0200000 {
>        compatible = "intel,lgm-syscon", "syscon";
>        reg = <0xe0200000 0x100>;
> +      #address-cells = <1>;
> +      #size-cells = <1>;
>  
> -      emmc-phy: emmc-phy@a8 {
> +      emmc_phy: emmc_phy@a8 {

Don't use '_' in node names. The error was in the label.

emmc_phy: emmc-phy@a8 {

>          compatible = "intel,lgm-emmc-phy";
>          reg = <0x00a8 0x10>;
>          clocks = <&emmc>;
> -- 
> 2.11.0
> 

Re: Fwd: Re: [PATCH v1] dt-bindings: phy: Fix for intel,lgm-emmc-phy.yaml build error

[Ramuthevar, Vadivel MuruganX]

Hi,
> On Tue, Jan 14, 2020 at 06:47:10PM +0800, Ramuthevar,Vadivel MuruganX 
> wrote:
>> From: Ramuthevar Vadivel Murugan 
>> <vadivel.muruganx.ramuthevar@linux.intel.com>
>>
>> This patch fixes the devicetree binding yaml build errors
>> in linux-next kernel Error: Documentation/devicetree/bindings/
>> phy/intel,lgm-emmc-phy.example.dts:21.19-20
>> syntax error FATAL ERROR: Unable to parse input tree
>>
>> Signed-off-by: Ramuthevar Vadivel Murugan 
>> <vadivel.muruganx.ramuthevar@linux.intel.com>
>> Reported-by: Rob Herring <robh@kernel.org>
>> ---
>> .../devicetree/bindings/phy/intel,lgm-emmc-phy.yaml | 15 ++++++++++-----
>> 1 file changed, 10 insertions(+), 5 deletions(-)
>>
>> diff --git 
>> a/Documentation/devicetree/bindings/phy/intel,lgm-emmc-phy.yaml 
>> b/Documentation/devicetree/bindings/phy/intel,lgm-emmc-phy.yaml
>> index ff7959c21af0..d9bd2e47dfe7 100644
>> --- a/Documentation/devicetree/bindings/phy/intel,lgm-emmc-phy.yaml
>> +++ b/Documentation/devicetree/bindings/phy/intel,lgm-emmc-phy.yaml
>> @@ -16,10 +16,7 @@ description: |+
>> The eMMC PHY node should be the child of a syscon node with the
>> required property:
>> - - compatible: Should be one of the following:
>> - "intel,lgm-syscon", "syscon"
>> - - reg:
>> - maxItems: 1
>> + should be compatible strings are - "intel,lgm-syscon", "syscon"
>
> What's this change for?
>
just re-sentenced like the other patches instead of -compatible in the 
description
>> properties:
>> compatible:
>> @@ -34,6 +31,12 @@ properties:
>> clocks:
>> maxItems: 1
>> + "#address-cells":
>> + const: 1
>> +
>> + "#size-cells":
>> + const: 1
>> +
>
> This schema is properties in the emmc-phy node, so these don't belong 
> here. But the example change is correct.
>
noted will fix it.
>> required:
>> - "#phy-cells"
>> - compatible
>> @@ -45,8 +48,10 @@ examples:
>> sysconf: chiptop@e0200000 {
>> compatible = "intel,lgm-syscon", "syscon";
>> reg = <0xe0200000 0x100>;
>> + #address-cells = <1>;
>> + #size-cells = <1>;
>> - emmc-phy: emmc-phy@a8 {
>> + emmc_phy: emmc_phy@a8 {
>
> Don't use '_' in node names. The error was in the label.
>
> emmc_phy: emmc-phy@a8 {
>
Noted ,will fix it.

Thanks a lot!

Regards
Vadivel
>> compatible = "intel,lgm-emmc-phy";
>> reg = <0x00a8 0x10>;
>> clocks = <&emmc>;
>> -- 2.11.0
>>