From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 89AC0C2D0CE for ; Wed, 22 Jan 2020 02:05:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 53E64217F4 for ; Wed, 22 Jan 2020 02:05:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579658726; bh=yVncP2cRerLjCSUEq2+nxA2AX8UnlN8vHXhFAI+A+pQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=OUKmj6kodUGgGPC9Hr6jsiHxxzD9MkEvoA+wZWgPgCpMzMa7gc5LmzZi4sNRhYasG 7qekqFC9rtpn0eQYymFKVtZTnuuyhCekxCO+11Xos8uU2JhMw2UKv5BFvALGtvZRGT 6tzYjQ2hH+gYeG6IIhMJZU5okbl9Cr2yLPv68ayo= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728855AbgAVCFZ (ORCPT ); Tue, 21 Jan 2020 21:05:25 -0500 Received: from mail-ot1-f67.google.com ([209.85.210.67]:43622 "EHLO mail-ot1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726396AbgAVCFZ (ORCPT ); Tue, 21 Jan 2020 21:05:25 -0500 Received: by mail-ot1-f67.google.com with SMTP id p8so4871052oth.10; Tue, 21 Jan 2020 18:05:25 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=5KDHhB97+OZpmUZ0CpohOMTK6dCD2tSEOncivv/7Pgw=; b=rMZ8ifBZCC7FE/9t0VWrOMqucWkutK3wl805i/MprW6qPf4rbmxMOzrTlYh1N6nQsC /XH7qX3AEszhYJT5V6clhq9QxXlO9JknVYBMVeTdHOojnUmz+4NGW4/dDRqqqd54qujU MdXT6tLZ9lwDgW0XLMGWj7Bw6chXKqcY7I5vlgBKCjnmFyN9P8fKTEOZhTXsu63RJw6t UdBNXCpdMH6FMa2LeS1oVX+AQC69egaCo0wZk7lCkVkoqILKqcAOTz4EyDiITPdpr6Sm 3xDqiHbHrFJVsEJwVFGJs70N+lOv8VBDYUUeZy6VnAFemHaamJr5DwGBrkDSbNvlpN/t oOuA== X-Gm-Message-State: APjAAAWjHEMOkwFhC5UJWGAlf7Usu5oVaIpso3PZaMChQnm+8s8Lp1te agd6CI2vOccDVkhmoUk0Bw== X-Google-Smtp-Source: APXvYqzkfbpLEJGKkcLHIHyxBnU94Fou1ccxpuM+pfV/pzRrIsQMB2bPSHSJROq5isXH9ct8XAs62w== X-Received: by 2002:a9d:7a97:: with SMTP id l23mr6087185otn.34.1579658724729; Tue, 21 Jan 2020 18:05:24 -0800 (PST) Received: from rob-hp-laptop (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.gmail.com with ESMTPSA id n22sm14452502otj.36.2020.01.21.18.05.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Jan 2020 18:05:23 -0800 (PST) Received: (nullmailer pid 29799 invoked by uid 1000); Wed, 22 Jan 2020 02:05:23 -0000 Date: Tue, 21 Jan 2020 20:05:23 -0600 From: Rob Herring To: Alexandru Ardelean Cc: netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, davem@davemloft.net, andrew@lunn.ch, f.fainelli@gmail.com, hkallweit1@gmail.com Subject: Re: [PATCH 4/4] dt-bindings: net: adin: document 1588 TX/RX SOP bindings Message-ID: <20200122020523.GA22232@bogus> References: <20200116091454.16032-1-alexandru.ardelean@analog.com> <20200116091454.16032-5-alexandru.ardelean@analog.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200116091454.16032-5-alexandru.ardelean@analog.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Thu, Jan 16, 2020 at 11:14:54AM +0200, Alexandru Ardelean wrote: > This change documents the device-tree bindings for the TX/RX indication of > IEEE 1588 packets. > > Signed-off-by: Alexandru Ardelean > --- > .../devicetree/bindings/net/adi,adin.yaml | 60 +++++++++++++++++++ > 1 file changed, 60 insertions(+) > > diff --git a/Documentation/devicetree/bindings/net/adi,adin.yaml b/Documentation/devicetree/bindings/net/adi,adin.yaml > index d95cc691a65f..eb56f35309e0 100644 > --- a/Documentation/devicetree/bindings/net/adi,adin.yaml > +++ b/Documentation/devicetree/bindings/net/adi,adin.yaml > @@ -36,6 +36,60 @@ properties: > enum: [ 4, 8, 12, 16, 20, 24 ] > default: 8 > > + adi,1588-rx-sop-delays-cycles: > + allOf: > + - $ref: /schemas/types.yaml#definitions/uint8-array > + - items: > + - minItems: 3 > + maxItems: 3 You can split up the description into constraints something like this (and minItems/maxItems becomes implied): items: - description: delay for 10BASE-T - description: delay for 100BASE-T - description: delay for 1000BASE-T > + description: | > + Enables Start Packet detection (SOP) for received IEEE 1588 time stamp > + controls, and configures the number of cycles (of the MII RX_CLK clock) > + to delay the indication of RX SOP frames for 10/100/1000 BASE-T links. > + The first element (in the array) configures the delay for 10BASE-T, > + the second for 100BASE-T, and the third for 1000BASE-T. > + > + adi,1588-rx-sop-pin-name: > + description: | > + This option must be used in together with 'adi,1588-rx-sop-delays-cycles' > + to specify which physical pin should be used to signal the MAC that > + the PHY is currently processing an IEEE 1588 timestamp control packet. > + The driver will report an error if the value of this property is the > + same as 'adi,1588-tx-sop-pin-name' > + enum: > + - gp_clk > + - link_st > + - int_n > + - led_0 > + > + adi,1588-tx-sop-delays-ns: > + allOf: > + - $ref: /schemas/types.yaml#definitions/uint8-array > + - items: > + - minItems: 3 > + maxItems: 3 This should be: - minItems: 3 maxItems: 3 items: multipleOf: 8 > + description: | > + Enables Start Packet detection (SOP) for IEEE 1588 time stamp controls, > + and configures the number of nano-seconds to delay the indication of > + TX frames for 10/100/1000 BASE-T links. > + The first element (in the array) configures the delay for 10BASE-T, > + the second for 100BASE-T, and the third for 1000BASE-T. > + The delays must be multiples of 8 ns (i.e. 8, 16, 24, etc). > + > + adi,1588-tx-sop-pin-name: > + description: | > + This option must be used in together with 'adi,1588-tx-sop-delays-ns' > + to specify which physical pin should be used to signal the MAC that > + the PHY is currently processing an IEEE 1588 timestamp control packet > + on the TX path. > + The driver will report an error if the value of this property is the > + same as 'adi,1588-rx-sop-pin-name' > + enum: > + - gp_clk > + - link_st > + - int_n > + - led_0 > + > examples: > - | > ethernet { > @@ -62,5 +116,11 @@ examples: > reg = <1>; > > adi,fifo-depth-bits = <16>; > + > + adi,1588-rx-sop-delays-cycles = [ 00 00 00 ]; > + adi,1588-rx-sop-pin-name = "int_n"; > + > + adi,1588-tx-sop-delays-ns = [ 00 08 10 ]; > + adi,1588-tx-sop-pin-name = "led_0"; > }; > }; > -- > 2.20.1 >