From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4FAF5C2D0CE for ; Fri, 24 Jan 2020 08:25:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 283E02071A for ; Fri, 24 Jan 2020 08:25:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727432AbgAXIZo (ORCPT ); Fri, 24 Jan 2020 03:25:44 -0500 Received: from relay6-d.mail.gandi.net ([217.70.183.198]:60731 "EHLO relay6-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725843AbgAXIZo (ORCPT ); Fri, 24 Jan 2020 03:25:44 -0500 X-Originating-IP: 88.190.179.123 Received: from localhost (unknown [88.190.179.123]) (Authenticated sender: repk@triplefau.lt) by relay6-d.mail.gandi.net (Postfix) with ESMTPSA id 63EFEC0016; Fri, 24 Jan 2020 08:25:41 +0000 (UTC) Date: Fri, 24 Jan 2020 09:34:05 +0100 From: Remi Pommarel To: Kishon Vijay Abraham I , Yue Wang , Kevin Hilman , Lorenzo Pieralisi , Bjorn Helgaas , Neil Armstrong , Martin Blumenstingl , Rob Herring Cc: Jerome Brunet , linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-pci@vger.kernel.org Subject: Re: [PATCH v6 4/7] arm64: dts: meson-axg: Add PCIE PHY nodes Message-ID: <20200124083405.GW1803@voidbox> References: <20200123232943.10229-1-repk@triplefau.lt> <20200123232943.10229-5-repk@triplefau.lt> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200123232943.10229-5-repk@triplefau.lt> Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Add missing Reviewed/Acked-by from v5. On Fri, Jan 24, 2020 at 12:29:40AM +0100, Remi Pommarel wrote: > Enable both PCIE and shared MIPI/PCIE PHY nodes in order to make PCIE > reliable on AXG SoC. > > Signed-off-by: Remi Pommarel > --- > arch/arm64/boot/dts/amlogic/meson-axg.dtsi | 16 ++++++++++++++++ > 1 file changed, 16 insertions(+) > > diff --git a/arch/arm64/boot/dts/amlogic/meson-axg.dtsi b/arch/arm64/boot/dts/amlogic/meson-axg.dtsi > index 04803c3bccfa..08a178aa0133 100644 > --- a/arch/arm64/boot/dts/amlogic/meson-axg.dtsi > +++ b/arch/arm64/boot/dts/amlogic/meson-axg.dtsi > @@ -12,6 +12,7 @@ > #include > #include > #include > +#include > > / { > compatible = "amlogic,meson-axg"; > @@ -1104,6 +1105,12 @@ hiubus: bus@ff63c000 { > #size-cells = <2>; > ranges = <0x0 0x0 0x0 0xff63c000 0x0 0x1c00>; > > + mipi_analog_phy: phy@0 { > + compatible = "amlogic,axg-mipi-pcie-analog-phy"; > + reg = <0x0 0x0 0x0 0xc>; > + #phy-cells = <1>; > + }; > + > sysctrl: system-controller@0 { > compatible = "amlogic,meson-axg-hhi-sysctrl", > "simple-mfd", "syscon"; > @@ -1356,6 +1363,15 @@ tdmout_c: audio-controller@580 { > }; > }; > > + pcie_phy: bus@ff644000 { > + compatible = "amlogic,axg-pcie-phy"; > + reg = <0x0 0xff644000 0x0 0x1c>; > + resets = <&reset RESET_PCIE_PHY>; > + phys = <&mipi_analog_phy PHY_TYPE_PCIE>; > + phy-names = "analog"; > + #phy-cells = <0>; > + }; > + > aobus: bus@ff800000 { > compatible = "simple-bus"; > reg = <0x0 0xff800000 0x0 0x100000>; Reviewed-by: Neil Armstrong