* [PATCH] dt-bindings: fix compilation error of the example in marvell,mmp3-hsic-phy.yaml
@ 2020-01-24 10:57 Dafna Hirschfeld
2020-01-24 14:08 ` Rob Herring
0 siblings, 1 reply; 3+ messages in thread
From: Dafna Hirschfeld @ 2020-01-24 10:57 UTC (permalink / raw)
To: devicetree
Cc: kishon, robh+dt, mark.rutland, linux-kernel, dafna.hirschfeld,
helen.koike, ezequiel, kernel, dafna3
Running `make dt_binging_check`, gives the error:
DTC Documentation/devicetree/bindings/phy/marvell,mmp3-hsic-phy.example.dt.yaml
Error: Documentation/devicetree/bindings/phy/marvell,mmp3-hsic-phy.example.dts:20.41-42 syntax error
FATAL ERROR: Unable to parse input tree
This is because the example uses the macro GPIO_ACTIVE_HIGH which
is defined in gpio.h but the include of this header is missing.
Add the include to fix the error.
Signed-off-by: Dafna Hirschfeld <dafna.hirschfeld@collabora.com>
---
Documentation/devicetree/bindings/phy/marvell,mmp3-hsic-phy.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/phy/marvell,mmp3-hsic-phy.yaml b/Documentation/devicetree/bindings/phy/marvell,mmp3-hsic-phy.yaml
index 7917a95cda78..5ab436189f3b 100644
--- a/Documentation/devicetree/bindings/phy/marvell,mmp3-hsic-phy.yaml
+++ b/Documentation/devicetree/bindings/phy/marvell,mmp3-hsic-phy.yaml
@@ -33,6 +33,7 @@ required:
examples:
- |
+ #include <dt-bindings/gpio/gpio.h>
hsic-phy@f0001800 {
compatible = "marvell,mmp3-hsic-phy";
reg = <0xf0001800 0x40>;
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] dt-bindings: fix compilation error of the example in marvell,mmp3-hsic-phy.yaml
2020-01-24 10:57 [PATCH] dt-bindings: fix compilation error of the example in marvell,mmp3-hsic-phy.yaml Dafna Hirschfeld
@ 2020-01-24 14:08 ` Rob Herring
2020-01-24 20:11 ` Olof Johansson
0 siblings, 1 reply; 3+ messages in thread
From: Rob Herring @ 2020-01-24 14:08 UTC (permalink / raw)
To: Dafna Hirschfeld, soc
Cc: devicetree, Kishon Vijay Abraham I, Mark Rutland,
linux-kernel@vger.kernel.org, Helen Koike, Ezequiel Garcia,
Collabora Kernel ML, dafna3
On Fri, Jan 24, 2020 at 4:58 AM Dafna Hirschfeld
<dafna.hirschfeld@collabora.com> wrote:
>
> Running `make dt_binging_check`, gives the error:
>
> DTC Documentation/devicetree/bindings/phy/marvell,mmp3-hsic-phy.example.dt.yaml
> Error: Documentation/devicetree/bindings/phy/marvell,mmp3-hsic-phy.example.dts:20.41-42 syntax error
> FATAL ERROR: Unable to parse input tree
>
> This is because the example uses the macro GPIO_ACTIVE_HIGH which
> is defined in gpio.h but the include of this header is missing.
> Add the include to fix the error.
>
> Signed-off-by: Dafna Hirschfeld <dafna.hirschfeld@collabora.com>
Fixes: f6f149604eef ("dt-bindings: phy: Add binding for marvell,mmp3-hsic-phy")
Acked-by: Rob Herring <robh@kernel.org>
Arnd, Olof, The above commit is in your tree. Please apply this.
Rob
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] dt-bindings: fix compilation error of the example in marvell,mmp3-hsic-phy.yaml
2020-01-24 14:08 ` Rob Herring
@ 2020-01-24 20:11 ` Olof Johansson
0 siblings, 0 replies; 3+ messages in thread
From: Olof Johansson @ 2020-01-24 20:11 UTC (permalink / raw)
To: Rob Herring
Cc: Dafna Hirschfeld, soc, devicetree, Kishon Vijay Abraham I,
Mark Rutland, linux-kernel@vger.kernel.org, Helen Koike,
Ezequiel Garcia, Collabora Kernel ML, dafna3
On Fri, Jan 24, 2020 at 08:08:58AM -0600, Rob Herring wrote:
> On Fri, Jan 24, 2020 at 4:58 AM Dafna Hirschfeld
> <dafna.hirschfeld@collabora.com> wrote:
> >
> > Running `make dt_binging_check`, gives the error:
> >
> > DTC Documentation/devicetree/bindings/phy/marvell,mmp3-hsic-phy.example.dt.yaml
> > Error: Documentation/devicetree/bindings/phy/marvell,mmp3-hsic-phy.example.dts:20.41-42 syntax error
> > FATAL ERROR: Unable to parse input tree
> >
> > This is because the example uses the macro GPIO_ACTIVE_HIGH which
> > is defined in gpio.h but the include of this header is missing.
> > Add the include to fix the error.
> >
> > Signed-off-by: Dafna Hirschfeld <dafna.hirschfeld@collabora.com>
>
> Fixes: f6f149604eef ("dt-bindings: phy: Add binding for marvell,mmp3-hsic-phy")
> Acked-by: Rob Herring <robh@kernel.org>
>
> Arnd, Olof, The above commit is in your tree. Please apply this.
Applied.
Thanks,
-Olof
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-01-24 20:23 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-01-24 10:57 [PATCH] dt-bindings: fix compilation error of the example in marvell,mmp3-hsic-phy.yaml Dafna Hirschfeld
2020-01-24 14:08 ` Rob Herring
2020-01-24 20:11 ` Olof Johansson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).