From: Vinod Koul <vkoul@kernel.org>
To: Douglas Anderson <dianders@chromium.org>
Cc: Bjorn Andersson <bjorn.andersson@linaro.org>,
Andy Gross <andy.gross@linaro.org>,
mka@chromium.org, vbadigan@codeaurora.org,
devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>
Subject: Re: [PATCH] arm64: dts: qcom: qcs404: Fix sdhci compat string
Date: Mon, 27 Jan 2020 22:34:57 +0530 [thread overview]
Message-ID: <20200127170457.GK2841@vkoul-mobl> (raw)
In-Reply-To: <20200127082331.1.I402470e4a162d69fde47ee2ea708b15bde9751f9@changeid>
On 27-01-20, 08:23, Douglas Anderson wrote:
> As per the bindings, the SDHCI controller should have a SoC-specific
> compatible string in addition to the generic version-based one. Add
> it.
Thanks for spotting it Doug, Btw did some script catch it or manual
inspection?
Reviewed-by: Vinod Koul <vkoul@kernel.org>
> Fixes: 7241ab944da3 ("arm64: dts: qcom: qcs404: Add sdcc1 node")
> Signed-off-by: Douglas Anderson <dianders@chromium.org>
> ---
>
> arch/arm64/boot/dts/qcom/qcs404.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/qcs404.dtsi b/arch/arm64/boot/dts/qcom/qcs404.dtsi
> index 4ee1e3d5f123..1eea06435779 100644
> --- a/arch/arm64/boot/dts/qcom/qcs404.dtsi
> +++ b/arch/arm64/boot/dts/qcom/qcs404.dtsi
> @@ -685,7 +685,7 @@ pcie_phy: phy@7786000 {
> };
>
> sdcc1: sdcc@7804000 {
> - compatible = "qcom,sdhci-msm-v5";
> + compatible = "qcom,qcs404-sdhci", "qcom,sdhci-msm-v5";
> reg = <0x07804000 0x1000>, <0x7805000 0x1000>;
> reg-names = "hc_mem", "cmdq_mem";
>
> --
> 2.25.0.341.g760bfbb309-goog
--
~Vinod
next prev parent reply other threads:[~2020-01-27 17:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-27 16:23 [PATCH] arm64: dts: qcom: qcs404: Fix sdhci compat string Douglas Anderson
2020-01-27 17:04 ` Vinod Koul [this message]
2020-01-27 17:07 ` Doug Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200127170457.GK2841@vkoul-mobl \
--to=vkoul@kernel.org \
--cc=andy.gross@linaro.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mka@chromium.org \
--cc=robh+dt@kernel.org \
--cc=vbadigan@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox