From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A6937C33CB7 for ; Mon, 27 Jan 2020 17:05:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6F68022522 for ; Mon, 27 Jan 2020 17:05:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1580144703; bh=Ya/WRnQH2u3rLockj93TPKOSkCdFP07bsj3EgPDYbHE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=NumX0m0Xb3sdEnkh+TBJYsdfikxZNhusT0ZHkvFNHpMcOqMpqnDCd+DgOxzaygH3v PnXxz75sa2+cs/P2M4FCq1FhT6WBmnnGNb30b9oR5z9jj82N5UaSVjDZAAn1EdH+Rr dag4FRPPISJq9ponhZWiU4XR950rlQ5RfcflUejY= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726485AbgA0RFC (ORCPT ); Mon, 27 Jan 2020 12:05:02 -0500 Received: from mail.kernel.org ([198.145.29.99]:54928 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725845AbgA0RFC (ORCPT ); Mon, 27 Jan 2020 12:05:02 -0500 Received: from localhost (unknown [122.181.201.159]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id EE8B6214AF; Mon, 27 Jan 2020 17:05:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1580144701; bh=Ya/WRnQH2u3rLockj93TPKOSkCdFP07bsj3EgPDYbHE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=wXEesJl+Vy0HGnw/LDcKNUbWVJh1JS7CrjMWazZYB+Ux9ikTAmZBbBl3GyFJJnUwK IbdOVcf3VQNaUWdWUbNaqYKuOX3a/vr1yp85xj/T1Lrs4eZufdqCaPiWxpKxuDD0Uj wCp8xcn7kGIxEKAfgmM0aBID+fahQibKwKJ0FFEQ= Date: Mon, 27 Jan 2020 22:34:57 +0530 From: Vinod Koul To: Douglas Anderson Cc: Bjorn Andersson , Andy Gross , mka@chromium.org, vbadigan@codeaurora.org, devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Rob Herring , Mark Rutland Subject: Re: [PATCH] arm64: dts: qcom: qcs404: Fix sdhci compat string Message-ID: <20200127170457.GK2841@vkoul-mobl> References: <20200127082331.1.I402470e4a162d69fde47ee2ea708b15bde9751f9@changeid> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200127082331.1.I402470e4a162d69fde47ee2ea708b15bde9751f9@changeid> Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 27-01-20, 08:23, Douglas Anderson wrote: > As per the bindings, the SDHCI controller should have a SoC-specific > compatible string in addition to the generic version-based one. Add > it. Thanks for spotting it Doug, Btw did some script catch it or manual inspection? Reviewed-by: Vinod Koul > Fixes: 7241ab944da3 ("arm64: dts: qcom: qcs404: Add sdcc1 node") > Signed-off-by: Douglas Anderson > --- > > arch/arm64/boot/dts/qcom/qcs404.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/qcom/qcs404.dtsi b/arch/arm64/boot/dts/qcom/qcs404.dtsi > index 4ee1e3d5f123..1eea06435779 100644 > --- a/arch/arm64/boot/dts/qcom/qcs404.dtsi > +++ b/arch/arm64/boot/dts/qcom/qcs404.dtsi > @@ -685,7 +685,7 @@ pcie_phy: phy@7786000 { > }; > > sdcc1: sdcc@7804000 { > - compatible = "qcom,sdhci-msm-v5"; > + compatible = "qcom,qcs404-sdhci", "qcom,sdhci-msm-v5"; > reg = <0x07804000 0x1000>, <0x7805000 0x1000>; > reg-names = "hc_mem", "cmdq_mem"; > > -- > 2.25.0.341.g760bfbb309-goog -- ~Vinod