From: Boris Brezillon <boris.brezillon@collabora.com>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: dri-devel@lists.freedesktop.org,
Lucas Stach <l.stach@pengutronix.de>,
Chris Healy <cphealy@gmail.com>,
Andrey Smirnov <andrew.smirnov@gmail.com>,
Nikita Yushchenko <nikita.yoush@cogentembedded.com>,
kernel@collabora.com, Thierry Reding <thierry.reding@gmail.com>,
Sam Ravnborg <sam@ravnborg.org>,
Philipp Zabel <p.zabel@pengutronix.de>,
Andrzej Hajda <a.hajda@samsung.com>,
Neil Armstrong <narmstrong@baylibre.com>,
Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
Jonas Karlman <jonas@kwiboo.se>,
Jernej Skrabec <jernej.skrabec@siol.net>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org,
intel-gfx-trybot@lists.freedesktop.org,
Daniel Vetter <daniel.vetter@ffwll.ch>
Subject: Re: [PATCH v9 01/12] drm/bridge: Add a drm_bridge_state object
Date: Mon, 27 Jan 2020 18:49:18 +0100 [thread overview]
Message-ID: <20200127184918.60b3cdf3@collabora.com> (raw)
In-Reply-To: <20200127172652.GB43062@phenom.ffwll.local>
On Mon, 27 Jan 2020 18:26:52 +0100
Daniel Vetter <daniel@ffwll.ch> wrote:
> On Mon, Jan 27, 2020 at 12:00:32PM +0100, Boris Brezillon wrote:
> > One of the last remaining objects to not have its atomic state.
> >
> > This is being motivated by our attempt to support runtime bus-format
> > negotiation between elements of the bridge chain.
> > This patch just paves the road for such a feature by adding a new
> > drm_bridge_state object inheriting from drm_private_obj so we can
> > re-use some of the existing state initialization/tracking logic.
> >
> > Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com>
> > Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
> > Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>
> > Acked-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> > ---
> > Changes in v9:
> > * Clarify the fact that the bridge->atomic_reset() and
> > {connector,plane,crtc,...}->reset() semantics are different
> > * Move the drm_atomic_private_obj_init() call back to
> > drm_bridge_attach()
> > * Check the presence of ->atomic_duplicate_state instead of
> > ->atomic_reset in drm_atomic_add_encoder_bridges()
> > * Fix copy&paste errors in the atomic bridge state helpers doc
> > * Add A-b/R-b tags
> >
> > Changes in v8:
> > * Move bridge state helpers out of the CONFIG_DEBUGFS section
> >
> > Changes in v7:
> > * Move helpers, struct-defs, ... to atomic helper files to avoid the
> > drm -> drm_kms_helper -> drm circular dep
> > * Stop providing default implementation for atomic state reset,
> > duplicate and destroy hooks (has to do with the helper/core split)
> > * Drop all R-b/T-b as helpers have now be moved to other places
>
> ^^ we generally keep the changelog when committing in drm, since it
> contains useful stuff.
Alright (I tend to forget that drm does things differently). I find it a
bit redundant given the final commit also contains a patchwork link
which contains all revisions + the discussion that happened on each
version.
> If you don't want to do that, then at least update
> the commit message to make sure all the design discussion is reflected in
> there somewhere. Which atm it definitely isn't.
I'll update the commit messages to add those changelogs.
next prev parent reply other threads:[~2020-01-27 17:49 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-27 11:00 [PATCH v9 00/12] drm: Add support for bus-format negotiation Boris Brezillon
2020-01-27 11:00 ` [PATCH v9 01/12] drm/bridge: Add a drm_bridge_state object Boris Brezillon
2020-01-27 17:26 ` Daniel Vetter
2020-01-27 17:49 ` Boris Brezillon [this message]
2020-01-27 11:00 ` [PATCH v9 02/12] drm/rcar-du: Plug atomic state hooks to the default implementation Boris Brezillon
2020-01-27 11:00 ` [PATCH v9 03/12] drm/bridge: analogix: " Boris Brezillon
2020-01-27 11:00 ` [PATCH v9 04/12] drm/bridge: Patch atomic hooks to take a drm_bridge_state Boris Brezillon
2020-01-27 11:00 ` [PATCH v9 05/12] drm/bridge: Add an ->atomic_check() hook Boris Brezillon
2020-01-27 11:00 ` [PATCH v9 06/12] drm/bridge: Add the necessary bits to support bus format negotiation Boris Brezillon
2020-01-27 11:00 ` [PATCH v9 07/12] drm/imx: pd: Use bus format/flags provided by the bridge when available Boris Brezillon
2020-01-27 12:57 ` Philipp Zabel
2020-01-27 11:00 ` [PATCH v9 08/12] drm/bridge: lvds-codec: Implement basic bus format negotiation Boris Brezillon
2020-01-27 11:00 ` [PATCH v9 09/12] dt-bindings: display: bridge: lvds-codec: Add new bus-width prop Boris Brezillon
2020-01-27 15:39 ` Rob Herring
2020-01-27 11:00 ` [PATCH v9 10/12] drm/bridge: panel: Propage bus format/flags Boris Brezillon
2020-01-27 11:00 ` [PATCH v9 11/12] drm/panel: simple: Fix the lt089ac29000 bus_format Boris Brezillon
2020-01-27 11:00 ` [PATCH v9 12/12] ARM: dts: imx: imx51-zii-rdu1: Fix the display pipeline definition Boris Brezillon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200127184918.60b3cdf3@collabora.com \
--to=boris.brezillon@collabora.com \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=a.hajda@samsung.com \
--cc=andrew.smirnov@gmail.com \
--cc=cphealy@gmail.com \
--cc=daniel.vetter@ffwll.ch \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx-trybot@lists.freedesktop.org \
--cc=jernej.skrabec@siol.net \
--cc=jonas@kwiboo.se \
--cc=kernel@collabora.com \
--cc=l.stach@pengutronix.de \
--cc=mark.rutland@arm.com \
--cc=narmstrong@baylibre.com \
--cc=nikita.yoush@cogentembedded.com \
--cc=p.zabel@pengutronix.de \
--cc=robh+dt@kernel.org \
--cc=sam@ravnborg.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).