From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A7679C2D0DB for ; Tue, 28 Jan 2020 13:47:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7B44524686 for ; Tue, 28 Jan 2020 13:47:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1580219270; bh=FAiIYynFKBuECEDgOwJSnnC0Hg3xYnzoyPy4Ysdo0HU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=h68+VZedKoXpXLHS+ZtmWWYOkY6UkIxM0B1VELSLDLcxnTaFQ1WT8BB8adjw+Lw5q fiY3aBi24fXdrAsv+GhQcNxSRkfgqWysK7jrEx5xoa2WBfAVSLUkW4vttsnN0ter0Y n9wDVr/5uA4yoQibBYGe/4svi4gEcyFpgfuYDr8w= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726129AbgA1Nru (ORCPT ); Tue, 28 Jan 2020 08:47:50 -0500 Received: from mail.kernel.org ([198.145.29.99]:38402 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725852AbgA1Nrt (ORCPT ); Tue, 28 Jan 2020 08:47:49 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 3DD0A24683; Tue, 28 Jan 2020 13:47:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1580219267; bh=FAiIYynFKBuECEDgOwJSnnC0Hg3xYnzoyPy4Ysdo0HU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ZLZiPPEJ3KZYFeEODDcAdKm12adgwJTR1qNu8E+/VB6oWCwBJucsQAZthyd25GaSm jGHTqGPMfkhPC6+DP+HPoE6IHThhQiRXLcdyB7gkdtyywbpx1/t5r0aAVmnkRXDC2v FoBHpKTogtOd0WgKUquetU0/w7h5gM/Rcd86KiYE= Date: Tue, 28 Jan 2020 14:47:45 +0100 From: Greg Kroah-Hartman To: =?iso-8859-1?Q?M=E5ns_Rullg=E5rd?= Cc: Rob Herring , Mark Rutland , linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [RESEND][PATCH 1/2] dt-bindings: usb: add non-removable-ports hub property Message-ID: <20200128134745.GA3048749@kroah.com> References: <20200124152504.23411-1-mans@mansr.com> <20200127153506.GA4589@bogus> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Mon, Jan 27, 2020 at 04:56:15PM +0000, Måns Rullgård wrote: > Rob Herring writes: > > > On Fri, Jan 24, 2020 at 03:25:03PM +0000, Mans Rullgard wrote: > >> Add a non-removable-ports property that lists the hardwired downstream > >> ports of a hub. Although hubs can provide this information, they are > >> not always configured correctly. An alternate means of indicating this > >> for built-in USB devices is thus useful. > >> > >> Signed-off-by: Mans Rullgard > > > > I reviewed this already, but since you didn't add my reviewed-by, I'm > > looking at it again and having 2nd thoughts. > > > >> --- > >> Documentation/devicetree/bindings/usb/usb-device.txt | 4 ++++ > >> 1 file changed, 4 insertions(+) > >> > >> diff --git a/Documentation/devicetree/bindings/usb/usb-device.txt b/Documentation/devicetree/bindings/usb/usb-device.txt > >> index 036be172b1ae..92d863cc96b6 100644 > >> --- a/Documentation/devicetree/bindings/usb/usb-device.txt > >> +++ b/Documentation/devicetree/bindings/usb/usb-device.txt > >> @@ -66,6 +66,10 @@ Required properties for host-controller nodes with device nodes: > >> - #size-cells: shall be 0 > >> > >> > >> +Optional properties for hub and host-controller nodes: > >> +- non-removable-ports: list of hardwired downstream ports > > > > If you have a hardwired device and need to know that, doesn't that imply > > there's some other stuff you need to describe beyond what a standard USB > > device has. Such as a power supply that's not Vbus from the hub. > > I suppose there could be, but there isn't in my actual situation. > > > At a minimum, I think this should be a per port property. > > That's what I suggested first. Greg told me to do it like this instead. I said that? I do not remember discussing this at all, when did that happen? > > Though really, I think this should just be implied by describing the > > device in DT. I'm not sure if there's a case for hotpluggable devices > > described in DT. Maybe with overlays. > > That's also an option. Greg, what do you think? I have no idea, sorry, I'm totally lost here... greg k-h > > -- > Måns Rullgård