From: Sam Ravnborg <sam@ravnborg.org>
To: michael.srba@seznam.cz
Cc: David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org,
Thierry Reding <thierry.reding@gmail.com>,
~postmarketos/upstreaming@lists.sr.ht
Subject: Re: [PATCH 1/2] dt-bindings: display/panel: add bindings for S6E88A0-AMS452EF01
Date: Wed, 29 Jan 2020 19:59:15 +0100 [thread overview]
Message-ID: <20200129185915.GD25273@ravnborg.org> (raw)
In-Reply-To: <20200126183911.17090-1-michael.srba@seznam.cz>
Hi Michael.
On Sun, Jan 26, 2020 at 07:39:10PM +0100, michael.srba@seznam.cz wrote:
> From: Michael Srba <Michael.Srba@seznam.cz>
>
> This patch adds dts bindings for Samsung AMS452EF01 AMOLED panel, which makes
> use of their S6E88A0 controller.
>
> Signed-off-by: Michael Srba <Michael.Srba@seznam.cz>
New bindings files for panels must be in DT schema format (.yaml).
Please see other bindings as examples.
Your example uses GPIO_ACTIVE_HIGH, so rememeber to include the
relevant header file in your example to get the definition.
Sam
> ---
> .../panel/samsung,s6e88a0-ams452ef01.txt | 26 +++++++++++++++++++
> 1 file changed, 26 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/display/panel/samsung,s6e88a0-ams452ef01.txt
>
> diff --git a/Documentation/devicetree/bindings/display/panel/samsung,s6e88a0-ams452ef01.txt b/Documentation/devicetree/bindings/display/panel/samsung,s6e88a0-ams452ef01.txt
> new file mode 100644
> index 000000000000..2dcf9580febd
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/panel/samsung,s6e88a0-ams452ef01.txt
> @@ -0,0 +1,26 @@
> +Samsung AMS452EF01 AMOLED panel with S6E88A0 video mode controller.
> +
> +Required properties:
> + - compatible: "samsung,s6e88a0-ams452ef01"
> + - reg: the virtual channel number of a DSI peripheral
> + - vdd3-supply: core voltage supply
> + - vci-supply: voltage supply for analog circuits
> + - reset-gpios: a GPIO spec for the reset pin
> +
> +The device node can contain one 'port' child node with one child
> +'endpoint' node, according to the bindings defined in [1]. This
> +node should describe panel's video bus.
> +
> +[1]: Documentation/devicetree/bindings/media/video-interfaces.txt
> +
> +Example:
> +
> + panel@0 {
> + reg = <0>;
> +
> + compatible = "samsung,s6e88a0-ams452ef01";
> +
> + vdd3-supply = <&pm8916_l17>;
> + vci-supply = <®_vlcd_vci>;
> + reset-gpios = <&msmgpio 25 GPIO_ACTIVE_HIGH>;
> + };
> --
> 2.24.0
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
prev parent reply other threads:[~2020-01-29 18:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-26 18:39 [PATCH 1/2] dt-bindings: display/panel: add bindings for S6E88A0-AMS452EF01 michael.srba
2020-01-26 18:39 ` [PATCH 2/2] drm/panel: Add a driver for Samsung s6e88a0-ams452ef01 panel michael.srba
2020-01-29 19:08 ` Sam Ravnborg
2020-01-29 18:59 ` Sam Ravnborg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200129185915.GD25273@ravnborg.org \
--to=sam@ravnborg.org \
--cc=airlied@linux.ie \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=mark.rutland@arm.com \
--cc=michael.srba@seznam.cz \
--cc=robh+dt@kernel.org \
--cc=thierry.reding@gmail.com \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).