From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3A431C3F68F for ; Wed, 29 Jan 2020 18:59:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 20D5F207FF for ; Wed, 29 Jan 2020 18:59:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727719AbgA2S7V (ORCPT ); Wed, 29 Jan 2020 13:59:21 -0500 Received: from asavdk3.altibox.net ([109.247.116.14]:37072 "EHLO asavdk3.altibox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727529AbgA2S7V (ORCPT ); Wed, 29 Jan 2020 13:59:21 -0500 Received: from ravnborg.org (unknown [158.248.194.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by asavdk3.altibox.net (Postfix) with ESMTPS id 7C1EA20080; Wed, 29 Jan 2020 19:59:16 +0100 (CET) Date: Wed, 29 Jan 2020 19:59:15 +0100 From: Sam Ravnborg To: michael.srba@seznam.cz Cc: David Airlie , Daniel Vetter , Rob Herring , Mark Rutland , devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org, Thierry Reding , ~postmarketos/upstreaming@lists.sr.ht Subject: Re: [PATCH 1/2] dt-bindings: display/panel: add bindings for S6E88A0-AMS452EF01 Message-ID: <20200129185915.GD25273@ravnborg.org> References: <20200126183911.17090-1-michael.srba@seznam.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200126183911.17090-1-michael.srba@seznam.cz> User-Agent: Mutt/1.10.1 (2018-07-13) X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=eMA9ckh1 c=1 sm=1 tr=0 a=UWs3HLbX/2nnQ3s7vZ42gw==:117 a=UWs3HLbX/2nnQ3s7vZ42gw==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=kj9zAlcOel0A:10 a=e5mUnYsNAAAA:8 a=PAS-ew-9kLfG7pzAJC4A:9 a=CjuIK1q_8ugA:10 a=Vxmtnl_E_bksehYqCbjh:22 Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Michael. On Sun, Jan 26, 2020 at 07:39:10PM +0100, michael.srba@seznam.cz wrote: > From: Michael Srba > > This patch adds dts bindings for Samsung AMS452EF01 AMOLED panel, which makes > use of their S6E88A0 controller. > > Signed-off-by: Michael Srba New bindings files for panels must be in DT schema format (.yaml). Please see other bindings as examples. Your example uses GPIO_ACTIVE_HIGH, so rememeber to include the relevant header file in your example to get the definition. Sam > --- > .../panel/samsung,s6e88a0-ams452ef01.txt | 26 +++++++++++++++++++ > 1 file changed, 26 insertions(+) > create mode 100644 Documentation/devicetree/bindings/display/panel/samsung,s6e88a0-ams452ef01.txt > > diff --git a/Documentation/devicetree/bindings/display/panel/samsung,s6e88a0-ams452ef01.txt b/Documentation/devicetree/bindings/display/panel/samsung,s6e88a0-ams452ef01.txt > new file mode 100644 > index 000000000000..2dcf9580febd > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/panel/samsung,s6e88a0-ams452ef01.txt > @@ -0,0 +1,26 @@ > +Samsung AMS452EF01 AMOLED panel with S6E88A0 video mode controller. > + > +Required properties: > + - compatible: "samsung,s6e88a0-ams452ef01" > + - reg: the virtual channel number of a DSI peripheral > + - vdd3-supply: core voltage supply > + - vci-supply: voltage supply for analog circuits > + - reset-gpios: a GPIO spec for the reset pin > + > +The device node can contain one 'port' child node with one child > +'endpoint' node, according to the bindings defined in [1]. This > +node should describe panel's video bus. > + > +[1]: Documentation/devicetree/bindings/media/video-interfaces.txt > + > +Example: > + > + panel@0 { > + reg = <0>; > + > + compatible = "samsung,s6e88a0-ams452ef01"; > + > + vdd3-supply = <&pm8916_l17>; > + vci-supply = <®_vlcd_vci>; > + reset-gpios = <&msmgpio 25 GPIO_ACTIVE_HIGH>; > + }; > -- > 2.24.0 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel