* Re: [PATCH v2 2/2] dt-bindings: net: bluetooth: Add device tree bindings for QTI chip WCN3991 [not found] ` <1580456335-7317-2-git-send-email-gubbaven@codeaurora.org> @ 2020-01-31 22:36 ` Matthias Kaehlcke 2020-02-03 8:23 ` gubbaven 0 siblings, 1 reply; 2+ messages in thread From: Matthias Kaehlcke @ 2020-01-31 22:36 UTC (permalink / raw) To: Venkata Lakshmi Narayana Gubba Cc: marcel, johan.hedberg, linux-kernel, linux-bluetooth, robh, hemantg, linux-arm-msm, bgodavar, tientzu, seanpaul, rjliao, yshavit, Rob Herring, Frank Rowand, devicetree + DT folks On Fri, Jan 31, 2020 at 01:08:55PM +0530, Venkata Lakshmi Narayana Gubba wrote: > Add compatible string for the Qualcomm WCN3991 Bluetooth controller > > Signed-off-by: Venkata Lakshmi Narayana Gubba <gubbaven@codeaurora.org> > --- > Documentation/devicetree/bindings/net/qualcomm-bluetooth.txt | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/Documentation/devicetree/bindings/net/qualcomm-bluetooth.txt b/Documentation/devicetree/bindings/net/qualcomm-bluetooth.txt > index 68b67d9..e72045d 100644 > --- a/Documentation/devicetree/bindings/net/qualcomm-bluetooth.txt > +++ b/Documentation/devicetree/bindings/net/qualcomm-bluetooth.txt > @@ -11,6 +11,7 @@ Required properties: > - compatible: should contain one of the following: > * "qcom,qca6174-bt" > * "qcom,wcn3990-bt" > + * "qcom,wcn3991-bt" > * "qcom,wcn3998-bt" > > Optional properties for compatible string qcom,qca6174-bt: > @@ -30,6 +31,7 @@ Optional properties for compatible string qcom,wcn399x-bt: > > - max-speed: see Documentation/devicetree/bindings/serial/slave-device.txt > - firmware-name: specify the name of nvm firmware to load > + - clocks: clock provided to the controller > > Examples: > > @@ -56,5 +58,6 @@ serial@898000 { > vddch0-supply = <&vreg_l25a_3p3>; > max-speed = <3200000>; > firmware-name = "crnv21.bin"; > + clocks = <&rpmhcc>; That specifies a clock controller, not a clock. For a device with the SC7180 SoC we use this: clocks = <&rpmhcc RPMH_RF_CLK2>; > }; > }; ^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH v2 2/2] dt-bindings: net: bluetooth: Add device tree bindings for QTI chip WCN3991 2020-01-31 22:36 ` [PATCH v2 2/2] dt-bindings: net: bluetooth: Add device tree bindings for QTI chip WCN3991 Matthias Kaehlcke @ 2020-02-03 8:23 ` gubbaven 0 siblings, 0 replies; 2+ messages in thread From: gubbaven @ 2020-02-03 8:23 UTC (permalink / raw) To: Matthias Kaehlcke Cc: marcel, johan.hedberg, linux-kernel, linux-bluetooth, robh, hemantg, linux-arm-msm, bgodavar, tientzu, seanpaul, rjliao, yshavit, Rob Herring, Frank Rowand, devicetree Hi Matthias, On 2020-02-01 04:06, Matthias Kaehlcke wrote: > + DT folks > > On Fri, Jan 31, 2020 at 01:08:55PM +0530, Venkata Lakshmi Narayana > Gubba wrote: >> Add compatible string for the Qualcomm WCN3991 Bluetooth controller >> >> Signed-off-by: Venkata Lakshmi Narayana Gubba >> <gubbaven@codeaurora.org> >> --- >> Documentation/devicetree/bindings/net/qualcomm-bluetooth.txt | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git >> a/Documentation/devicetree/bindings/net/qualcomm-bluetooth.txt >> b/Documentation/devicetree/bindings/net/qualcomm-bluetooth.txt >> index 68b67d9..e72045d 100644 >> --- a/Documentation/devicetree/bindings/net/qualcomm-bluetooth.txt >> +++ b/Documentation/devicetree/bindings/net/qualcomm-bluetooth.txt >> @@ -11,6 +11,7 @@ Required properties: >> - compatible: should contain one of the following: >> * "qcom,qca6174-bt" >> * "qcom,wcn3990-bt" >> + * "qcom,wcn3991-bt" >> * "qcom,wcn3998-bt" >> >> Optional properties for compatible string qcom,qca6174-bt: >> @@ -30,6 +31,7 @@ Optional properties for compatible string >> qcom,wcn399x-bt: >> >> - max-speed: see >> Documentation/devicetree/bindings/serial/slave-device.txt >> - firmware-name: specify the name of nvm firmware to load >> + - clocks: clock provided to the controller >> >> Examples: >> >> @@ -56,5 +58,6 @@ serial@898000 { >> vddch0-supply = <&vreg_l25a_3p3>; >> max-speed = <3200000>; >> firmware-name = "crnv21.bin"; >> + clocks = <&rpmhcc>; > > That specifies a clock controller, not a clock. > > For a device with the SC7180 SoC we use this: > > clocks = <&rpmhcc RPMH_RF_CLK2>; [Venkata] : Sure, we will update in next patch set. > >> }; >> }; Regards, Venkata. ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-02-03 8:23 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1580456335-7317-1-git-send-email-gubbaven@codeaurora.org>
[not found] ` <1580456335-7317-2-git-send-email-gubbaven@codeaurora.org>
2020-01-31 22:36 ` [PATCH v2 2/2] dt-bindings: net: bluetooth: Add device tree bindings for QTI chip WCN3991 Matthias Kaehlcke
2020-02-03 8:23 ` gubbaven
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).