* [PATCH 2/4] [media] dt-bindings: Add rk3228 to the Rockchip RGA binding doc
[not found] <20200120194158.25357-1-justin.swartz@risingedge.co.za>
@ 2020-01-20 19:41 ` Justin Swartz
2020-01-20 19:41 ` [PATCH 3/4] ARM: dts: rockchip: add rga node for rk322x Justin Swartz
` (3 subsequent siblings)
4 siblings, 0 replies; 12+ messages in thread
From: Justin Swartz @ 2020-01-20 19:41 UTC (permalink / raw)
To: Jacob Chen, Ezequiel Garcia, Mauro Carvalho Chehab, Rob Herring,
Mark Rutland, Heiko Stuebner
Cc: Justin Swartz, linux-media, devicetree, linux-arm-kernel,
linux-rockchip, linux-kernel
Add "rockchip,rk3228-rga" to the list of acceptable values for
the "compatible" property.
Signed-off-by: Justin Swartz <justin.swartz@risingedge.co.za>
---
Documentation/devicetree/bindings/media/rockchip-rga.txt | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/media/rockchip-rga.txt b/Documentation/devicetree/bindings/media/rockchip-rga.txt
index fd5276abf..9bac1782d 100644
--- a/Documentation/devicetree/bindings/media/rockchip-rga.txt
+++ b/Documentation/devicetree/bindings/media/rockchip-rga.txt
@@ -6,6 +6,7 @@ BitBLT, alpha blending and image blur/sharpness.
Required properties:
- compatible: value should be one of the following
+ "rockchip,rk3228-rga";
"rockchip,rk3288-rga";
"rockchip,rk3399-rga";
--
2.11.0
^ permalink raw reply related [flat|nested] 12+ messages in thread* [PATCH 3/4] ARM: dts: rockchip: add rga node for rk322x
[not found] <20200120194158.25357-1-justin.swartz@risingedge.co.za>
2020-01-20 19:41 ` [PATCH 2/4] [media] dt-bindings: Add rk3228 to the Rockchip RGA binding doc Justin Swartz
@ 2020-01-20 19:41 ` Justin Swartz
2020-01-20 19:41 ` [PATCH 4/4] ARM: dts: rockchip: add rga to rk3229-xms6 Justin Swartz
` (2 subsequent siblings)
4 siblings, 0 replies; 12+ messages in thread
From: Justin Swartz @ 2020-01-20 19:41 UTC (permalink / raw)
To: Heiko Stuebner, Rob Herring, Mark Rutland
Cc: Justin Swartz, linux-arm-kernel, linux-rockchip, devicetree,
linux-kernel
Add a node to define the presence of RGA, a 2D raster graphic
acceleration unit.
Signed-off-by: Justin Swartz <justin.swartz@risingedge.co.za>
---
arch/arm/boot/dts/rk322x.dtsi | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/arch/arm/boot/dts/rk322x.dtsi b/arch/arm/boot/dts/rk322x.dtsi
index 340ed6ccb..486ad591f 100644
--- a/arch/arm/boot/dts/rk322x.dtsi
+++ b/arch/arm/boot/dts/rk322x.dtsi
@@ -566,6 +566,17 @@
status = "disabled";
};
+ rga: rga@20060000 {
+ compatible = "rockchip,rk3228-rga";
+ reg = <0x20060000 0x1000>;
+ interrupts = <GIC_SPI 33 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&cru ACLK_RGA>, <&cru HCLK_RGA>, <&cru SCLK_RGA>;
+ clock-names = "aclk", "hclk", "sclk";
+ resets = <&cru SRST_RGA>, <&cru SRST_RGA_A>, <&cru SRST_RGA_H>;
+ reset-names = "core", "axi", "ahb";
+ status = "disabled";
+ };
+
vpu_mmu: iommu@20020800 {
compatible = "rockchip,iommu";
reg = <0x20020800 0x100>;
--
2.11.0
^ permalink raw reply related [flat|nested] 12+ messages in thread* [PATCH 4/4] ARM: dts: rockchip: add rga to rk3229-xms6
[not found] <20200120194158.25357-1-justin.swartz@risingedge.co.za>
2020-01-20 19:41 ` [PATCH 2/4] [media] dt-bindings: Add rk3228 to the Rockchip RGA binding doc Justin Swartz
2020-01-20 19:41 ` [PATCH 3/4] ARM: dts: rockchip: add rga node for rk322x Justin Swartz
@ 2020-01-20 19:41 ` Justin Swartz
2020-01-21 20:11 ` [PATCH v2 0/2] Add rga to rk322x device tree Justin Swartz
2020-01-21 22:02 ` [PATCH v3 0/2] Add rga to rk322x device tree Justin Swartz
4 siblings, 0 replies; 12+ messages in thread
From: Justin Swartz @ 2020-01-20 19:41 UTC (permalink / raw)
To: Heiko Stuebner, Rob Herring, Mark Rutland
Cc: Justin Swartz, linux-arm-kernel, linux-rockchip, devicetree,
linux-kernel
Enable RGA for Mecer Xtreme Mini S6.
Signed-off-by: Justin Swartz <justin.swartz@risingedge.co.za>
---
arch/arm/boot/dts/rk3229-xms6.dts | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/arch/arm/boot/dts/rk3229-xms6.dts b/arch/arm/boot/dts/rk3229-xms6.dts
index 679fc2b00..894f64a4a 100644
--- a/arch/arm/boot/dts/rk3229-xms6.dts
+++ b/arch/arm/boot/dts/rk3229-xms6.dts
@@ -202,6 +202,10 @@
status = "okay";
};
+&rga {
+ status = "okay";
+};
+
&sdmmc {
cap-mmc-highspeed;
disable-wp;
--
2.11.0
^ permalink raw reply related [flat|nested] 12+ messages in thread* [PATCH v2 0/2] Add rga to rk322x device tree
[not found] <20200120194158.25357-1-justin.swartz@risingedge.co.za>
` (2 preceding siblings ...)
2020-01-20 19:41 ` [PATCH 4/4] ARM: dts: rockchip: add rga to rk3229-xms6 Justin Swartz
@ 2020-01-21 20:11 ` Justin Swartz
2020-01-21 20:11 ` [PATCH v2 1/2] ARM: dts: rockchip: add rga node for rk322x Justin Swartz
2020-01-21 20:11 ` [PATCH v2 2/2] ARM: dts: rockchip: enable rga for rk3229-xms6 Justin Swartz
2020-01-21 22:02 ` [PATCH v3 0/2] Add rga to rk322x device tree Justin Swartz
4 siblings, 2 replies; 12+ messages in thread
From: Justin Swartz @ 2020-01-21 20:11 UTC (permalink / raw)
To: Heiko Stuebner, Rob Herring, Mark Rutland
Cc: Justin Swartz, linux-arm-kernel, linux-rockchip, devicetree,
linux-kernel
This patchset aims to enable use of Rockchip's RGA, a 2D raster
graphic acceleration unit, on rk322x based devices.
Changes in v2:
- Remove unnecessary "rockchip,rk3228-rga" device tree compatibility
string patch, as advised by Ezequiel Garcia.
- Use both "rockchip,rk3228-rga" and "rockchip,rk3288-rga" in the
rga node's compatibility property, as suggested by Heiko Stuebner.
Justin Swartz (2):
ARM: dts: rockchip: add rga node for rk322x
ARM: dts: rockchip: enable rga for rk3229-xms6
arch/arm/boot/dts/rk3229-xms6.dts | 4 ++++
arch/arm/boot/dts/rk322x.dtsi | 11 +++++++++++
2 files changed, 15 insertions(+)
--
2.11.0
^ permalink raw reply [flat|nested] 12+ messages in thread* [PATCH v2 1/2] ARM: dts: rockchip: add rga node for rk322x
2020-01-21 20:11 ` [PATCH v2 0/2] Add rga to rk322x device tree Justin Swartz
@ 2020-01-21 20:11 ` Justin Swartz
2020-01-21 21:34 ` Johan Jonker
2020-01-21 20:11 ` [PATCH v2 2/2] ARM: dts: rockchip: enable rga for rk3229-xms6 Justin Swartz
1 sibling, 1 reply; 12+ messages in thread
From: Justin Swartz @ 2020-01-21 20:11 UTC (permalink / raw)
To: Heiko Stuebner, Rob Herring, Mark Rutland
Cc: Justin Swartz, linux-arm-kernel, linux-rockchip, devicetree,
linux-kernel
Add a node to define the presence of RGA, a 2D raster graphic
acceleration unit.
Signed-off-by: Justin Swartz <justin.swartz@risingedge.co.za>
---
arch/arm/boot/dts/rk322x.dtsi | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/arch/arm/boot/dts/rk322x.dtsi b/arch/arm/boot/dts/rk322x.dtsi
index 340ed6ccb..efa733207 100644
--- a/arch/arm/boot/dts/rk322x.dtsi
+++ b/arch/arm/boot/dts/rk322x.dtsi
@@ -566,6 +566,17 @@
status = "disabled";
};
+ rga: rga@20060000 {
+ compatible = "rockchip,rk3228-rga", "rockchip,rk3288-rga";
+ reg = <0x20060000 0x1000>;
+ interrupts = <GIC_SPI 33 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&cru ACLK_RGA>, <&cru HCLK_RGA>, <&cru SCLK_RGA>;
+ clock-names = "aclk", "hclk", "sclk";
+ resets = <&cru SRST_RGA>, <&cru SRST_RGA_A>, <&cru SRST_RGA_H>;
+ reset-names = "core", "axi", "ahb";
+ status = "disabled";
+ };
+
vpu_mmu: iommu@20020800 {
compatible = "rockchip,iommu";
reg = <0x20020800 0x100>;
--
2.11.0
^ permalink raw reply related [flat|nested] 12+ messages in thread* Re: [PATCH v2 1/2] ARM: dts: rockchip: add rga node for rk322x
2020-01-21 20:11 ` [PATCH v2 1/2] ARM: dts: rockchip: add rga node for rk322x Justin Swartz
@ 2020-01-21 21:34 ` Johan Jonker
2020-01-21 21:45 ` Justin Swartz
0 siblings, 1 reply; 12+ messages in thread
From: Johan Jonker @ 2020-01-21 21:34 UTC (permalink / raw)
To: justin.swartz
Cc: devicetree, heiko, linux-arm-kernel, linux-kernel, linux-rockchip,
mark.rutland, robh+dt
Hi Justin,
rga is now inserted above vpu_mmu.
Please check the address.
rga: rga@20060000 {
vpu_mmu: iommu@20020800 {
Should go between vop_mmu and iep_mmu.
vop_mmu: iommu@20053f00 {
rga: rga@20060000 {
iep_mmu: iommu@20070800 {
> Add a node to define the presence of RGA, a 2D raster graphic
> acceleration unit.
>
> Signed-off-by: Justin Swartz <justin.swartz@risingedge.co.za>
> ---
> arch/arm/boot/dts/rk322x.dtsi | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
> diff --git a/arch/arm/boot/dts/rk322x.dtsi b/arch/arm/boot/dts/rk322x.dtsi
> index 340ed6ccb..efa733207 100644
> --- a/arch/arm/boot/dts/rk322x.dtsi
> +++ b/arch/arm/boot/dts/rk322x.dtsi
> @@ -566,6 +566,17 @@
> status = "disabled";
> };
>
> + rga: rga@20060000 {
> + compatible = "rockchip,rk3228-rga", "rockchip,rk3288-rga";
> + reg = <0x20060000 0x1000>;
> + interrupts = <GIC_SPI 33 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&cru ACLK_RGA>, <&cru HCLK_RGA>, <&cru SCLK_RGA>;
> + clock-names = "aclk", "hclk", "sclk";
> + resets = <&cru SRST_RGA>, <&cru SRST_RGA_A>, <&cru SRST_RGA_H>;
> + reset-names = "core", "axi", "ahb";
> + status = "disabled";
> + };
> +
> vpu_mmu: iommu@20020800 {
> compatible = "rockchip,iommu";
> reg = <0x20020800 0x100>;
> --
> 2.11.0
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PATCH v2 1/2] ARM: dts: rockchip: add rga node for rk322x
2020-01-21 21:34 ` Johan Jonker
@ 2020-01-21 21:45 ` Justin Swartz
0 siblings, 0 replies; 12+ messages in thread
From: Justin Swartz @ 2020-01-21 21:45 UTC (permalink / raw)
To: Johan Jonker
Cc: devicetree, heiko, linux-arm-kernel, linux-kernel, linux-rockchip,
mark.rutland, robh+dt
Hi Johan,
On 2020-01-21 23:34, Johan Jonker wrote:
> Hi Justin,
>
> rga is now inserted above vpu_mmu.
> Please check the address.
>
> rga: rga@20060000 {
> vpu_mmu: iommu@20020800 {
>
> Should go between vop_mmu and iep_mmu.
>
> vop_mmu: iommu@20053f00 {
> rga: rga@20060000 {
> iep_mmu: iommu@20070800 {
Thanks!
>> Add a node to define the presence of RGA, a 2D raster graphic
>> acceleration unit.
>>
>> Signed-off-by: Justin Swartz <justin.swartz@risingedge.co.za>
>> ---
>> arch/arm/boot/dts/rk322x.dtsi | 11 +++++++++++
>> 1 file changed, 11 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/rk322x.dtsi
>> b/arch/arm/boot/dts/rk322x.dtsi
>> index 340ed6ccb..efa733207 100644
>> --- a/arch/arm/boot/dts/rk322x.dtsi
>> +++ b/arch/arm/boot/dts/rk322x.dtsi
>> @@ -566,6 +566,17 @@
>> status = "disabled";
>> };
>>
>> + rga: rga@20060000 {
>> + compatible = "rockchip,rk3228-rga", "rockchip,rk3288-rga";
>> + reg = <0x20060000 0x1000>;
>> + interrupts = <GIC_SPI 33 IRQ_TYPE_LEVEL_HIGH>;
>> + clocks = <&cru ACLK_RGA>, <&cru HCLK_RGA>, <&cru SCLK_RGA>;
>> + clock-names = "aclk", "hclk", "sclk";
>> + resets = <&cru SRST_RGA>, <&cru SRST_RGA_A>, <&cru
>> SRST_RGA_H>;
>> + reset-names = "core", "axi", "ahb";
>> + status = "disabled";
>> + };
>> +
>> vpu_mmu: iommu@20020800 {
>> compatible = "rockchip,iommu";
>> reg = <0x20020800 0x100>;
>> --
>> 2.11.0
^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH v2 2/2] ARM: dts: rockchip: enable rga for rk3229-xms6
2020-01-21 20:11 ` [PATCH v2 0/2] Add rga to rk322x device tree Justin Swartz
2020-01-21 20:11 ` [PATCH v2 1/2] ARM: dts: rockchip: add rga node for rk322x Justin Swartz
@ 2020-01-21 20:11 ` Justin Swartz
1 sibling, 0 replies; 12+ messages in thread
From: Justin Swartz @ 2020-01-21 20:11 UTC (permalink / raw)
To: Heiko Stuebner, Rob Herring, Mark Rutland
Cc: Justin Swartz, linux-arm-kernel, linux-rockchip, devicetree,
linux-kernel
Enable RGA for Mecer Xtreme Mini S6.
Signed-off-by: Justin Swartz <justin.swartz@risingedge.co.za>
---
arch/arm/boot/dts/rk3229-xms6.dts | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/arch/arm/boot/dts/rk3229-xms6.dts b/arch/arm/boot/dts/rk3229-xms6.dts
index 679fc2b00..894f64a4a 100644
--- a/arch/arm/boot/dts/rk3229-xms6.dts
+++ b/arch/arm/boot/dts/rk3229-xms6.dts
@@ -202,6 +202,10 @@
status = "okay";
};
+&rga {
+ status = "okay";
+};
+
&sdmmc {
cap-mmc-highspeed;
disable-wp;
--
2.11.0
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH v3 0/2] Add rga to rk322x device tree
[not found] <20200120194158.25357-1-justin.swartz@risingedge.co.za>
` (3 preceding siblings ...)
2020-01-21 20:11 ` [PATCH v2 0/2] Add rga to rk322x device tree Justin Swartz
@ 2020-01-21 22:02 ` Justin Swartz
2020-01-21 22:02 ` [PATCH v3 1/2] ARM: dts: rockchip: add rga node for rk322x Justin Swartz
` (2 more replies)
4 siblings, 3 replies; 12+ messages in thread
From: Justin Swartz @ 2020-01-21 22:02 UTC (permalink / raw)
To: Heiko Stuebner, Rob Herring, Mark Rutland
Cc: Justin Swartz, linux-arm-kernel, linux-rockchip, devicetree,
linux-kernel
This patchset aims to enable use of Rockchip's RGA, a 2D raster
graphic acceleration unit, on rk322x based devices.
Changed in v3:
- Relocate rga node to the correct position in rk322x.dtsi, as
indicated by Johan Jonker.
Changes in v2:
- Remove unnecessary "rockchip,rk3228-rga" device tree compatibility
string patch, as advised by Ezequiel Garcia.
- Use both "rockchip,rk3228-rga" and "rockchip,rk3288-rga" in the
rga node's compatibility property, as suggested by Heiko Stuebner.
Justin Swartz (2):
ARM: dts: rockchip: add rga node for rk322x
ARM: dts: rockchip: enable rga for rk3229-xms6
arch/arm/boot/dts/rk3229-xms6.dts | 4 ++++
arch/arm/boot/dts/rk322x.dtsi | 11 +++++++++++
2 files changed, 15 insertions(+)
--
2.11.0
^ permalink raw reply [flat|nested] 12+ messages in thread* [PATCH v3 1/2] ARM: dts: rockchip: add rga node for rk322x
2020-01-21 22:02 ` [PATCH v3 0/2] Add rga to rk322x device tree Justin Swartz
@ 2020-01-21 22:02 ` Justin Swartz
2020-01-21 22:02 ` [PATCH v3 2/2] ARM: dts: rockchip: enable rga for rk3229-xms6 Justin Swartz
2020-02-03 10:36 ` [PATCH v3 0/2] Add rga to rk322x device tree Rob Herring
2 siblings, 0 replies; 12+ messages in thread
From: Justin Swartz @ 2020-01-21 22:02 UTC (permalink / raw)
To: Heiko Stuebner, Rob Herring, Mark Rutland
Cc: Justin Swartz, linux-arm-kernel, linux-rockchip, devicetree,
linux-kernel
Add a node to define the presence of RGA, a 2D raster
graphic acceleration unit.
Signed-off-by: Justin Swartz <justin.swartz@risingedge.co.za>
---
arch/arm/boot/dts/rk322x.dtsi | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/arch/arm/boot/dts/rk322x.dtsi b/arch/arm/boot/dts/rk322x.dtsi
index 340ed6ccb..29d50bebc 100644
--- a/arch/arm/boot/dts/rk322x.dtsi
+++ b/arch/arm/boot/dts/rk322x.dtsi
@@ -621,6 +621,17 @@
status = "disabled";
};
+ rga: rga@20060000 {
+ compatible = "rockchip,rk3228-rga", "rockchip,rk3288-rga";
+ reg = <0x20060000 0x1000>;
+ interrupts = <GIC_SPI 33 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&cru ACLK_RGA>, <&cru HCLK_RGA>, <&cru SCLK_RGA>;
+ clock-names = "aclk", "hclk", "sclk";
+ resets = <&cru SRST_RGA>, <&cru SRST_RGA_A>, <&cru SRST_RGA_H>;
+ reset-names = "core", "axi", "ahb";
+ status = "disabled";
+ };
+
iep_mmu: iommu@20070800 {
compatible = "rockchip,iommu";
reg = <0x20070800 0x100>;
--
2.11.0
^ permalink raw reply related [flat|nested] 12+ messages in thread* [PATCH v3 2/2] ARM: dts: rockchip: enable rga for rk3229-xms6
2020-01-21 22:02 ` [PATCH v3 0/2] Add rga to rk322x device tree Justin Swartz
2020-01-21 22:02 ` [PATCH v3 1/2] ARM: dts: rockchip: add rga node for rk322x Justin Swartz
@ 2020-01-21 22:02 ` Justin Swartz
2020-02-03 10:36 ` [PATCH v3 0/2] Add rga to rk322x device tree Rob Herring
2 siblings, 0 replies; 12+ messages in thread
From: Justin Swartz @ 2020-01-21 22:02 UTC (permalink / raw)
To: Heiko Stuebner, Rob Herring, Mark Rutland
Cc: Justin Swartz, linux-arm-kernel, linux-rockchip, devicetree,
linux-kernel
Enable RGA for Mecer Xtreme Mini S6.
Signed-off-by: Justin Swartz <justin.swartz@risingedge.co.za>
---
arch/arm/boot/dts/rk3229-xms6.dts | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/arch/arm/boot/dts/rk3229-xms6.dts b/arch/arm/boot/dts/rk3229-xms6.dts
index 679fc2b00..894f64a4a 100644
--- a/arch/arm/boot/dts/rk3229-xms6.dts
+++ b/arch/arm/boot/dts/rk3229-xms6.dts
@@ -202,6 +202,10 @@
status = "okay";
};
+&rga {
+ status = "okay";
+};
+
&sdmmc {
cap-mmc-highspeed;
disable-wp;
--
2.11.0
^ permalink raw reply related [flat|nested] 12+ messages in thread* Re: [PATCH v3 0/2] Add rga to rk322x device tree
2020-01-21 22:02 ` [PATCH v3 0/2] Add rga to rk322x device tree Justin Swartz
2020-01-21 22:02 ` [PATCH v3 1/2] ARM: dts: rockchip: add rga node for rk322x Justin Swartz
2020-01-21 22:02 ` [PATCH v3 2/2] ARM: dts: rockchip: enable rga for rk3229-xms6 Justin Swartz
@ 2020-02-03 10:36 ` Rob Herring
2 siblings, 0 replies; 12+ messages in thread
From: Rob Herring @ 2020-02-03 10:36 UTC (permalink / raw)
To: Justin Swartz
Cc: Heiko Stuebner, Mark Rutland, linux-arm-kernel, linux-rockchip,
devicetree, linux-kernel
On Tue, Jan 21, 2020 at 10:02:39PM +0000, Justin Swartz wrote:
> This patchset aims to enable use of Rockchip's RGA, a 2D raster
> graphic acceleration unit, on rk322x based devices.
>
> Changed in v3:
> - Relocate rga node to the correct position in rk322x.dtsi, as
> indicated by Johan Jonker.
>
> Changes in v2:
> - Remove unnecessary "rockchip,rk3228-rga" device tree compatibility
> string patch, as advised by Ezequiel Garcia.
Why's that? You're using the string still, it needs to be documented.
Rob
^ permalink raw reply [flat|nested] 12+ messages in thread