From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8A34FC35247 for ; Mon, 3 Feb 2020 17:35:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5CC132087E for ; Mon, 3 Feb 2020 17:35:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="T3/dlEbs" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727958AbgBCRfD (ORCPT ); Mon, 3 Feb 2020 12:35:03 -0500 Received: from mail-pf1-f196.google.com ([209.85.210.196]:35830 "EHLO mail-pf1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727942AbgBCRfD (ORCPT ); Mon, 3 Feb 2020 12:35:03 -0500 Received: by mail-pf1-f196.google.com with SMTP id y73so7943427pfg.2 for ; Mon, 03 Feb 2020 09:35:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=/2GnHgYEod44KNh5O907qr0Dr3tZt31Xm1Pio0+BUtU=; b=T3/dlEbss69QCdMNMPoph/AGjrLOJywnCDQUDC2crHYwLXIj8gbLjE1Mhh/0AS4Q5i 1AN7ohRk8xc5mWmOgUpM/XP9ETNjwFHjATcQYoN/y6IcTcbeIIKbLoOOtplCNuIlIw6C lt1Al/0QHs4pwiYD+e5S5S6DGygimX8cRV8E3qtmVn0c98qAteldebnd1oAOpSZWRLfg X4hvg2OAdCgQIqlJrR5SZ3IxW3t0aZSQGeM7PWTCFvoCLYqq0Cq4KzyCL5katLBoLA+4 hc+utViSzEbgLYkXa9iZmRJ+ZawjFNhlcJ0L48IDNx6YU3dp1OVy3uPvyrzXLMKfamqU h+qQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=/2GnHgYEod44KNh5O907qr0Dr3tZt31Xm1Pio0+BUtU=; b=DysCtJyE5kUm1QMK2cp0/i1s5mtaEDg65p1+27Pxl1UK7QbsG+Zm88mSOALCUG+sEz mzNJ/5GBTigH8k3TE8y0Y2tfhzOdd5jSHZiV8xHV4p99xte1s7jV/M+lSZY5+nE/6X2p ++ZlEQntev//SMlpkkG0myFgPUfrQEMQeeiYXdsz3Bv4c9Rf/lLXma0faiAVKSTW+ZmF jjHMOjlpzB36SVQLyM7wvbyGszlNBJpm/45zkhYr8/pFdRFktu0wPKAPsINncN0nsFkv nDPlw3EMaLjW7DBXmh8ZdsEJaQGs4XzHcQNRbPE7NrFuj+uyfKVRGmzUPPdece+8MWUH spWA== X-Gm-Message-State: APjAAAWuGYDiJqqeC+NEs9IOtMPgZEVfPwZ/dGWa/EV8Km7qJ06y+eYL cMWEoYB48yaMVfbADkBo2iEYTg== X-Google-Smtp-Source: APXvYqwHjAZO5+aiba+vTO0oc2CApTMEtmAA4xfo4oGHCw/dpaiKyNl42GAFhoYlHtXUvoagPsmxZg== X-Received: by 2002:a63:7e58:: with SMTP id o24mr25705879pgn.214.1580751302915; Mon, 03 Feb 2020 09:35:02 -0800 (PST) Received: from builder (104-188-17-28.lightspeed.sndgca.sbcglobal.net. [104.188.17.28]) by smtp.gmail.com with ESMTPSA id s18sm700055pgn.34.2020.02.03.09.35.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Feb 2020 09:35:02 -0800 (PST) Date: Mon, 3 Feb 2020 09:35:00 -0800 From: Bjorn Andersson To: Rakesh Pillai Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org Subject: Re: [PATCH v5] arm64: dts: qcom: sc7180: Add WCN3990 WLAN module device node Message-ID: <20200203173500.GB3948@builder> References: <1580281223-2759-1-git-send-email-pillair@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1580281223-2759-1-git-send-email-pillair@codeaurora.org> User-Agent: Mutt/1.12.2 (2019-09-21) Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Tue 28 Jan 23:00 PST 2020, Rakesh Pillai wrote: > Add device node for the ath10k SNOC platform driver probe > and add resources required for WCN3990 on sc7180 soc. > > Signed-off-by: Rakesh Pillai > --- > arch/arm64/boot/dts/qcom/sc7180-idp.dts | 5 +++++ > arch/arm64/boot/dts/qcom/sc7180.dtsi | 28 ++++++++++++++++++++++++++++ > 2 files changed, 33 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sc7180-idp.dts b/arch/arm64/boot/dts/qcom/sc7180-idp.dts > index 388f50a..167f68ac 100644 > --- a/arch/arm64/boot/dts/qcom/sc7180-idp.dts > +++ b/arch/arm64/boot/dts/qcom/sc7180-idp.dts > @@ -287,6 +287,11 @@ > vdda-pll-supply = <&vreg_l4a_0p8>; > }; > > +&wifi { > + status = "okay"; > + qcom,msa-fixed-perm; > +}; > + > /* PINCTRL - additions to nodes defined in sc7180.dtsi */ > > &qspi_clk { > diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qcom/sc7180.dtsi > index 8011c5f..0a00c94 100644 > --- a/arch/arm64/boot/dts/qcom/sc7180.dtsi > +++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi > @@ -75,6 +75,12 @@ > reg = <0x0 0x80900000 0x0 0x200000>; > no-map; > }; > + > + wlan_fw_mem: memory@93900000 { > + compatible = "removed-dma-pool"; Sorry for not spotting this earlier, the "removed-dma-pool" compatible is a downstream thing and isn't defined upstream. > + no-map; > + reg = <0 0x93900000 0 0x200000>; If you swap the order of no-map and reg in this node it will look like all the others. Apart from that the patch looks good. Regards, Bjorn > + }; > }; > > cpus { > @@ -1490,6 +1496,28 @@ > > #freq-domain-cells = <1>; > }; > + > + wifi: wifi@18800000 { > + compatible = "qcom,wcn3990-wifi"; > + reg = <0 0x18800000 0 0x800000>; > + reg-names = "membase"; > + iommus = <&apps_smmu 0xc0 0x1>; > + interrupts = > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + ; > + memory-region = <&wlan_fw_mem>; > + status = "disabled"; > + }; > }; > > thermal-zones { > -- > 2.7.4 >