From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DE7E2C352A1 for ; Sat, 8 Feb 2020 16:35:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B7B1022464 for ; Sat, 8 Feb 2020 16:35:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1581179703; bh=e2fw8bf8Gyx/i3xoGvZFehCnIvBaBc/lzwGV+T5ccDM=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=09rvTXZ2A/r6LZUdJ6uAfSA19dhpW6MQntrWMIqbC5DKEpLUj4yYarZHbZ/TphZJk Wystz3JJ1Cle14kyQS5FnDveCLsMYIlgoDxsdeWKmS4ZGEeiIARuxuBi5lGQrsOGQG Ueg/IpWHKewyFJUcIhUScV9DE6rV1n/ub2NhwcOw= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727341AbgBHQfD (ORCPT ); Sat, 8 Feb 2020 11:35:03 -0500 Received: from mail.kernel.org ([198.145.29.99]:41404 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727303AbgBHQfC (ORCPT ); Sat, 8 Feb 2020 11:35:02 -0500 Received: from archlinux (cpc149474-cmbg20-2-0-cust94.5-4.cable.virginm.net [82.4.196.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 25ED42082E; Sat, 8 Feb 2020 16:35:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1581179701; bh=e2fw8bf8Gyx/i3xoGvZFehCnIvBaBc/lzwGV+T5ccDM=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=dOWGw1VJrDAMrr/3bALrxUMDLzJMkkBi20/Zu8dI6VRJ9iTv8KlcIrs36AI7Mk2si uXxovVBiz6P1KGnnQv/ME8F3+GtXq6qaKhOxN1s8YIF2tV/2bXBfM+4OduMDPHUqOe jjzJt+3TZqYa5iPjrNs46qSZgiNJIQ1hb4IKV4t4= Date: Sat, 8 Feb 2020 16:34:58 +0000 From: Jonathan Cameron To: Matt Ranostay Cc: linux-iio@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH v4 3/3] dt-bindings: iio: chemical: consolidate atlas-sensor docs Message-ID: <20200208163458.15ec07a4@archlinux> In-Reply-To: <20200206061332.20427-4-matt.ranostay@konsulko.com> References: <20200206061332.20427-1-matt.ranostay@konsulko.com> <20200206061332.20427-4-matt.ranostay@konsulko.com> X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Wed, 5 Feb 2020 22:13:32 -0800 Matt Ranostay wrote: > Since Atlas Scientific device support only varies from the compatible > string is ideal all the respective docs are merged into a single doc > named atlas,sensor.yaml > > Cc: devicetree@vger.kernel.org > Signed-off-by: Matt Ranostay > --- > .../bindings/iio/chemical/atlas,ec-sm.txt | 21 -------- > .../bindings/iio/chemical/atlas,orp-sm.txt | 21 -------- > .../bindings/iio/chemical/atlas,ph-sm.txt | 21 -------- > .../bindings/iio/chemical/atlas,sensor.yaml | 53 +++++++++++++++++++ > 4 files changed, 53 insertions(+), 63 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/iio/chemical/atlas,ec-sm.txt > delete mode 100644 Documentation/devicetree/bindings/iio/chemical/atlas,orp-sm.txt > delete mode 100644 Documentation/devicetree/bindings/iio/chemical/atlas,ph-sm.txt > create mode 100644 Documentation/devicetree/bindings/iio/chemical/atlas,sensor.yaml > > diff --git a/Documentation/devicetree/bindings/iio/chemical/atlas,ec-sm.txt b/Documentation/devicetree/bindings/iio/chemical/atlas,ec-sm.txt > deleted file mode 100644 > index f4320595b851..000000000000 > --- a/Documentation/devicetree/bindings/iio/chemical/atlas,ec-sm.txt > +++ /dev/null > @@ -1,21 +0,0 @@ > -* Atlas Scientific EC-SM OEM sensor > - > -http://www.atlas-scientific.com/_files/_datasheets/_oem/EC_oem_datasheet.pdf > - > -Required properties: > - > - - compatible: must be "atlas,ec-sm" > - - reg: the I2C address of the sensor > - - interrupts: the sole interrupt generated by the device > - > - Refer to interrupt-controller/interrupts.txt for generic interrupt client > - node bindings. > - > -Example: > - > -atlas@64 { > - compatible = "atlas,ec-sm"; > - reg = <0x64>; > - interrupt-parent = <&gpio1>; > - interrupts = <16 2>; > -}; > diff --git a/Documentation/devicetree/bindings/iio/chemical/atlas,orp-sm.txt b/Documentation/devicetree/bindings/iio/chemical/atlas,orp-sm.txt > deleted file mode 100644 > index af1f5a9aa4da..000000000000 > --- a/Documentation/devicetree/bindings/iio/chemical/atlas,orp-sm.txt > +++ /dev/null > @@ -1,21 +0,0 @@ > -* Atlas Scientific ORP-SM OEM sensor > - > -https://www.atlas-scientific.com/_files/_datasheets/_oem/ORP_oem_datasheet.pdf > - > -Required properties: > - > - - compatible: must be "atlas,orp-sm" > - - reg: the I2C address of the sensor > - - interrupts: the sole interrupt generated by the device > - > - Refer to interrupt-controller/interrupts.txt for generic interrupt client > - node bindings. > - > -Example: > - > -atlas@66 { > - compatible = "atlas,orp-sm"; > - reg = <0x66>; > - interrupt-parent = <&gpio1>; > - interrupts = <16 2>; > -}; > diff --git a/Documentation/devicetree/bindings/iio/chemical/atlas,ph-sm.txt b/Documentation/devicetree/bindings/iio/chemical/atlas,ph-sm.txt > deleted file mode 100644 > index 79d90f060327..000000000000 > --- a/Documentation/devicetree/bindings/iio/chemical/atlas,ph-sm.txt > +++ /dev/null > @@ -1,21 +0,0 @@ > -* Atlas Scientific pH-SM OEM sensor > - > -http://www.atlas-scientific.com/_files/_datasheets/_oem/pH_oem_datasheet.pdf > - > -Required properties: > - > - - compatible: must be "atlas,ph-sm" > - - reg: the I2C address of the sensor > - - interrupts: the sole interrupt generated by the device > - > - Refer to interrupt-controller/interrupts.txt for generic interrupt client > - node bindings. > - > -Example: > - > -atlas@65 { > - compatible = "atlas,ph-sm"; > - reg = <0x65>; > - interrupt-parent = <&gpio1>; > - interrupts = <16 2>; > -}; > diff --git a/Documentation/devicetree/bindings/iio/chemical/atlas,sensor.yaml b/Documentation/devicetree/bindings/iio/chemical/atlas,sensor.yaml > new file mode 100644 > index 000000000000..1b0c476838d1 > --- /dev/null > +++ b/Documentation/devicetree/bindings/iio/chemical/atlas,sensor.yaml > @@ -0,0 +1,53 @@ > +# SPDX-License-Identifier: GPL-2.0 Given this is entirely your binding, would you mind using the dual license with GPL and BSD that is preferred for new bindings? Otherwise looks good to me. Jonathan > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/iio/chemical/atlas,sensor.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Atlas Scientific OEM sensors > + > +maintainers: > + - Matt Ranostay > + > +description: | > + Atlas Scientific OEM sensors connected via I2C > + > + Datasheets: > + http://www.atlas-scientific.com/_files/_datasheets/_oem/DO_oem_datasheet.pdf > + http://www.atlas-scientific.com/_files/_datasheets/_oem/EC_oem_datasheet.pdf > + http://www.atlas-scientific.com/_files/_datasheets/_oem/ORP_oem_datasheet.pdf > + http://www.atlas-scientific.com/_files/_datasheets/_oem/pH_oem_datasheet.pdf > + > +properties: > + compatible: > + enum: > + - atlas,do-sm > + - atlas,ec-sm > + - atlas,orp-sm > + - atlas,ph-sm > + > + reg: > + maxItems: 1 > + > + interrupts: > + maxItems: 1 > + > +required: > + - compatible > + - reg > + > +additionalProperties: false > + > +examples: > + - | > + i2c { > + #address-cells = <1>; > + #size-cells = <0>; > + > + atlas@66 { > + compatible = "atlas,orp-sm"; > + reg = <0x66>; > + interrupt-parent = <&gpio1>; > + interrupts = <16 2>; > + }; > + };