Re: [PATCH 5/9] ASoC: meson: aiu: add hdmi codec control support

Mark Brown
2020-02-13T18:22:03Z

[-- Attachment #1: Type: text/plain, Size: 819 bytes --]

On Thu, Feb 13, 2020 at 04:51:55PM +0100, Jerome Brunet wrote:

> +int aiu_add_component(struct device *dev,
> + const struct snd_soc_component_driver *component_driver,
> + struct snd_soc_dai_driver *dai_drv,
> + int num_dai,
> + const char *debugfs_prefix)
> +{
> + struct snd_soc_component *component;
> +
> + component = devm_kzalloc(dev, sizeof(*component), GFP_KERNEL);
> + if (!component)
> + return -ENOMEM;
> +
> +#ifdef CONFIG_DEBUG_FS
> + component->debugfs_prefix = debugfs_prefix;
> +#endif

You really shouldn't be doing this as it could conflict with something
the machine driver wants to do however it's probably not going to be an
issue in practice as it's not like there's going to be multiple SoCs in
the card at once and if there were there'd doubltess be other issues.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]