From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1EEBCC2BA83 for ; Fri, 14 Feb 2020 09:35:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E5B06222C4 for ; Fri, 14 Feb 2020 09:35:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="GoEjXRGH" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729098AbgBNJfM (ORCPT ); Fri, 14 Feb 2020 04:35:12 -0500 Received: from mail-pf1-f193.google.com ([209.85.210.193]:46405 "EHLO mail-pf1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729064AbgBNJfM (ORCPT ); Fri, 14 Feb 2020 04:35:12 -0500 Received: by mail-pf1-f193.google.com with SMTP id k29so4596631pfp.13 for ; Fri, 14 Feb 2020 01:35:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=5AfLEWxBfNqD1QkilGzCQL+klQ2n6nhzMgLjS7kpjJM=; b=GoEjXRGHToaAgFkeLpViY1gsJSUIEVFtb8QW+MOKy9T8+kP7xEFTsFYvjUW6MSs7gy o28Rzuk0lUdIq/2gWktTi8aG6FVSe5Fp1qD6uMY3WpVJREQ0h3/avtmmbfeIwMUFGd43 5rx0TuSgzQZHI3TlPFC52tzrHGnYIgDgvMgvA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=5AfLEWxBfNqD1QkilGzCQL+klQ2n6nhzMgLjS7kpjJM=; b=t3oGFme3+o1BOalT+6sa2yisHdE1KFMr2QHtLOwF9lwQpHOMyHf7VJo5Ozi8TB9B/S AJQB3IRVQWW3/6ML3hsuiNaJ5Wd/STAWcecDzfVRIYVaHlD1tGeJZMjQQADL0jjOXRdt LEiqVLqIkeq0S62qcYfGpJGfoiCwCJrJ4jbNlab7rDig/l8sPaSkvJihjS22fq9Uu2pe WS9jS2uEzDSpEFZfzsCUZdtazXE+v0+6TLX6KfpNBAd8YtqskEQYjl93Vo9XavBbrA+c +fps2JT5QQBVrABl+dEFBy9NbgSmdp6MLCO6hCdarYoQHmHai+ZC+k8Qh27Ubwz8aa0N Rqyw== X-Gm-Message-State: APjAAAU+a3fo3H+6M+J1DvisCWR9TCWR893IZScl7/621KAh+YIqw4TW SdkBh1Qn+Z6XiPhalGSHCAN6Xqwa9LIZcA== X-Google-Smtp-Source: APXvYqzWsScMU1xLX4fTpri3lhL7mpabTPnY7iU6UbbEijI0fSi9fuMBHpf+qZeK5MxPv57X50roQA== X-Received: by 2002:a65:4486:: with SMTP id l6mr2326605pgq.1.1581672911556; Fri, 14 Feb 2020 01:35:11 -0800 (PST) Received: from chromium.org ([2401:fa00:8f:203:f5fe:2a5e:f953:c0ed]) by smtp.gmail.com with ESMTPSA id w11sm6067926pgh.5.2020.02.14.01.35.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 14 Feb 2020 01:35:10 -0800 (PST) Date: Fri, 14 Feb 2020 18:35:06 +0900 From: Tomasz Figa To: Xia Jiang Cc: Hans Verkuil , Mauro Carvalho Chehab , Rob Herring , Matthias Brugger , Rick Chang , linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Marek Szyprowski , srv_heupstream@mediatek.com Subject: Re: [PATCH v6 1/5] media: platform: Fix jpeg dec driver bug and improve code quality Message-ID: <20200214093506.GA193786@chromium.org> References: <20200121095320.32258-1-xia.jiang@mediatek.com> <20200121095320.32258-2-xia.jiang@mediatek.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200121095320.32258-2-xia.jiang@mediatek.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Xia, On Tue, Jan 21, 2020 at 05:53:17PM +0800, Xia Jiang wrote: > Fix v4l2-compliance test bug and improve code quality of jpeg decode > driver, because the jpeg encode driver will base on it. > > Signed-off-by: Xia Jiang > --- > v6: alignment 'MTK_JPEG_DCTSIZE' match open parenthesis. > > v5: Use clamp()to replace mtk_jpeg_bound_align_image() and round_up() > to replace mtk_jpeg_align(). > Get correct compose value in mtk_jpeg_selection(). > Cancel spin lock and unlock operation in device run function. > Change register offset hex numberals from upercase to lowercase. > > v4: new add patch for v4l2-compliance test bug fix. Thanks for the patch. The changes look good to me, but each of the unrelated changes should be split into its own patch, with proper explanation in its commit message. Especially the ones that introduce behavior changes, such as the S_SELECTION or locking change. Also please see one comment inline. [snip] > @@ -801,7 +778,6 @@ static void mtk_jpeg_device_run(void *priv) > struct mtk_jpeg_dev *jpeg = ctx->jpeg; > struct vb2_v4l2_buffer *src_buf, *dst_buf; > enum vb2_buffer_state buf_state = VB2_BUF_STATE_ERROR; > - unsigned long flags; > struct mtk_jpeg_src_buf *jpeg_src_buf; > struct mtk_jpeg_bs bs; > struct mtk_jpeg_fb fb; > @@ -829,13 +805,11 @@ static void mtk_jpeg_device_run(void *priv) > if (mtk_jpeg_set_dec_dst(ctx, &jpeg_src_buf->dec_param, &dst_buf->vb2_buf, &fb)) > goto dec_end; > > - spin_lock_irqsave(&jpeg->hw_lock, flags); Why is it safe to remove the locking here? > mtk_jpeg_dec_reset(jpeg->dec_reg_base); > mtk_jpeg_dec_set_config(jpeg->dec_reg_base, > &jpeg_src_buf->dec_param, &bs, &fb); > > mtk_jpeg_dec_start(jpeg->dec_reg_base); > - spin_unlock_irqrestore(&jpeg->hw_lock, flags); > return; > > dec_end: Best regards, Tomasz