Re: [PATCH v8 20/22] clk: tegra: Remove tegra_pmc_clk_init along with clk ids

Thierry Reding
2020-02-17T09:55:55Z

[-- Attachment #1: Type: text/plain, Size: 1755 bytes --]

On Mon, Jan 13, 2020 at 11:24:25PM -0800, Sowjanya Komatineni wrote:
> Current Tegra clock driver registers PMC clocks clk_out_1, clk_out_2,
> clk_out_3 and 32KHz blink output in tegra_pmc_init() which does direct
> PMC register access during clk_ops and these PMC register read and write
> access will not happen when PMC is in secure mode.
>
> Any direct PMC register access from non-secure world will not go
> through.
>
> All the PMC clocks are moved to Tegra PMC driver with PMC as a clock
> provider.
>
> This patch removes tegra_pmc_clk_init along with corresponding clk ids
> from Tegra clock driver.
>
> Tested-by: Dmitry Osipenko <digetx@gmail.com>
> Reviewed-by: Dmitry Osipenko <digetx@gmail.com>
> Signed-off-by: Sowjanya Komatineni <skomatineni@nvidia.com>
> ---
> drivers/clk/tegra/Makefile | 1 -
> drivers/clk/tegra/clk-id.h | 7 ---
> drivers/clk/tegra/clk-tegra-pmc.c | 122 --------------------------------------
> drivers/clk/tegra/clk-tegra114.c | 17 +-----
> drivers/clk/tegra/clk-tegra124.c | 33 ++++-------
> drivers/clk/tegra/clk-tegra20.c | 4 --
> drivers/clk/tegra/clk-tegra210.c | 17 +-----
> drivers/clk/tegra/clk-tegra30.c | 18 +-----
> drivers/clk/tegra/clk.h | 1 -
> 9 files changed, 19 insertions(+), 201 deletions(-)
> delete mode 100644 drivers/clk/tegra/clk-tegra-pmc.c

I think it's best to defer this patch (along with 21 and 22) until all
the others have been merged to make sure we don't regress. Other than
that it should be fine to apply the others in any order, right? Well,
maybe not any order, but at least the ASoC patches should be able to
go through the ASoC tree without impacting functionality, right?

Thierry

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]