From: Andrew Lunn <andrew@lunn.ch>
To: Vladimir Oltean <olteanv@gmail.com>
Cc: shawnguo@kernel.org, robh+dt@kernel.org, mark.rutland@arm.com,
devicetree@vger.kernel.org, vivien.didelot@gmail.com,
f.fainelli@gmail.com, davem@davemloft.net,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Claudiu Manoil <claudiu.manoil@nxp.com>
Subject: Re: [PATCH devicetree 3/4] arm64: dts: fsl: ls1028a: add node for Felix switch
Date: Mon, 17 Feb 2020 16:29:12 +0100 [thread overview]
Message-ID: <20200217152912.GE31084@lunn.ch> (raw)
In-Reply-To: <20200217144414.409-4-olteanv@gmail.com>
Hi Vladimir
> + /* Internal port with DSA tagging */
> + mscc_felix_port4: port@4 {
> + reg = <4>;
> + phy-mode = "gmii";
Is it really using gmii? Often in SoC connections use something else,
and phy-mode = "internal" is more appropriate.
> + ethernet = <&enetc_port2>;
> +
> + fixed-link {
> + speed = <2500>;
> + full-duplex;
> + };
gmii and 2500 also don't really go together.
Andrew
next prev parent reply other threads:[~2020-02-17 15:29 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-17 14:44 [PATCH devicetree 0/4] DT bindings for Felix DSA switch on LS1028A Vladimir Oltean
2020-02-17 14:44 ` [PATCH devicetree 1/4] arm64: dts: fsl: ls1028a: delete extraneous #interrupt-cells for ENETC RCIE Vladimir Oltean
2020-02-17 14:44 ` [PATCH devicetree 2/4] dt-bindings: net: dsa: ocelot: document the vsc9959 core Vladimir Oltean
2020-02-17 14:44 ` [PATCH devicetree 3/4] arm64: dts: fsl: ls1028a: add node for Felix switch Vladimir Oltean
2020-02-17 15:29 ` Andrew Lunn [this message]
2020-02-17 15:33 ` Vladimir Oltean
2020-02-17 17:24 ` Vladimir Oltean
2020-02-18 23:15 ` Vladimir Oltean
2020-02-17 14:44 ` [PATCH devicetree 4/4] arm64: dts: fsl: ls1028a: enable switch PHYs on RDB Vladimir Oltean
2020-02-17 15:30 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200217152912.GE31084@lunn.ch \
--to=andrew@lunn.ch \
--cc=claudiu.manoil@nxp.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=robh+dt@kernel.org \
--cc=shawnguo@kernel.org \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).