* Re: [PATCH v5 2/2] Device tree bindings for TI HDC20x0 humidity and temperature sensors
2020-02-13 22:18 ` [PATCH v5 2/2] Device tree bindings for TI HDC20x0 humidity and temperature sensors Eugene Zalkonnikov
@ 2020-02-14 13:55 ` Jonathan Cameron
2020-02-18 20:19 ` Rob Herring
1 sibling, 0 replies; 3+ messages in thread
From: Jonathan Cameron @ 2020-02-14 13:55 UTC (permalink / raw)
To: Eugene Zalkonnikov
Cc: Rob Herring, Hartmut Knaack, Lars-Peter Clausen,
development@norphonic.com, linux-iio@vger.kernel.org,
Mark Rutland, devicetree@vger.kernel.org
On Thu, 13 Feb 2020 22:18:13 +0000
Eugene Zalkonnikov <ez@norphonic.com> wrote:
> Amended device tree bindings for the driver.
>
> Signed-off-by: Eugene Zaikonnikov <eugene.zaikonnikov@norphonic.com>
>
> diff -uprN linux-5.3.8/Documentation/devicetree/bindings/iio/humidity/ti,hdc2010.yaml linux-5.3.8_docs/Documentation/devicetree/bindings/iio/humidity/ti,hdc2010.yaml
> --- linux-5.3.8/Documentation/devicetree/bindings/iio/humidity/ti,hdc2010.yaml 1970-01-01 01:00:00.000000000 +0100
> +++ linux-5.3.8_docs/Documentation/devicetree/bindings/iio/humidity/ti,hdc2010.yaml 2020-02-12 14:28:42.562903814 +0100
> @@ -0,0 +1,43 @@
> +# SPDX-License-Identifier: (GPL-2.0-or-later OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/iio/humidity/hdc2010.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: HDC2010/HDC2080 humidity and temperature iio sensors
> +
> +maintainers:
> + - Eugene Zaikonnikov <eugene.zaikonnikov@norophonic.com>
> +
> +description: |
> + Relative humidity and tempereature sensors on I2C bus
> +
> + Datasheets are available at:
> + http://www.ti.com/product/HDC2010/datasheet
> + http://www.ti.com/product/HDC2080/datasheet
> +
> +properties:
> + compatible:
> + enum:
> + - ti,hdc2010
> + - ti,hdc2080
> +
> + vddd-supply:
Unusual to use 3 'd's
Seems to be vdd on the datasheet I looked at.
Otherwise this all looks fine.
thanks
Jonathan
> + description:
> + digital voltage regulator (see regulator/regulator.txt)
> + maxItems: 1
> +
> +required:
> + - compatible
> +
> +examples:
> + - |
> + i2c0 {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + hdc200x@40 {
> + compatible = "ti,hdc2010";
> + reg = <0x40>;
> + };
> + };
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH v5 2/2] Device tree bindings for TI HDC20x0 humidity and temperature sensors
2020-02-13 22:18 ` [PATCH v5 2/2] Device tree bindings for TI HDC20x0 humidity and temperature sensors Eugene Zalkonnikov
2020-02-14 13:55 ` Jonathan Cameron
@ 2020-02-18 20:19 ` Rob Herring
1 sibling, 0 replies; 3+ messages in thread
From: Rob Herring @ 2020-02-18 20:19 UTC (permalink / raw)
To: Eugene Zalkonnikov
Cc: Jonathan Cameron, Hartmut Knaack, Lars-Peter Clausen,
development@norphonic.com, linux-iio@vger.kernel.org,
Mark Rutland, devicetree@vger.kernel.org
On Thu, 13 Feb 2020 22:18:13 +0000, Eugene Zalkonnikov wrote:
>
> Amended device tree bindings for the driver.
>
> Signed-off-by: Eugene Zaikonnikov <eugene.zaikonnikov@norphonic.com>
>
> diff -uprN linux-5.3.8/Documentation/devicetree/bindings/iio/humidity/ti,hdc2010.yaml linux-5.3.8_docs/Documentation/devicetree/bindings/iio/humidity/ti,hdc2010.yaml
> --- linux-5.3.8/Documentation/devicetree/bindings/iio/humidity/ti,hdc2010.yaml 1970-01-01 01:00:00.000000000 +0100
> +++ linux-5.3.8_docs/Documentation/devicetree/bindings/iio/humidity/ti,hdc2010.yaml 2020-02-12 14:28:42.562903814 +0100
> @@ -0,0 +1,43 @@
> +# SPDX-License-Identifier: (GPL-2.0-or-later OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/iio/humidity/hdc2010.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: HDC2010/HDC2080 humidity and temperature iio sensors
> +
> +maintainers:
> + - Eugene Zaikonnikov <eugene.zaikonnikov@norophonic.com>
> +
> +description: |
> + Relative humidity and tempereature sensors on I2C bus
> +
> + Datasheets are available at:
> + http://www.ti.com/product/HDC2010/datasheet
> + http://www.ti.com/product/HDC2080/datasheet
> +
> +properties:
> + compatible:
> + enum:
> + - ti,hdc2010
> + - ti,hdc2080
> +
> + vddd-supply:
> + description:
> + digital voltage regulator (see regulator/regulator.txt)
> + maxItems: 1
> +
> +required:
> + - compatible
> +
> +examples:
> + - |
> + i2c0 {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + hdc200x@40 {
> + compatible = "ti,hdc2010";
> + reg = <0x40>;
> + };
> + };
>
My bot found errors running 'make dt_binding_check' on your patch:
Documentation/devicetree/bindings/iio/humidity/ti,hdc2010.yaml: $id: path/filename 'iio/humidity/hdc2010.yaml' doesn't match actual filename
Documentation/devicetree/bindings/Makefile:12: recipe for target 'Documentation/devicetree/bindings/iio/humidity/ti,hdc2010.example.dts' failed
make[1]: *** [Documentation/devicetree/bindings/iio/humidity/ti,hdc2010.example.dts] Error 1
Makefile:1263: recipe for target 'dt_binding_check' failed
make: *** [dt_binding_check] Error 2
See https://patchwork.ozlabs.org/patch/1237780
Please check and re-submit.
^ permalink raw reply [flat|nested] 3+ messages in thread