From: Rob Herring <robh@kernel.org>
To: Joe Perches <joe@perches.com>, Sam Ravnborg <sam@ravnborg.org>
Cc: devicetree@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: checkpatch - "DT binding docs and includes should be a separate patch"
Date: Tue, 18 Feb 2020 14:57:35 -0600 [thread overview]
Message-ID: <20200218205735.GA9953@bogus> (raw)
In-Reply-To: <0d0c4ad9e15ce696ad4b470d724fb0d1423f26c0.camel@perches.com>
On Sun, Feb 09, 2020 at 12:35:26AM -0800, Joe Perches wrote:
> On Sun, 2020-02-09 at 09:19 +0100, Sam Ravnborg wrote:
> > Hi Joe.
> >
> > The following warnings triggers on the patch below:
> >
> > c55d0a554843 (HEAD -> drm-misc-next) dt-bindings: panel: Convert orisetech,otm8009a to json-schema
> > -:15: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
> > #15:
> > deleted file mode 100644
> >
> > -:18: WARNING:DT_SPLIT_BINDING_PATCH: DT binding docs and includes should be a separate patch. See: Documentation/devicetree/bindings/submitting-patches.txt
> >
> > -:43: WARNING:DT_SPLIT_BINDING_PATCH: DT binding docs and includes should be a separate patch. See: Documentation/devicetree/bindings/submitting-patches.txt
> >
> > total: 0 errors, 3 warnings, 0 checks, 53 lines checked
> >
> > 1)
> > yaml files include maintainer information in the file.
> > I dunno if this replaces/overrules MAINTAINERS - so first warning may be
> > OK. Also because we delete a file it seems semi relevant.
> >
> > 2)
> > As the patch only touches files in Documentation/devicetree/bindings the
> > warning about a separate patch seems wrong.
>
> Rob Herring wrote that bit. He's now cc'd. lkml too.
Yeah, I'd noticed this, but haven't dug into how to fix it. Given it
mainly happens in these schema conversion patches, I haven't been to
worried about it. Just 3300 more conversions todo and it will be
"fixed".
> > But the general feedback - in this very special case - is that
> > checkpatch seems a bit too noisy.
> >
> > If we as a bonus could get a warning when new yaml files do not
> > use:
> > # SPDX-License-Identifier: (GPL-2.0-only or BSD-2-Clause)
> > That would be great.
>
> Submitted here:
>
> https://lkml.org/lkml/2020/1/29/292
The bigger review issue is to check the above license is what's used
(but not on conversions).
Rob
prev parent reply other threads:[~2020-02-18 20:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-09 8:19 checkpatch - "DT binding docs and includes should be a separate patch" Sam Ravnborg
2020-02-09 8:35 ` Joe Perches
2020-02-18 20:57 ` Rob Herring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200218205735.GA9953@bogus \
--to=robh@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).