From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 64B73C3404B for ; Tue, 18 Feb 2020 21:26:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3BDE921D56 for ; Tue, 18 Feb 2020 21:26:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1582061176; bh=HmXo1LB8OB9WHetBsej2WEnq6ZZ39GIT6ZFL4BTgvR4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=k5q56UOnDED32aEaqPZz0HIeyU5G+/fttH8sCZT66qD8yY1f/VSNfmA6Dow7s5PBN tgsScYQ8pYElUt3HTozdDJh1+iB9PudGWU1X6hWos8d4+VdBtDoQo72wgDNWA1zhTZ GMr9w9mIcsvrtlTBwg5apq3zQCxkBL06JpQfBLbw= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726648AbgBRV0M (ORCPT ); Tue, 18 Feb 2020 16:26:12 -0500 Received: from mail-oi1-f193.google.com ([209.85.167.193]:43762 "EHLO mail-oi1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726339AbgBRV0M (ORCPT ); Tue, 18 Feb 2020 16:26:12 -0500 Received: by mail-oi1-f193.google.com with SMTP id p125so21628764oif.10; Tue, 18 Feb 2020 13:26:12 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=FBPkXpeYhwlQjEm8h9p4qJHC0WNjgbFbJ3Ke8WGyPBM=; b=Rqgh2LWnOAPWjZ8KZl94JfvxtMHxu6vbYlVrPNWEsgs/AALWVNsh1NtJ5KrwOFWm1i NLim4Zcq0WJQkSHrLATBvI2mmSTjeUo3OvnKT+fL0niepXSbV/kd3hnGFZvLJ+53/FaP xLZUwd1R52xOB5xDF72l40ioriID9ov8XcF5Cqen+bvhEUtHy6d9f4o11zYYzg/YWh6s 18ipi9sdUShAgmm+GMvW01FO+/vFNie/Mll1i1n8eB1DvOAWGYasrtnJZxlXftQFlXwL qK1in00QK5wQJLCW7fYrUm/xbQwZk10H7IttL26VcFzwtA/0twAiY2bur5iLtYUav4Hi ArSA== X-Gm-Message-State: APjAAAWhwukuNfN/5Xyxzv9heQ34JG883/0wioVHAxV2f0iUSvBUfMus dZL9esWYdlFTV5prnDzFrA== X-Google-Smtp-Source: APXvYqz+09mjoyPzbo4w/ESpYhcZUDvhBc+W905MCab1uX/0MfjKD0RzIRARpXpes5JkXIfdeYENDw== X-Received: by 2002:aca:e106:: with SMTP id y6mr2629105oig.131.1582061171568; Tue, 18 Feb 2020 13:26:11 -0800 (PST) Received: from rob-hp-laptop (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.gmail.com with ESMTPSA id y22sm1756180otq.31.2020.02.18.13.26.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 Feb 2020 13:26:10 -0800 (PST) Received: (nullmailer pid 32562 invoked by uid 1000); Tue, 18 Feb 2020 21:26:09 -0000 Date: Tue, 18 Feb 2020 15:26:09 -0600 From: Rob Herring To: "H. Nikolaus Schaller" Cc: PrasannaKumar Muralidharan , Paul Cercueil , Mathieu Malaterre , Srinivas Kandagatla , Mark Rutland , Ralf Baechle , Paul Burton , Mauro Carvalho Chehab , "David S. Miller" , Greg Kroah-Hartman , Jonathan Cameron , Krzysztof Kozlowski , Kees Cook , Andi Kleen , Geert Uytterhoeven , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-mips@vger.kernel.org, letux-kernel@openphoenux.org, kernel@pyra-handheld.com Subject: Re: [RFC v4 2/6] Bindings: nvmem: add bindings for JZ4780 efuse Message-ID: <20200218212609.GA30081@bogus> References: <86b78db4d607e0bdda6def018bc7f73207ce82e8.1581958529.git.hns@goldelico.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <86b78db4d607e0bdda6def018bc7f73207ce82e8.1581958529.git.hns@goldelico.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Mon, Feb 17, 2020 at 05:55:26PM +0100, H. Nikolaus Schaller wrote: > From: PrasannaKumar Muralidharan > > This patch brings support for the JZ4780 efuse. Currently it only expose > a read only access to the entire 8K bits efuse memory. > > Tested-by: Mathieu Malaterre > Signed-off-by: PrasannaKumar Muralidharan > Signed-off-by: Mathieu Malaterre > Signed-off-by: H. Nikolaus Schaller > --- > .../bindings/nvmem/ingenic,jz4780-efuse.txt | 17 +++++++++++++++++ > 1 file changed, 17 insertions(+) > create mode 100644 Documentation/devicetree/bindings/nvmem/ingenic,jz4780-efuse.txt Please convert to a DT schema. > diff --git a/Documentation/devicetree/bindings/nvmem/ingenic,jz4780-efuse.txt b/Documentation/devicetree/bindings/nvmem/ingenic,jz4780-efuse.txt > new file mode 100644 > index 000000000000..339e74daa9a9 > --- /dev/null > +++ b/Documentation/devicetree/bindings/nvmem/ingenic,jz4780-efuse.txt > @@ -0,0 +1,17 @@ > +Ingenic JZ EFUSE driver bindings > + > +Required properties: > +- "compatible" Must be set to "ingenic,jz4780-efuse" > +- "reg" Register location and length > +- "clocks" Handle for the ahb clock for the efuse. > +- "clock-names" Must be "bus_clk" 'clk' is redundant. How about 'ahb'? > + > +Example: > + > +efuse: efuse@134100d0 { > + compatible = "ingenic,jz4780-efuse"; > + reg = <0x134100d0 0x2c>; > + > + clocks = <&cgu JZ4780_CLK_AHB2>; > + clock-names = "bus_clk"; > +}; > -- > 2.23.0 >