From: Vladimir Oltean <olteanv@gmail.com>
To: shawnguo@kernel.org, robh+dt@kernel.org, mark.rutland@arm.com,
devicetree@vger.kernel.org, davem@davemloft.net,
netdev@vger.kernel.org
Cc: andrew@lunn.ch, vivien.didelot@gmail.com, f.fainelli@gmail.com,
linux-kernel@vger.kernel.org
Subject: [PATCH v2 net-next/devicetree 1/5] arm64: dts: fsl: ls1028a: delete extraneous #interrupt-cells for ENETC RCIE
Date: Wed, 19 Feb 2020 17:12:55 +0200 [thread overview]
Message-ID: <20200219151259.14273-2-olteanv@gmail.com> (raw)
In-Reply-To: <20200219151259.14273-1-olteanv@gmail.com>
From: Vladimir Oltean <vladimir.oltean@nxp.com>
This specifier overrides the interrupt specifier with 3 cells from gic
(/interrupt-controller@6000000), but in fact ENETC is not an interrupt
controller, so the property is bogus.
Interrupts used by the children of the ENETC RCIE must use the full
3-cell specifier required by the GIC.
The issue has no functional consequence so there is no real reason to
port the patch to stable trees.
Fixes: 927d7f857542 ("arm64: dts: fsl: ls1028a: Add PCI IERC node and ENETC endpoints")
Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
---
Changes in v2:
None.
arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
index 0bf375ec959b..dfead691e509 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
+++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
@@ -683,7 +683,6 @@
reg = <0x01 0xf0000000 0x0 0x100000>;
#address-cells = <3>;
#size-cells = <2>;
- #interrupt-cells = <1>;
msi-parent = <&its>;
device_type = "pci";
bus-range = <0x0 0x0>;
--
2.17.1
next prev parent reply other threads:[~2020-02-19 15:13 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-19 15:12 [PATCH v2 net-next/devicetree 0/5] DT bindings for Felix DSA switch on LS1028A Vladimir Oltean
2020-02-19 15:12 ` Vladimir Oltean [this message]
2020-02-24 6:34 ` [PATCH v2 net-next/devicetree 1/5] arm64: dts: fsl: ls1028a: delete extraneous #interrupt-cells for ENETC RCIE Shawn Guo
2020-02-19 15:12 ` [PATCH v2 net-next/devicetree 2/5] net: dsa: felix: Use PHY_INTERFACE_MODE_INTERNAL instead of GMII Vladimir Oltean
2020-02-19 15:26 ` Andrew Lunn
2020-02-19 15:12 ` [PATCH v2 net-next/devicetree 3/5] dt-bindings: net: dsa: ocelot: document the vsc9959 core Vladimir Oltean
2020-02-19 15:27 ` Andrew Lunn
2020-02-22 11:28 ` Michael Walle
2020-02-22 12:33 ` Vladimir Oltean
2020-02-19 15:12 ` [PATCH v2 net-next/devicetree 4/5] arm64: dts: fsl: ls1028a: add node for Felix switch Vladimir Oltean
2020-02-22 11:38 ` Michael Walle
2020-02-22 12:25 ` Vladimir Oltean
2020-02-22 13:19 ` Michael Walle
2020-02-24 6:36 ` Shawn Guo
2020-02-19 15:12 ` [PATCH v2 net-next/devicetree 5/5] arm64: dts: fsl: ls1028a: enable switch PHYs on RDB Vladimir Oltean
2020-02-22 11:41 ` Michael Walle
2020-02-22 12:17 ` Vladimir Oltean
2020-02-24 6:39 ` Shawn Guo
2020-02-19 19:12 ` [PATCH v2 net-next/devicetree 0/5] DT bindings for Felix DSA switch on LS1028A David Miller
2020-02-22 13:33 ` Michael Walle
2020-02-24 6:31 ` Shawn Guo
2020-02-24 7:59 ` Vladimir Oltean
2020-02-24 8:48 ` Shawn Guo
2020-02-24 8:50 ` Vladimir Oltean
2020-02-24 8:51 ` Vladimir Oltean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200219151259.14273-2-olteanv@gmail.com \
--to=olteanv@gmail.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=netdev@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=shawnguo@kernel.org \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).