From: Rob Herring <robh@kernel.org>
To: Robin Murphy <robin.murphy@arm.com>
Cc: lgirdwood@gmail.com, broonie@kernel.org, heiko@sntech.de,
alsa-devel@alsa-project.org,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-rockchip@lists.infradead.org, pgwipeout@gmail.com
Subject: Re: [PATCH v2 1/3] ASoC: dt-bindings: Make RK3328 codec GPIO explicit
Date: Wed, 19 Feb 2020 15:38:30 -0600 [thread overview]
Message-ID: <20200219213830.GA15330@bogus> (raw)
In-Reply-To: <5f7a399dea8a9dedef57f6f99f0f6ab1c1fdc56a.1581376744.git.robin.murphy@arm.com>
On Tue, 18 Feb 2020 21:31:58 +0000, Robin Murphy wrote:
> Existing RK3328 codec drivers have overloaded the GRF phandle to assume
> implicit control of the limited-function GPIO_MUTE pin, which is usually
> used to enable an external audio line driver IC. Since this pin has a
> proper binding of its own (see gpio/rockchip,rk3328-grf-gpio.txt), make
> a GPIO explicit in the codec binding too. This will help avoid ambiguity
> on boards that use that pin for some other purpose.
>
> (and while touching the example, enforce the "don't include status" rule)
>
> Signed-off-by: Robin Murphy <robin.murphy@arm.com>
> ---
>
> v2: no change
>
> .../devicetree/bindings/sound/rockchip,rk3328-codec.txt | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
Acked-by: Rob Herring <robh@kernel.org>
next prev parent reply other threads:[~2020-02-19 21:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-18 21:31 [PATCH v2 0/3] Clean up RK3328 audio codec GPIO control Robin Murphy
2020-02-18 21:31 ` [PATCH v2 1/3] ASoC: dt-bindings: Make RK3328 codec GPIO explicit Robin Murphy
2020-02-19 21:38 ` Rob Herring [this message]
2020-02-18 21:31 ` [PATCH v2 2/3] ASoC: rockchip: Make RK3328 GPIO_MUTE control explicit Robin Murphy
2020-02-19 12:06 ` Mark Brown
2020-02-19 20:57 ` Applied "ASoC: rockchip: Make RK3328 GPIO_MUTE control explicit" to the asoc tree Mark Brown
2020-02-18 21:32 ` [PATCH v2 3/3] arm64: dts: rockchip: Describe RK3328 GPIO_MUTE users Robin Murphy
2020-02-28 12:48 ` Robin Murphy
2020-02-29 23:42 ` Heiko Stuebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200219213830.GA15330@bogus \
--to=robh@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=pgwipeout@gmail.com \
--cc=robin.murphy@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).