devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: jic23@kernel.org
Cc: linux-iio@vger.kernel.org, Mark Rutland <mark.rutland@arm.com>,
	devicetree@vger.kernel.org,
	Jonathan Cameron <Jonathan.Cameron@huawei.com>
Subject: Re: [PATCH] dt-bindings: iio: adc: max1363 etc i2c ADC binding conversion
Date: Wed, 19 Feb 2020 16:10:05 -0600	[thread overview]
Message-ID: <20200219221005.GA22158@bogus> (raw)
In-Reply-To: <20200208172312.467454-1-jic23@kernel.org>

On Sat, Feb 08, 2020 at 05:23:12PM +0000, jic23@kernel.org wrote:
> From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> 
> Split the binding in two to reflect the threshold monitor capabilities
> and hence interrupts vs the more straight forward parts that
> don't have this facility.
> 
> Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> ---
>  .../devicetree/bindings/iio/adc/max1363.txt   | 63 ---------------
>  .../bindings/iio/adc/maxim,max1238.yaml       | 76 +++++++++++++++++++
>  .../bindings/iio/adc/maxim,max1363.yaml       | 50 ++++++++++++
>  3 files changed, 126 insertions(+), 63 deletions(-)

> +properties:
> +  compatible:
> +    enum:
> +      - maxim,max1361,

Dangling comma.

Otherwise,

Reviewed-by: Rob Herring <robh@kernel.org>

> +      - maxim,max1362
> +      - maxim,max1363
> +      - maxim,max1364


  reply	other threads:[~2020-02-19 22:10 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-08 17:23 [PATCH] dt-bindings: iio: adc: max1363 etc i2c ADC binding conversion jic23
2020-02-19 22:10 ` Rob Herring [this message]
2020-02-21 10:04   ` Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200219221005.GA22158@bogus \
    --to=robh@kernel.org \
    --cc=Jonathan.Cameron@huawei.com \
    --cc=devicetree@vger.kernel.org \
    --cc=jic23@kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).