From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2CA6DC35646 for ; Fri, 21 Feb 2020 13:12:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id F097D2073A for ; Fri, 21 Feb 2020 13:12:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="eib3Jfwy" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728103AbgBUNMd (ORCPT ); Fri, 21 Feb 2020 08:12:33 -0500 Received: from mail-wm1-f67.google.com ([209.85.128.67]:38256 "EHLO mail-wm1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727973AbgBUNMd (ORCPT ); Fri, 21 Feb 2020 08:12:33 -0500 Received: by mail-wm1-f67.google.com with SMTP id a9so1796553wmj.3 for ; Fri, 21 Feb 2020 05:12:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=a/KavHLvvULXfL2VP34j+gxXqKWZ5d3n9oQaqLdPQv4=; b=eib3Jfwyj+tZtw0Vz5eRWnOQiMb9kRoD6q2gN2p55T9aS3rgoCUuv4jkOzgSy6JAgQ LEjM/7bJFu5XAMFaMvFkgF8XI6h8ICSPxck1TJrj6R8L0TLPzxasmiTqaRBEuJSE492o xUPyAD7jB/fuLzt6Z6u8a/djHUo7qip9vuLowvh5OaxbICooz75RPYWXY584WFX80Hsq UecpvDo6HfzMYfFJjPppbxEhywhbLPSsEWUgzWENhmVwerLyCsfebJ75YhAi0BV6oT34 gcEUPT4zy5xBisJiKhATgcWrOM/bv0x40XtU3oXOP8d4vAUNTTge4+2/pCIL965PidD5 SzyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=a/KavHLvvULXfL2VP34j+gxXqKWZ5d3n9oQaqLdPQv4=; b=Ir5nwWWpkGiMXbxep9Lz62/bU/4oP9s+CC2cf/N4BoU2JTDjXWvLRjvszbZKAZcesJ 3wGjN3BteYun7TcXju1sttwi0Z1CdBxVey3fv2wxqCRvlGlta23pMc4n58eu83CkS6I6 7F0HSNVXP1COzLGhwg1ddU2DsMKAKljuShkCYNsUbd1nm3GeBKibrwDqysXHL7r2dHn5 JglcOBn+D6mjWPAQXOQEbIUQBKf7T0EDOWHk8mvn0ZKRZC4WyDVISexFfOs+hzDd2UnM 4WzLkhn/5/N6o/OOT0grL64gpqkvsGdQxvK8mscgswpNpZESVir3RJhZZG+aRClDLUDF 0GGw== X-Gm-Message-State: APjAAAUAcfK8WjAFLu8MRzcb/TPCxJENqwXofY8xOXF7t49sxYZXfmYu 1ePoCPcsLpEAi3cKM5eyHXd0QA== X-Google-Smtp-Source: APXvYqx5emu1fdVAd6Tj3p81RSkBc6Mf5Yyr0nrkLGXMlG0khLLYOloIT2vAb1bEk0+GwUGFpzZSvQ== X-Received: by 2002:a1c:4e02:: with SMTP id g2mr3929356wmh.131.1582290750388; Fri, 21 Feb 2020 05:12:30 -0800 (PST) Received: from linaro.org ([2a01:e34:ed2f:f020:2dfb:b5ce:9043:4adb]) by smtp.gmail.com with ESMTPSA id c15sm3881537wrt.1.2020.02.21.05.12.28 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 21 Feb 2020 05:12:29 -0800 (PST) Date: Fri, 21 Feb 2020 14:12:26 +0100 From: Daniel Lezcano To: Anson Huang Cc: "robh+dt@kernel.org" , "mark.rutland@arm.com" , "shawnguo@kernel.org" , "s.hauer@pengutronix.de" , "kernel@pengutronix.de" , "festevam@gmail.com" , "catalin.marinas@arm.com" , "will@kernel.org" , "rui.zhang@intel.com" , "amit.kucheria@verdurent.com" , Aisheng Dong , "linux@roeck-us.net" , "srinivas.kandagatla@linaro.org" , "krzk@kernel.org" , Andy Duan , Peng Fan , Daniel Baluta , "bjorn.andersson@linaro.org" , "olof@lixom.net" , "dinguyen@kernel.org" , Leonard Crestez , "marcin.juszkiewicz@linaro.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-pm@vger.kernel.org" , dl-linux-imx Subject: Re: [PATCH V15 RESEND 2/5] thermal: of-thermal: add API for getting sensor ID from DT Message-ID: <20200221131226.GE10516@linaro.org> References: <1582161028-2844-1-git-send-email-Anson.Huang@nxp.com> <1582161028-2844-2-git-send-email-Anson.Huang@nxp.com> <20200221091112.GA10516@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Fri, Feb 21, 2020 at 09:26:29AM +0000, Anson Huang wrote: > Hi, Daniel > > > > * a valid .of_node, for the sensor node. > > > @@ -499,36 +546,22 @@ thermal_zone_of_sensor_register(struct device > > *dev, int sensor_id, void *data, > > > sensor_np = of_node_get(dev->of_node); > > > > > > for_each_available_child_of_node(np, child) { > > > - struct of_phandle_args sensor_specs; > > > int ret, id; > > > > > > /* For now, thermal framework supports only 1 sensor per > > zone */ > > > - ret = of_parse_phandle_with_args(child, "thermal-sensors", > > > - "#thermal-sensor-cells", > > > - 0, &sensor_specs); > > > + ret = thermal_zone_of_get_sensor_id(child, sensor_np, &id); > > > if (ret) > > > continue; > > > > > > - if (sensor_specs.args_count >= 1) { > > > - id = sensor_specs.args[0]; > > > - WARN(sensor_specs.args_count > 1, > > > - "%pOFn: too many cells in sensor specifier %d\n", > > > - sensor_specs.np, sensor_specs.args_count); > > > - } else { > > > - id = 0; > > > - } > > > > Please take also the opportunity to factor out the function > > thermal_zone_of_sensor_register(). > > Sorry, I do NOT quite understand terms "factor out the function ...", could you please advise more detail? Never mind, I realized I puzzled myself with the changes in the series :) Thanks -- Daniel -- Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog