devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Michael Walle <michael@walle.cc>
To: olteanv@gmail.com
Cc: andrew@lunn.ch, davem@davemloft.net, devicetree@vger.kernel.org,
	f.fainelli@gmail.com, linux-kernel@vger.kernel.org,
	mark.rutland@arm.com, netdev@vger.kernel.org, robh+dt@kernel.org,
	shawnguo@kernel.org, vivien.didelot@gmail.com,
	Michael Walle <michael@walle.cc>
Subject: Re: [PATCH v2 net-next/devicetree 5/5] arm64: dts: fsl: ls1028a: enable switch PHYs on RDB
Date: Sat, 22 Feb 2020 12:41:36 +0100	[thread overview]
Message-ID: <20200222114136.595-1-michael@walle.cc> (raw)
In-Reply-To: <20200219151259.14273-6-olteanv@gmail.com>

Hi,

> Link the switch PHY nodes to the central MDIO controller PCIe endpoint
> node on LS1028A (implemented as PF3) so that PHYs are accessible via
> MDIO.
> 
> Enable SGMII AN on the Felix PCS by telling PHYLINK that the VSC8514
> quad PHY is capable of in-band-status.
> 
> The PHYs are used in poll mode due to an issue with the interrupt line
> on current revisions of the LS1028A-RDB board.
> 
> Signed-off-by: Claudiu Manoil <claudiu.manoil@nxp.com>
> Signed-off-by: Alex Marginean <alexandru.marginean@nxp.com>
> Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
> Reviewed-by: Andrew Lunn <andrew@lunn.ch>
> ---
> Changes in v2:
> None.
> 
>  .../boot/dts/freescale/fsl-ls1028a-rdb.dts    | 51 +++++++++++++++++++
>  1 file changed, 51 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dts b/arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dts
> index afb55653850d..9353c00e46a7 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dts
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dts
> @@ -194,6 +194,57 @@
>  	status = "disabled";
>  };
>  
> +&enetc_mdio_pf3 {
> +	/* VSC8514 QSGMII quad PHY */
> +	qsgmii_phy0: ethernet-phy@10 {
> +		reg = <0x10>;
> +	};
> +
> +	qsgmii_phy1: ethernet-phy@11 {
> +		reg = <0x11>;
> +	};
> +
> +	qsgmii_phy2: ethernet-phy@12 {
> +		reg = <0x12>;
> +	};
> +
> +	qsgmii_phy3: ethernet-phy@13 {
> +		reg = <0x13>;
> +	};
> +};
> +
> +&mscc_felix_port0 {
> +	status = "okay";
status should be the last property, correct?

-michael

> +	label = "swp0";
> +	managed = "in-band-status";
> +	phy-handle = <&qsgmii_phy0>;
> +	phy-mode = "qsgmii";
> +};
> +
> +&mscc_felix_port1 {
> +	status = "okay";
> +	label = "swp1";
> +	managed = "in-band-status";
> +	phy-handle = <&qsgmii_phy1>;
> +	phy-mode = "qsgmii";
> +};
> +
> +&mscc_felix_port2 {
> +	status = "okay";
> +	label = "swp2";
> +	managed = "in-band-status";
> +	phy-handle = <&qsgmii_phy2>;
> +	phy-mode = "qsgmii";
> +};
> +
> +&mscc_felix_port3 {
> +	status = "okay";
> +	label = "swp3";
> +	managed = "in-band-status";
> +	phy-handle = <&qsgmii_phy3>;
> +	phy-mode = "qsgmii";
> +};
> +
>  &sai4 {
>  	status = "okay";
>  };
> -- 
> 2.17.1



  reply	other threads:[~2020-02-22 11:41 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-19 15:12 [PATCH v2 net-next/devicetree 0/5] DT bindings for Felix DSA switch on LS1028A Vladimir Oltean
2020-02-19 15:12 ` [PATCH v2 net-next/devicetree 1/5] arm64: dts: fsl: ls1028a: delete extraneous #interrupt-cells for ENETC RCIE Vladimir Oltean
2020-02-24  6:34   ` Shawn Guo
2020-02-19 15:12 ` [PATCH v2 net-next/devicetree 2/5] net: dsa: felix: Use PHY_INTERFACE_MODE_INTERNAL instead of GMII Vladimir Oltean
2020-02-19 15:26   ` Andrew Lunn
2020-02-19 15:12 ` [PATCH v2 net-next/devicetree 3/5] dt-bindings: net: dsa: ocelot: document the vsc9959 core Vladimir Oltean
2020-02-19 15:27   ` Andrew Lunn
2020-02-22 11:28   ` Michael Walle
2020-02-22 12:33     ` Vladimir Oltean
2020-02-19 15:12 ` [PATCH v2 net-next/devicetree 4/5] arm64: dts: fsl: ls1028a: add node for Felix switch Vladimir Oltean
2020-02-22 11:38   ` Michael Walle
2020-02-22 12:25     ` Vladimir Oltean
2020-02-22 13:19       ` Michael Walle
2020-02-24  6:36   ` Shawn Guo
2020-02-19 15:12 ` [PATCH v2 net-next/devicetree 5/5] arm64: dts: fsl: ls1028a: enable switch PHYs on RDB Vladimir Oltean
2020-02-22 11:41   ` Michael Walle [this message]
2020-02-22 12:17     ` Vladimir Oltean
2020-02-24  6:39       ` Shawn Guo
2020-02-19 19:12 ` [PATCH v2 net-next/devicetree 0/5] DT bindings for Felix DSA switch on LS1028A David Miller
2020-02-22 13:33   ` Michael Walle
2020-02-24  6:31 ` Shawn Guo
2020-02-24  7:59   ` Vladimir Oltean
2020-02-24  8:48     ` Shawn Guo
2020-02-24  8:50       ` Vladimir Oltean
2020-02-24  8:51         ` Vladimir Oltean

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200222114136.595-1-michael@walle.cc \
    --to=michael@walle.cc \
    --cc=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=f.fainelli@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=netdev@vger.kernel.org \
    --cc=olteanv@gmail.com \
    --cc=robh+dt@kernel.org \
    --cc=shawnguo@kernel.org \
    --cc=vivien.didelot@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).