devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Shawn Guo <shawnguo@kernel.org>
To: Martin Kepplinger <martin.kepplinger@puri.sm>
Cc: robh@kernel.org, mark.rutland@arm.com, s.hauer@pengutronix.de,
	kernel@pengutronix.de, linux-imx@nxp.com, Anson.Huang@nxp.com,
	devicetree@vger.kernel.org, kernel@puri.sm,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org,
	"Angus Ainslie (Purism)" <angus@akkea.ca>
Subject: Re: [PATCH v2 4/9] arm64: dts: librem5-devkit: allow modem to wake the system from suspend
Date: Mon, 24 Feb 2020 10:02:52 +0800	[thread overview]
Message-ID: <20200224020251.GF27688@dragon> (raw)
In-Reply-To: <20200218084942.4884-5-martin.kepplinger@puri.sm>

On Tue, Feb 18, 2020 at 09:49:37AM +0100, Martin Kepplinger wrote:
> From: "Angus Ainslie (Purism)" <angus@akkea.ca>
> 
> Connect the WoWWAN signal to a gpio key to wake up the system from suspend.
> 
> Signed-off-by: Angus Ainslie (Purism) <angus@akkea.ca>
> Signed-off-by: Martin Kepplinger <martin.kepplinger@puri.sm>
> ---
>  .../arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts b/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts
> index ec12477d925d..9c81b07f43f3 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts
> +++ b/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts
> @@ -55,6 +55,15 @@
>  			wakeup-source;
>  			linux,code = <KEY_HP>;
>  		};
> +
> +		wwan_wake {

We prefer to use hyphen over underscore in node name.

Shawn

> +			label = "WWAN_WAKE";
> +			gpios = <&gpio3 8 GPIO_ACTIVE_LOW>;
> +			interrupt-parent = <&gpio3>;
> +			interrupts = <8 GPIO_ACTIVE_LOW>;
> +			wakeup-source;
> +			linux,code = <KEY_PHONE>;
> +		};
>  	};
>  
>  	leds {
> @@ -574,6 +583,7 @@
>  			MX8MQ_IOMUXC_SAI2_RXFS_GPIO4_IO21	0x16
>  			MX8MQ_IOMUXC_SAI2_RXC_GPIO4_IO22	0x16
>  			MX8MQ_IOMUXC_SAI5_RXC_GPIO3_IO20	0x180  /* HP_DET */
> +			MX8MQ_IOMUXC_NAND_DATA02_GPIO3_IO8	0x80   /* nWoWWAN */
>  		>;
>  	};
>  
> -- 
> 2.20.1
> 

  reply	other threads:[~2020-02-24  2:02 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-18  8:49 [PATCH v2 0/9] arm64: dts: librem5-devkit: description updates Martin Kepplinger
2020-02-18  8:49 ` [PATCH v2 1/9] arm64: dts: librem5-devkit: add sai2 and sai6 pinctrl definitions Martin Kepplinger
2020-02-24  1:56   ` Shawn Guo
2020-02-18  8:49 ` [PATCH v2 2/9] arm64: dts: librem5-devkit: enable sai2 and sai6 audio interface Martin Kepplinger
2020-02-18  8:49 ` [PATCH v2 3/9] arm64: dts: librem5-devkit: add the simcom 7100 modem and sgtl5000 audio codec Martin Kepplinger
2020-02-24  2:01   ` Shawn Guo
2020-02-18  8:49 ` [PATCH v2 4/9] arm64: dts: librem5-devkit: allow modem to wake the system from suspend Martin Kepplinger
2020-02-24  2:02   ` Shawn Guo [this message]
2020-02-18  8:49 ` [PATCH v2 5/9] arm64: dts: librem5-devkit: add a vbus supply to usb0 Martin Kepplinger
2020-02-18  8:49 ` [PATCH v2 6/9] arm64: dts: librem5-devkit: add the regulators for DVFS Martin Kepplinger
2020-02-18  8:49 ` [PATCH v2 7/9] arm64: dts: librem5-devkit: allow the redpine card to be removed Martin Kepplinger
2020-02-18  8:49 ` [PATCH v2 8/9] arm64: dts: librem5-devkit: increase the VBUS current in the kernel Martin Kepplinger
2020-02-18  8:49 ` [PATCH v2 9/9] arm64: dts: librem5-devkit: add lsm9ds1 mount matrix Martin Kepplinger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200224020251.GF27688@dragon \
    --to=shawnguo@kernel.org \
    --cc=Anson.Huang@nxp.com \
    --cc=angus@akkea.ca \
    --cc=devicetree@vger.kernel.org \
    --cc=kernel@pengutronix.de \
    --cc=kernel@puri.sm \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=martin.kepplinger@puri.sm \
    --cc=robh@kernel.org \
    --cc=s.hauer@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).