From: Rob Herring <robh@kernel.org>
To: Tim Harvey <tharvey@gateworks.com>
Cc: Lee Jones <lee.jones@linaro.org>,
Jean Delvare <jdelvare@suse.com>,
Guenter Roeck <linux@roeck-us.net>,
linux-hwmon@vger.kernel.org,
Frank Rowand <frowand.list@gmail.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Robert Jones <rjones@gateworks.com>,
Tim Harvey <tharvey@gateworks.com>
Subject: Re: [PATCH v4 1/3] dt-bindings: mfd: Add Gateworks System Controller bindings
Date: Mon, 24 Feb 2020 12:38:10 -0600 [thread overview]
Message-ID: <20200224183810.GA32214@bogus> (raw)
In-Reply-To: <1582320476-1098-2-git-send-email-tharvey@gateworks.com>
On Fri, 21 Feb 2020 13:27:54 -0800, Tim Harvey wrote:
> This patch adds documentation of device-tree bindings for the
> Gateworks System Controller (GSC).
>
> Signed-off-by: Tim Harvey <tharvey@gateworks.com>
>
> v4:
> - move to using pwm<n>_auto_point<m>_{pwm,temp} for FAN PWM
> - remove unncessary resolution/scaling properties for ADCs
> - update to yaml
> - remove watchdog
>
> v3:
> - replaced _ with -
> - remove input bindings
> - added full description of hwmon
> - fix unit address of hwmon child nodes
>
> update dts
>
> Signed-off-by: Tim Harvey <tharvey@gateworks.com>
>
> merge with binding doc
> ---
> .../devicetree/bindings/mfd/gateworks-gsc.yaml | 156 +++++++++++++++++++++
> 1 file changed, 156 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/mfd/gateworks-gsc.yaml
>
My bot found errors running 'make dt_binding_check' on your patch:
warning: no schema found in file: Documentation/devicetree/bindings/mfd/gateworks-gsc.yaml
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mfd/gateworks-gsc.yaml: ignoring, error parsing file
Documentation/devicetree/bindings/display/simple-framebuffer.example.dts:21.16-37.11: Warning (chosen_node_is_root): /example-0/chosen: chosen node must be at root node
Documentation/devicetree/bindings/mfd/gateworks-gsc.yaml: while parsing a block mapping
in "<unicode string>", line 62, column 11
did not find expected key
in "<unicode string>", line 75, column 12
Documentation/devicetree/bindings/Makefile:12: recipe for target 'Documentation/devicetree/bindings/mfd/gateworks-gsc.example.dts' failed
make[1]: *** [Documentation/devicetree/bindings/mfd/gateworks-gsc.example.dts] Error 1
Makefile:1263: recipe for target 'dt_binding_check' failed
make: *** [dt_binding_check] Error 2
See https://patchwork.ozlabs.org/patch/1242346
Please check and re-submit.
next prev parent reply other threads:[~2020-02-24 18:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-21 21:27 [PATCH v4 0/3] Add support for the Gateworks System Controller Tim Harvey
2020-02-21 21:27 ` [PATCH v4 1/3] dt-bindings: mfd: Add Gateworks System Controller bindings Tim Harvey
2020-02-24 18:38 ` Rob Herring [this message]
2020-02-21 21:27 ` [PATCH v4 2/3] mfd: add Gateworks System Controller core driver Tim Harvey
2020-02-21 21:27 ` [PATCH v4 3/3] hwmon: add Gateworks System Controller support Tim Harvey
2020-02-22 17:37 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200224183810.GA32214@bogus \
--to=robh@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=frowand.list@gmail.com \
--cc=jdelvare@suse.com \
--cc=lee.jones@linaro.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=rjones@gateworks.com \
--cc=tharvey@gateworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).