From: Rob Herring <robh@kernel.org>
To: Masahiro Yamada <masahiroy@kernel.org>
Cc: linux-kbuild@vger.kernel.org, devicetree@vger.kernel.org,
Michal Marek <michal.lkml@markovi.net>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/5] kbuild: fix DT binding schema rule to detect command line changes
Date: Mon, 24 Feb 2020 16:52:53 -0600 [thread overview]
Message-ID: <20200224225253.GA27948@bogus> (raw)
In-Reply-To: <20200222190435.11767-1-masahiroy@kernel.org>
On Sun, Feb 23, 2020 at 04:04:31AM +0900, Masahiro Yamada wrote:
> This if_change_rule is not working; it cannot detect any command line
> changes.
>
> The reason is because cmd-check in scripts/Kbuild.include compares
> $(cmd_$@) and $(cmd_$1), but cmd_dtc_dt_yaml does not exist here.
>
> For if_change_rule to work properly, the stem part of cmd_* and rule_*
> must match. Because this cmd_and_fixdep invokes cmd_dtc, this rule must
> be named rule_dtc.
>
> Fixes: 4f0e3a57d6eb ("kbuild: Add support for DT binding schema checks")
> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
> ---
>
> scripts/Makefile.lib | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
For the series,
Acked-by: Rob Herring <robh@kernel.org>
I'm assuming you will take these? If not, I can in the DT tree.
Rob
next prev parent reply other threads:[~2020-02-24 22:52 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-22 19:04 [PATCH 1/5] kbuild: fix DT binding schema rule to detect command line changes Masahiro Yamada
2020-02-22 19:04 ` [PATCH 2/5] kbuild: remove unneeded semicolon at the end of cmd_dtb_check Masahiro Yamada
2020-02-26 17:47 ` Masahiro Yamada
2020-02-22 19:04 ` [PATCH 3/5] kbuild: add dtbs_check to PHONY Masahiro Yamada
2020-02-26 17:47 ` Masahiro Yamada
2020-02-22 19:04 ` [PATCH 4/5] kbuild: add dt_binding_check to PHONY in a correct place Masahiro Yamada
2020-02-26 17:48 ` Masahiro Yamada
2020-02-22 19:04 ` [PATCH 5/5] kbuild: allow to run dt_binding_check and dtbs_check in a single command Masahiro Yamada
2020-02-26 6:46 ` Masahiro Yamada
2020-02-24 22:52 ` Rob Herring [this message]
2020-02-25 4:32 ` [PATCH 1/5] kbuild: fix DT binding schema rule to detect command line changes Masahiro Yamada
2020-02-26 17:47 ` Masahiro Yamada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200224225253.GA27948@bogus \
--to=robh@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=michal.lkml@markovi.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).