From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BAA75C35DF9 for ; Tue, 25 Feb 2020 08:45:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 94F8A20CC7 for ; Tue, 25 Feb 2020 08:45:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729282AbgBYIpY (ORCPT ); Tue, 25 Feb 2020 03:45:24 -0500 Received: from bhuna.collabora.co.uk ([46.235.227.227]:36784 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726039AbgBYIpY (ORCPT ); Tue, 25 Feb 2020 03:45:24 -0500 Received: from localhost (unknown [IPv6:2a01:e0a:2c:6930:5cf4:84a1:2763:fe0d]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: bbrezillon) by bhuna.collabora.co.uk (Postfix) with ESMTPSA id 3EC32293DCC; Tue, 25 Feb 2020 08:45:22 +0000 (GMT) Date: Tue, 25 Feb 2020 09:45:18 +0100 From: Boris Brezillon To: Laurent Pinchart Cc: dri-devel@lists.freedesktop.org, Nikita Yushchenko , Mark Rutland , Jernej Skrabec , Neil Armstrong , Andrey Smirnov , Jonas Karlman , Rob Herring , Andrzej Hajda , devicetree@vger.kernel.org, Thierry Reding , intel-gfx-trybot@lists.freedesktop.org, kernel@collabora.com, Sam Ravnborg , Chris Healy Subject: Re: [PATCH v10 10/12] drm/bridge: panel: Propage bus format/flags Message-ID: <20200225094518.4f57ca5a@collabora.com> In-Reply-To: <20200224223400.GB29578@pendragon.ideasonboard.com> References: <20200128135514.108171-1-boris.brezillon@collabora.com> <20200128135514.108171-11-boris.brezillon@collabora.com> <20200131182505.51366470@collabora.com> <20200224223400.GB29578@pendragon.ideasonboard.com> Organization: Collabora X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Tue, 25 Feb 2020 00:34:00 +0200 Laurent Pinchart wrote: > Hi Boris, > > Thank you for the patch. > > On Fri, Jan 31, 2020 at 06:25:05PM +0100, Boris Brezillon wrote: > > And the typo (Propage -> Propagate) is still there :-(. Fixing it right > > now so I don't forget. > > > > On Tue, 28 Jan 2020 14:55:12 +0100 Boris Brezillon wrote: > > > So that the previous bridge element in the chain knows which input > > > format the panel bridge expects. > > I've been told multiple times by Tomi that the commit message should be > readable by itself, not just as a continuation of the subject line. I > was annoyed in the beginning, as I had to change my habits, but I think > it's an actual improvement. You may want to pay attention to that too in > the future. > > > > v10: > > > * Add changelog to the commit message > > > > > > v8 -> v9: > > > * No changes > > > > > > v7: > > > * Set atomic state hooks explicitly > > > > > > v4 -> v6: > > > * Not part of the series > > > > > > v3: > > > * Adjust things to match the new bus-format negotiation approach > > > * Use drm_atomic_helper_bridge_propagate_bus_fmt > > > * Don't implement ->atomic_check() (the core now takes care of bus > > > flags propagation) > > > > > > v2: > > > * Adjust things to match the new bus-format negotiation approach > > > > > > Signed-off-by: Boris Brezillon > > With the typo fixed, > > Reviewed-by: Laurent Pinchart Will fix the typo, update the commit message and push this patch directly. Thanks, Boris > > > > --- > > > drivers/gpu/drm/bridge/panel.c | 4 ++++ > > > 1 file changed, 4 insertions(+) > > > > > > diff --git a/drivers/gpu/drm/bridge/panel.c b/drivers/gpu/drm/bridge/panel.c > > > index f66777e24968..dcc72bd7df30 100644 > > > --- a/drivers/gpu/drm/bridge/panel.c > > > +++ b/drivers/gpu/drm/bridge/panel.c > > > @@ -127,6 +127,10 @@ static const struct drm_bridge_funcs panel_bridge_bridge_funcs = { > > > .enable = panel_bridge_enable, > > > .disable = panel_bridge_disable, > > > .post_disable = panel_bridge_post_disable, > > > + .atomic_reset = drm_atomic_helper_bridge_reset, > > > + .atomic_duplicate_state = drm_atomic_helper_bridge_duplicate_state, > > > + .atomic_destroy_state = drm_atomic_helper_bridge_destroy_state, > > > + .atomic_get_input_bus_fmts = drm_atomic_helper_bridge_propagate_bus_fmt, > > > }; > > > > > > /** >