devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: frowand.list@gmail.com
Cc: Geert Uytterhoeven <geert+renesas@glider.be>,
	pantelis.antoniou@konsulko.com, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, Alan Tull <atull@kernel.org>
Subject: Re: [PATCH v2 2/2] of: unittest: annotate warnings triggered by unittest
Date: Wed, 26 Feb 2020 10:42:17 -0600	[thread overview]
Message-ID: <20200226164217.GA10550@bogus> (raw)
In-Reply-To: <1582224021-12827-3-git-send-email-frowand.list@gmail.com>

On Thu, 20 Feb 2020 12:40:21 -0600, frowand.list@gmail.com wrote:
> From: Frank Rowand <frank.rowand@sony.com>
> 
> Some tests in the devicetree unittests result in printk messages
> from the code being tested.  It can be difficult to determine
> whether the messages are the result of unittest or are potentially
> reporting bugs that should be fixed.  The most recent example of
> a person asking whether to be concerned about these messages is [1].
> 
> Add annotations for all messages triggered by unittests, except
> KERN_DEBUG messages.  (KERN_DEBUG is a special case due to the
> possible interaction of CONFIG_DYNAMIC_DEBUG.)
> 
> The format of the annotations is expected to change when unittests
> are converted to use the kunit infrastructure when the broader
> testing community has an opportunity to discuss the implementation
> of annotations of test triggered messages.
> 
> [1] https://lore.kernel.org/r/6021ac63-b5e0-ed3d-f964-7c6ef579cd68@huawei.com
> 
> Signed-off-by: Frank Rowand <frank.rowand@sony.com>
> ---
> changes since v1:
>   - none
> 
>  drivers/of/unittest.c | 375 ++++++++++++++++++++++++++++++++++++++++++++++----
>  1 file changed, 345 insertions(+), 30 deletions(-)
> 

Applied, thanks.

Rob

      reply	other threads:[~2020-02-26 16:42 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-20 18:40 [PATCH v2 0/2] of: unittest: add overlay gpio test to catch gpio hog problem frowand.list
2020-02-20 18:40 ` [PATCH v2 1/2] " frowand.list
2020-02-26 16:42   ` Rob Herring
2020-03-13 16:40     ` Frank Rowand
2020-03-16  8:45       ` Anders Roxell
2020-03-26  1:56       ` Frank Rowand
2020-03-26 10:39         ` Anders Roxell
2020-03-26 15:33           ` Frank Rowand
2020-04-08 12:27             ` Anders Roxell
2020-02-20 18:40 ` [PATCH v2 2/2] of: unittest: annotate warnings triggered by unittest frowand.list
2020-02-26 16:42   ` Rob Herring [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200226164217.GA10550@bogus \
    --to=robh@kernel.org \
    --cc=atull@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=frowand.list@gmail.com \
    --cc=geert+renesas@glider.be \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pantelis.antoniou@konsulko.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).