From: Rob Herring <robh@kernel.org>
To: Alexandre Torgue <alexandre.torgue@st.com>
Cc: Frank Rowand <frowand.list@gmail.com>,
Masahiro Yamada <masahiroy@kernel.org>,
Michal Marek <michal.lkml@markovi.net>,
david@gibson.dropbear.id.au, sjg@chromium.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-kbuild@vger.kernel.org,
devicetree-compiler@vger.kernel.org, Ian Lepore <ian@freebsd.org>
Subject: Re: [RFC PATCH v2 2/4] of: fdt: print dtb build information
Date: Wed, 26 Feb 2020 15:36:38 -0600 [thread overview]
Message-ID: <20200226213638.GA29417@bogus> (raw)
In-Reply-To: <20200221161418.20225-3-alexandre.torgue@st.com>
On Fri, Feb 21, 2020 at 05:14:16PM +0100, Alexandre Torgue wrote:
> This commit prints out DTB build information (build time, dts source
> version used, ...) if "Build-info" property exists in DTB root node.
/Build/build/
>
> Signed-off-by: Alexandre Torgue <alexandre.torgue@st.com>
>
> diff --git a/drivers/of/fdt.c b/drivers/of/fdt.c
> index 2cdf64d2456f..aa5989039746 100644
> --- a/drivers/of/fdt.c
> +++ b/drivers/of/fdt.c
> @@ -1224,9 +1224,18 @@ bool __init early_init_dt_scan(void *params)
> */
> void __init unflatten_device_tree(void)
> {
> + const char *build_info;
> + unsigned long dt_root;
> +
> __unflatten_device_tree(initial_boot_params, NULL, &of_root,
> early_init_dt_alloc_memory_arch, false);
>
> + /* If available, provide dtb build information */
> + dt_root = of_get_flat_dt_root();
> + build_info = of_get_flat_dt_prop(dt_root, "build-info", NULL);
We just unflattened the tree, why are we using the flat dt functions?
> + if (build_info)
> + pr_info("%s\n", build_info);
> +
> /* Get pointer to "/chosen" and "/aliases" nodes for use everywhere */
> of_alias_scan(early_init_dt_alloc_memory_arch);
>
> --
> 2.17.1
>
next prev parent reply other threads:[~2020-02-26 21:36 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-21 16:14 [RFC PATCH v2 0/4] Add device tree build information Alexandre Torgue
2020-02-21 16:14 ` [RFC PATCH v2 1/4] scripts: Add script to generate dtb " Alexandre Torgue
2020-02-21 17:52 ` Frank Rowand
2020-02-21 19:38 ` Rob Herring
2020-03-02 12:40 ` Alexandre Torgue
2020-02-23 21:59 ` David Gibson
2020-02-24 0:57 ` Frank Rowand
2020-02-21 16:14 ` [RFC PATCH v2 2/4] of: fdt: print " Alexandre Torgue
2020-02-26 21:36 ` Rob Herring [this message]
2020-02-21 16:14 ` [RFC PATCH v2 3/4] ARM: dts: stm32: Add dtb build information entry for stm32mp157c-dk2 Alexandre Torgue
2020-02-21 16:14 ` [RFC PATCH v2 4/4] script: make automatic dtb build info generation Alexandre Torgue
2020-02-21 17:59 ` Frank Rowand
2020-02-26 20:56 ` Rob Herring
2020-02-21 17:47 ` [RFC PATCH v2 0/4] Add device tree build information Frank Rowand
2020-02-28 17:47 ` Frank Rowand
2020-03-02 12:55 ` Alexandre Torgue
2020-03-31 1:03 ` Steve McIntyre
2020-03-31 15:00 ` Alexandre Torgue
-- strict thread matches above, loose matches on Subject: below --
2020-02-21 16:12 [RFC PATCH v2 0/4] Alexandre Torgue
2020-02-21 16:12 ` [RFC PATCH v2 2/4] of: fdt: print dtb build information Alexandre Torgue
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200226213638.GA29417@bogus \
--to=robh@kernel.org \
--cc=alexandre.torgue@st.com \
--cc=david@gibson.dropbear.id.au \
--cc=devicetree-compiler@vger.kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=frowand.list@gmail.com \
--cc=ian@freebsd.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=michal.lkml@markovi.net \
--cc=sjg@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).