From: Rob Herring <robh@kernel.org>
To: Masahiro Yamada <yamada.masahiro@socionext.com>
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
masahiroy@kernel.org,
Masahiro Yamada <yamada.masahiro@socionext.com>,
Piotr Sroka <piotrs@cadence.com>,
Mark Rutland <mark.rutland@arm.com>,
Ulf Hansson <ulf.hansson@linaro.org>,
linux-mmc@vger.kernel.org
Subject: Re: [PATCH v2] dt-bindings: mmc: Convert Cadence SD/SDIO/eMMC controller to json-schema
Date: Wed, 26 Feb 2020 16:23:11 -0600 [thread overview]
Message-ID: <20200226222311.GA8834@bogus> (raw)
In-Reply-To: <20200222143444.5135-1-yamada.masahiro@socionext.com>
On Sat, 22 Feb 2020 23:34:44 +0900, Masahiro Yamada wrote:
> Convert the Cadence SD/SDIO/eMMC host controller IP (a.k.a. SD4HC)
> binding to DT schema format.
>
> Socionext UniPhier ARM 64-bit SoCs are integrated with this IP.
>
> Cc: Piotr Sroka <piotrs@cadence.com>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> ---
>
> I wanted to keep some precious comments, which apply to multiple
> properties.
>
> I do not think 'description:' is a good fit for this.
>
> I was searching for a way to insert a comment line that does not
> affect the schema.
>
> The $comment did not work. I just use '#', which is YAML comment.
> If there is a better way, please let me know.
>
>
> Changes in v2:
> - fix schema warning in example
>
> .../devicetree/bindings/mmc/cdns,sdhci.yaml | 143 ++++++++++++++++++
> .../devicetree/bindings/mmc/sdhci-cadence.txt | 80 ----------
> 2 files changed, 143 insertions(+), 80 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/mmc/cdns,sdhci.yaml
> delete mode 100644 Documentation/devicetree/bindings/mmc/sdhci-cadence.txt
>
Applied, thanks.
Rob
prev parent reply other threads:[~2020-02-26 22:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-22 14:34 [PATCH v2] dt-bindings: mmc: Convert Cadence SD/SDIO/eMMC controller to json-schema Masahiro Yamada
2020-02-26 22:23 ` Rob Herring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200226222311.GA8834@bogus \
--to=robh@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=masahiroy@kernel.org \
--cc=piotrs@cadence.com \
--cc=ulf.hansson@linaro.org \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).