From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 409EFC4BA24 for ; Wed, 26 Feb 2020 22:39:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1C79321D7E for ; Wed, 26 Feb 2020 22:39:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727763AbgBZWjY (ORCPT ); Wed, 26 Feb 2020 17:39:24 -0500 Received: from muru.com ([72.249.23.125]:57922 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727761AbgBZWjY (ORCPT ); Wed, 26 Feb 2020 17:39:24 -0500 Received: from atomide.com (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id 1CD8A8022; Wed, 26 Feb 2020 22:40:09 +0000 (UTC) Date: Wed, 26 Feb 2020 14:39:21 -0800 From: Tony Lindgren To: Suman Anna Cc: Roger Quadros , Tero Kristo , linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH 06/12] ARM: dts: am335x-bone-common: Enable PRU-ICSS interconnect node Message-ID: <20200226223921.GB37466@atomide.com> References: <20200225204649.28220-1-s-anna@ti.com> <20200225204649.28220-7-s-anna@ti.com> <20200226182924.GU37466@atomide.com> <20200226223745.GA37466@atomide.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200226223745.GA37466@atomide.com> Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org * Tony Lindgren [200226 22:38]: > * Suman Anna [200226 20:35]: > > On 2/26/20 12:29 PM, Tony Lindgren wrote: > > > * Suman Anna [200225 20:47]: > > >> The PRU-ICSS target module node was left in disabled state in the base > > >> am33xx-l4.dtsi file. Enable this node on all the AM335x beaglebone > > >> boards as they mostly use a AM3358 or a AM3359 SoC which do contain > > >> the PRU-ICSS IP. > > > > > > Just get rid of the top level status = "disabled". The default > > > is enabled, and the device is there for sure inside the SoC. > > > And then there's no need for pointless status = "okay" tinkering > > > in the board specific dts files so no need for this patch. > > > > The IP is not available on all SoCs, and there are about 40 different > > board files atm across AM33xx and AM437x, and am not sure what SoCs they > > are actually using. > > Oh that issue again.. Maybe take a look at patch "[PATCH 2/3] bus: ti-sysc: > Detect display subsystem related devices" if you can add runtime > detection for the accelerators there similar to what I hadded for omap3. > acclerators. Sorry I meant instead patch "[PATCH 6/7] bus: ti-sysc: Implement SoC revision handling". Regards, Tony