From: Boris Brezillon <boris.brezillon@collabora.com>
To: "Ramuthevar,
Vadivel MuruganX" <vadivel.muruganx.ramuthevar@linux.intel.com>
Cc: linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org,
broonie@kernel.org, vigneshr@ti.com, robh+dt@kernel.org,
marex@denx.de, devicetree@vger.kernel.org,
tien.fong.chee@intel.com, tudor.ambarus@gmail.com,
boris.brezillon@free-electrons.com, richard@nod.at,
qi-ming.wu@intel.com, simon.k.r.goldschmidt@gmail.com,
david.oberhollenzer@sigma-star.at, dinguyen@kernel.org,
linux-mtd@lists.infradead.org, miquel.raynal@bootlin.com,
cheol.yong.kim@intel.com, mark.rutland@arm.com,
computersforpeace@gmail.com, dwmw2@infradead.org,
cyrille.pitchen@atmel.com
Subject: Re: [PATCH v11 2/2] spi: cadence-quadspi: Add support for the Cadence QSPI controller
Date: Thu, 27 Feb 2020 18:30:32 +0100 [thread overview]
Message-ID: <20200227183032.77ef0795@collabora.com> (raw)
In-Reply-To: <20200227062708.21544-3-vadivel.muruganx.ramuthevar@linux.intel.com>
On Thu, 27 Feb 2020 14:27:08 +0800
"Ramuthevar, Vadivel MuruganX"
<vadivel.muruganx.ramuthevar@linux.intel.com> wrote:
> From: Ramuthevar Vadivel Murugan <vadivel.muruganx.ramuthevar@linux.intel.com>
>
> Add support for the Cadence QSPI controller. This controller is
> present in the Intel Lightning Mountain(LGM) SoCs, Altera and TI SoCs.
> This driver has been tested on the Intel LGM SoCs.
>
> This driver does not support generic SPI and also the implementation
> only supports spi-mem interface to replace the existing driver in
> mtd/spi-nor/cadence-quadspi.c, the existing driver only support SPI-NOR
> flash memory.
Is it really supporting SPI NORs only, or is it just that you only
tested it with a spi-nor?
>
> Signed-off-by: Ramuthevar Vadivel Murugan <vadivel.muruganx.ramuthevar@linux.intel.com>
> Signed-off-by: Vignesh Raghavendra <vigneshr@ti.com>
> Reported-by: kbuild test robot <lkp@intel.com>
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Reported-by? What has been reported?
> ---
> drivers/mtd/spi-nor/Kconfig | 11 -
> drivers/mtd/spi-nor/Makefile | 1 -
> drivers/spi/Kconfig | 10 +
> drivers/spi/Makefile | 1 +
> .../spi-cadence-quadspi.c} | 641 ++++++++++-----------
Looks like this could be split in several patches to ease the review:
1/ convert to spi-mem
2/ move the driver to drivers/spi
3/ add support for intel,lgm-qspi
other than that, that's good to see one more spi-nor controller driver
converted to spi-mem.
next prev parent reply other threads:[~2020-02-27 17:30 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-27 6:27 [PATCH v11 0/2] spi: cadence-quadspi: Add support for the Cadence QSPI controller Ramuthevar,Vadivel MuruganX
2020-02-27 6:27 ` [PATCH v11 1/2] dt-bindings: spi: Add schema for Cadence QSPI Controller driver Ramuthevar,Vadivel MuruganX
2020-02-27 17:07 ` Rob Herring
2020-02-28 3:01 ` Ramuthevar, Vadivel MuruganX
2020-02-27 17:07 ` Rob Herring
2020-02-28 3:08 ` Ramuthevar, Vadivel MuruganX
2020-02-27 6:27 ` [PATCH v11 2/2] spi: cadence-quadspi: Add support for the Cadence QSPI controller Ramuthevar,Vadivel MuruganX
2020-02-27 17:30 ` Boris Brezillon [this message]
2020-02-27 17:32 ` Mark Brown
2020-02-28 6:15 ` Ramuthevar, Vadivel MuruganX
2020-02-28 4:11 ` Ramuthevar, Vadivel MuruganX
2020-02-28 7:46 ` Boris Brezillon
2020-02-28 7:53 ` Ramuthevar, Vadivel MuruganX
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200227183032.77ef0795@collabora.com \
--to=boris.brezillon@collabora.com \
--cc=boris.brezillon@free-electrons.com \
--cc=broonie@kernel.org \
--cc=cheol.yong.kim@intel.com \
--cc=computersforpeace@gmail.com \
--cc=cyrille.pitchen@atmel.com \
--cc=david.oberhollenzer@sigma-star.at \
--cc=devicetree@vger.kernel.org \
--cc=dinguyen@kernel.org \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-spi@vger.kernel.org \
--cc=marex@denx.de \
--cc=mark.rutland@arm.com \
--cc=miquel.raynal@bootlin.com \
--cc=qi-ming.wu@intel.com \
--cc=richard@nod.at \
--cc=robh+dt@kernel.org \
--cc=simon.k.r.goldschmidt@gmail.com \
--cc=tien.fong.chee@intel.com \
--cc=tudor.ambarus@gmail.com \
--cc=vadivel.muruganx.ramuthevar@linux.intel.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).