From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9C24DC3F2CE for ; Sat, 29 Feb 2020 12:50:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7843C24699 for ; Sat, 29 Feb 2020 12:50:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726973AbgB2Mu5 (ORCPT ); Sat, 29 Feb 2020 07:50:57 -0500 Received: from asavdk3.altibox.net ([109.247.116.14]:51970 "EHLO asavdk3.altibox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726944AbgB2Mu4 (ORCPT ); Sat, 29 Feb 2020 07:50:56 -0500 Received: from ravnborg.org (unknown [158.248.194.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by asavdk3.altibox.net (Postfix) with ESMTPS id CB48020043; Sat, 29 Feb 2020 13:50:53 +0100 (CET) Date: Sat, 29 Feb 2020 13:50:52 +0100 From: Sam Ravnborg To: Heiko Stuebner Cc: dri-devel@lists.freedesktop.org, thierry.reding@gmail.com, robh+dt@kernel.org, devicetree@vger.kernel.org, mark.rutland@arm.com, christoph.muellner@theobroma-systems.com, robin.murphy@arm.com, linux-rockchip@lists.infradead.org, Heiko Stuebner Subject: Re: [PATCH v2 2/3] dt-bindings: display: panel: Add binding document for Elida KD35T133 Message-ID: <20200229125052.GB5447@ravnborg.org> References: <20200225093913.415844-1-heiko@sntech.de> <20200225093913.415844-2-heiko@sntech.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200225093913.415844-2-heiko@sntech.de> User-Agent: Mutt/1.10.1 (2018-07-13) X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=eMA9ckh1 c=1 sm=1 tr=0 a=UWs3HLbX/2nnQ3s7vZ42gw==:117 a=UWs3HLbX/2nnQ3s7vZ42gw==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=kj9zAlcOel0A:10 a=NXpJzYs8AAAA:8 a=7gkXJVJtAAAA:8 a=gEfo2CItAAAA:8 a=Plb8VKaFw85NpEceskgA:9 a=CjuIK1q_8ugA:10 a=cwV61pgf2j4Cq8VD9hE_:22 a=E9Po1WZjFZOl8hwRPBS3:22 a=sptkURWiP4Gy88Gu7hUp:22 a=pHzHmUro8NiASowvMSCR:22 a=nt3jZW36AmriUCFCBwmW:22 Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Heiko. On Tue, Feb 25, 2020 at 10:39:12AM +0100, Heiko Stuebner wrote: > From: Heiko Stuebner > > The KD35T133 is a 3.5" 320x480 DSI display used in the RK3326-based > Odroid Go Advance handheld device. > > Signed-off-by: Heiko Stuebner One small comment, but anyway: Reviewed-by: Sam Ravnborg > --- > .../display/panel/elida,kd35t133.yaml | 49 +++++++++++++++++++ > 1 file changed, 49 insertions(+) > create mode 100644 Documentation/devicetree/bindings/display/panel/elida,kd35t133.yaml > > diff --git a/Documentation/devicetree/bindings/display/panel/elida,kd35t133.yaml b/Documentation/devicetree/bindings/display/panel/elida,kd35t133.yaml > new file mode 100644 > index 000000000000..4bd74eaa61be > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/panel/elida,kd35t133.yaml > @@ -0,0 +1,49 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/display/panel/elida,kd35t133.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Elida KD35T133 3.5in 320x480 DSI panel > + > +maintainers: > + - Heiko Stuebner > + > +allOf: > + - $ref: panel-common.yaml# > + > +properties: > + compatible: > + const: elida,kd35t133 > + reg: true > + backlight: true > + reset-gpios: true > + iovcc-supply: > + description: regulator that supplies the iovcc voltage > + vdd-supply: > + description: regulator that supplies the vdd voltage > + > +required: > + - compatible > + - reg > + - backlight Is backlight really required? If it is tied to for example vcc then there is nothing to express in the DT. Sam > + - iovcc-supply > + - vdd-supply > + > +additionalProperties: false > + > +examples: > + - | > + dsi@ff450000 { > + #address-cells = <1>; > + #size-cells = <0>; > + panel@0 { > + compatible = "elida,kd35t133"; > + reg = <0>; > + backlight = <&backlight>; > + iovcc-supply = <&vcc_1v8>; > + vdd-supply = <&vcc3v3_lcd>; > + }; > + }; > + > +... > -- > 2.24.1