From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E5497C3F2CD for ; Mon, 2 Mar 2020 20:49:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C5FC924673 for ; Mon, 2 Mar 2020 20:49:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726755AbgCBUtN (ORCPT ); Mon, 2 Mar 2020 15:49:13 -0500 Received: from asavdk4.altibox.net ([109.247.116.15]:54078 "EHLO asavdk4.altibox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726232AbgCBUtN (ORCPT ); Mon, 2 Mar 2020 15:49:13 -0500 Received: from ravnborg.org (unknown [158.248.194.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by asavdk4.altibox.net (Postfix) with ESMTPS id 408528051F; Mon, 2 Mar 2020 21:49:08 +0100 (CET) Date: Mon, 2 Mar 2020 21:49:06 +0100 From: Sam Ravnborg To: Jordan Crouse Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, David Airlie , freedreno@lists.freedesktop.org, smasetty@codeaurora.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Rob Herring , Sean Paul Subject: Re: [PATCH v3 1/2] dt-bindings: display: msm: Convert GMU bindings to YAML Message-ID: <20200302204906.GA32123@ravnborg.org> References: <1583173424-21832-1-git-send-email-jcrouse@codeaurora.org> <1583173424-21832-2-git-send-email-jcrouse@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1583173424-21832-2-git-send-email-jcrouse@codeaurora.org> User-Agent: Mutt/1.10.1 (2018-07-13) X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=XpTUx2N9 c=1 sm=1 tr=0 a=UWs3HLbX/2nnQ3s7vZ42gw==:117 a=UWs3HLbX/2nnQ3s7vZ42gw==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=kj9zAlcOel0A:10 a=LpQP-O61AAAA:8 a=7gkXJVJtAAAA:8 a=QUSSlG8YkhR_fViXtTAA:9 a=3EO_jEHvlgRDqEOL:21 a=b2m7j8IoA-gO4Aiz:21 a=CjuIK1q_8ugA:10 a=pioyyrs4ZptJ924tMmac:22 a=E9Po1WZjFZOl8hwRPBS3:22 Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Jordan. On Mon, Mar 02, 2020 at 11:23:43AM -0700, Jordan Crouse wrote: > Convert display/msm/gmu.txt to display/msm/gmu.yaml and remove the old > text bindings. > > Signed-off-by: Jordan Crouse > --- > > .../devicetree/bindings/display/msm/gmu.txt | 116 ------------------- > - > -Required properties: > -- compatible: "qcom,adreno-gmu-XYZ.W", "qcom,adreno-gmu" > - for example: "qcom,adreno-gmu-630.2", "qcom,adreno-gmu" > - Note that you need to list the less specific "qcom,adreno-gmu" > - for generic matches and the more specific identifier to identify > - the specific device. > -- reg: Physical base address and length of the GMU registers. > -- reg-names: Matching names for the register regions > - * "gmu" > - * "gmu_pdc" > - * "gmu_pdc_seg" > -- interrupts: The interrupt signals from the GMU. > -- interrupt-names: Matching names for the interrupts > - * "hfi" > - * "gmu" > -- clocks: phandles to the device clocks > -- clock-names: Matching names for the clocks > - * "gmu" > - * "cxo" > - * "axi" > - * "mnoc" The new binding - and arch/arm64/boot/dts/qcom/sdm845.dtsi agrees that "mnoc" is wrong. > -- power-domains: should be: > - <&clock_gpucc GPU_CX_GDSC> > - <&clock_gpucc GPU_GX_GDSC> > -- power-domain-names: Matching names for the power domains > -- iommus: phandle to the adreno iommu > -- operating-points-v2: phandle to the OPP operating points > - > -Optional properties: > -- sram: phandle to the On Chip Memory (OCMEM) that's present on some Snapdragon > - SoCs. See Documentation/devicetree/bindings/sram/qcom,ocmem.yaml. This property is not included in the new binding. Everything else looked fine to me. With sram added - or expalined in commit why it is dropped: Acked-by: Sam Ravnborg Sam